This is a note to let you know that I've just added the patch titled
batman-adv: fix skb->data assignment
to the 3.5-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
batman-adv-fix-skb-data-assignment.patch
and it can be found in the queue-3.5 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.
>From d2b6cc8e460494251442a877fcbc150faa175b4f Mon Sep 17 00:00:00 2001
From: Antonio Quartulli <[email protected]>
Date: Thu, 14 Jun 2012 22:21:28 +0200
Subject: batman-adv: fix skb->data assignment
From: Antonio Quartulli <[email protected]>
commit d2b6cc8e460494251442a877fcbc150faa175b4f upstream.
skb_linearize(skb) possibly rearranges the skb internal data and then changes
the skb->data pointer value. For this reason any other pointer in the code that
was assigned skb->data before invoking skb_linearise(skb) must be re-assigned.
In the current tt_query message handling code this is not done and therefore, in
case of skb linearization, the pointer used to handle the packet header ends up
in pointing to poisoned memory. The packet is then dropped but the
translation-table mechanism is corrupted.
Signed-off-by: Antonio Quartulli <[email protected]>
Signed-off-by: Sven Eckelmann <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
net/batman-adv/routing.c | 2 ++
1 file changed, 2 insertions(+)
--- a/net/batman-adv/routing.c
+++ b/net/batman-adv/routing.c
@@ -626,6 +626,8 @@ int recv_tt_query(struct sk_buff *skb, s
if (unlikely(skb_headlen(skb) <
sizeof(struct tt_query_packet) + tt_len))
goto out;
+ /* skb_linearize() possibly changed skb->data */
+ tt_query = (struct tt_query_packet *)skb->data;
handle_tt_response(bat_priv, tt_query);
} else {
Patches currently in stable-queue which might be from [email protected] are
queue-3.5/batman-adv-fix-skb-data-assignment.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
