On Mon, 2012-05-21 at 00:38 -0500, Jonathan Nieder wrote: > Hi, > > Bernie Thompson wrote: > > On Sun, May 20, 2012 at 5:41 PM, Ben Hutchings <[email protected]> wrote: > > >> Any reason why this shouldn't go into 3.2.y as well? The driver doesn't > >> appear to have changed in any significant way between 3.2 and 3.3. > > > > Hi Ben - Thanks for asking. There are just two commits missing > > between 3.2 and 3.3 > > > > I thought it might conflict with Greg's commit: > > A more basic question is whether there are semantic reasons not to > include it in particular releases. (Checking for textual conflicts > is pretty easy. :)) > > The new patch description says: > > Prior to this patch, were doing too much in > USB > probe(), including starting big transfers to paint the screen of the USB > graphics device. > > However that doesn't explain changes like moving the acquisition of > dev->kfref about 30 lines down. [...]
Which is a bug, I think: the cleanup code for dlfb_usb_probe() now has an unbalanced kref_put(). Ben. -- Ben Hutchings You can't have everything. Where would you put it?
signature.asc
Description: This is a digitally signed message part
