On Fri, 2012-05-18 at 01:41 -0400, David Miller wrote: > From: Herton Ronaldo Krzesinski <[email protected]> > Date: Fri, 18 May 2012 02:09:05 -0300 > > > On Fri, May 18, 2012 at 03:33:06AM +0100, Ben Hutchings wrote: > >> 3.2.18-stable review patch. If anyone has any objections, please let me > >> know. > >> > >> ------------------ > >> > >> From: "Eric W. Biederman" <[email protected]> > >> > >> [ Upstream commit 7d3d43dab4e978d8d9ad1acf8af15c9b1c4b0f0f ] > >> > >> We already synthesize events in register_netdevice_notifier and > >> synthesizing > >> events in unregister_netdevice_notifier allows to us remove the need for > >> special case cleanup code. > >> > >> This change should be safe as it adds no new cases for existing callers > >> of unregiser_netdevice_notifier to handle. > > > > It seems this introduces a regression later fixed by commit > > c57b54684060c8aced64a5b78ff69ff289af97b9 > > Indeed, but thankfully that only hits people who try to unload the > pktgen module which is a pretty small group of people :)
Surely we ought to avoid introducing a known regression. Though I also
see that that the above fix for pktgen was incorrect and the
fix-of-the-fix (d4b1133558e0d417342d5d2c49e4c35b428ff20d) is not in
mainline yet. But if the latter reaches mainline by Sunday, perhaps I
could add them both?
Ben.
--
Ben Hutchings
Experience is directly proportional to the value of equipment destroyed.
- Carolyn Scheppner
signature.asc
Description: This is a digitally signed message part
