On Thu, May 10, 2012 at 04:11:46PM +0200, maximilian attems wrote: > From: Jeff Mahoney <[email protected]> > > The dl2k driver's rio_ioctl call has a few issues: > - No permissions checking > - Implements SIOCGMIIREG and SIOCGMIIREG using the SIOCDEVPRIVATE numbers > - Has a few ioctls that may have been used for debugging at one point > but have no place in the kernel proper. > > This patch removes all but the MII ioctls, renumbers them to use the > standard ones, and adds the proper permission check for SIOCSMIIREG. > > We can also get rid of the dl2k-specific struct mii_data in favor of > the generic struct mii_ioctl_data. > > Since we have the phyid on hand, we can add the SIOCGMIIPHY ioctl too. > > Most of the MII code for the driver could probably be converted to use > the generic MII library but I don't have a device to test the results. > > Reported-by: Stephan Mueller <[email protected]> > Signed-off-by: Jeff Mahoney <[email protected]> > Signed-off-by: David S. Miller <[email protected]> > --- > > Similar patch in Opensuse, included now in 3.4, > applies and compiles cleanly to Debian 3.2, > please consider for stable 3.2 and 3.3.
One final time: <formletter> This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read Documentation/stable_kernel_rules.txt for how to do this properly. </formletter> -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
