p dont think said: >> >> > Can SM runs w/o in non-frame mode? >> >> > >> >> > -rkl >> >> > >> >> >> >> It is in the works, a plugin was created but required a few core > hacks >> > to >> >> get done. I have since rewritten the plugin and have the code to >> > submit >> >> to CVS to get it to work, but I have been busy with other things >> > lately. >> >> I'll put this on the top of my list and get this pushed out >> > immediately! >> > >> > What was the conclusion we came to about making the patch/plugin >> > available for people who want to use it without waiting for 1.5 to > be >> > released? >> > >> > - Paul >> > >> >> I believe we can to the conclusion that it would be best if it was > put >> in 1.5 and a patch(s) released for 1.4 to be included with the plugin. > > The original author pretty much had it ready to go, no? Should we get > him back on it and get something released? > >> I'm currently rewriting part of it to work with the latest devel, > since a >> few minor things have changed since the last time I worked on it. >> >> The only other question we didn't completely come to a conclusion with > is >> whether this should fully be a core thing, or should we have part of > it as >> a plugin? If it was core, it would cut cut down greatly on the > changes >> needing to be made to the core, otherwise we are making alot of > changes >> (mainly just hook additions) just to support a plugin. >> >> I've also been thinking of a better way to do it since the plugin > actually >> doesn't use the code for left_main that we currently use (uses it > own), >> and would have to be updated everytime a bug is fixed in there. > > That's definitely a bad thing. But as to creating a ton of new hooks > just to support this functionality, I say thumbs down, especially since > there seems to be consensus that this can be a core functionality. > > Also, that thread about the new hooks for internal links... it kinda > died, but can I assume that my suggestion of removing those hooks and > just bringing msg_flags in as a core feature instead of as a plugin is > acceptable? I don't want to step on your toes, but I'd like to just > cross this off the list, so I am willing to make the changes if need be. > > Cheers, > > Paul >
In truth, only a few new hooks are created, but they are placed in multiple locations (mainly any place that opens or closes the html page). It really isn't that expensive of a hook, but I definitely agree that this should really be core functionality, and that is the end I am now working for. As for the hooks for internal links, I'm iffy on whether we should wipe them, move them, or core the whole thing. The hook is ran quite abit in its current location, but if we move it to the makelink function, then it should cut down on the calls to only do the top ones, I'll check but I might know an even better place to put it also. IMO not everyone would want this, so it might be best to leave it as a plugin since the tarbal download is already quite huge. The modified version of msg_flags I have runs great as a plugin, so I'm not sure why we would need to core it since its not that expensive of a hook. I have been working on a version that contains multiple themes, ect... and allows users to switch back and forth. The current plugin I have combines the links and the msg_flags (for matching themes). Anyways, if you would like them in the core, then I can patch it fairly easily, and can even integrate the themes to our current scheme probably. I'll see what I can come up with that is snazzy. Jimmy ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf -- squirrelmail-users mailing list List Address: [EMAIL PROTECTED] List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=2995 List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-users
