Re: [Spice-devel] [PATCH spice-server 02/12] Be consistent with opaque type

Tue, 18 Oct 2016 02:14:58 -0700 

On Tue, 2016-10-18 at 10:09 +0100, Frediano Ziglio wrote:
> vdi_port_read_buf_release is registered passing data as
> RedVDIReadBuf*, not RedPipeItem*. Cast opaque to proper
> pointer type to avoid the assumption that first field of
> RedVDIReadBuf is a RedPipeItem.
> 
> Signed-off-by: Frediano Ziglio <[email protected]>
Acked-by: Pavel Grunt <[email protected]>
> ---
>  server/reds.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/server/reds.c b/server/reds.c
> index 79f9c9e..a71029f 100644
> --- a/server/reds.c
> +++ b/server/reds.c
> @@ -745,7 +745,8 @@ static void reds_agent_remove(RedsState *reds)
>  
>  static void vdi_port_read_buf_release(uint8_t *data, void *opaque)
>  {
> -    red_pipe_item_unref((RedPipeItem *)opaque);
> +    RedVDIReadBuf *read_buf = (RedVDIReadBuf *)opaque;
> +    red_pipe_item_unref(&read_buf->base);
>  }
>  
>  /*
_______________________________________________
Spice-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Reply via email to