> > Hey, > > Any more comments on this series? Shall I go ahead with this and push > it? > > Christophe >
The only command I have is go ahead. .proto files describe the protocol so they should be in spice-protocol by definition. Also they are used to produce a file used in spice-protocol but are in spice-common so the lead to a circular dependency between repositories which is a wrong design. The only complaining could be that python code generate code for spice-common but the solution would be to have a modular language for .proto file with possibility to have modules for marshal/demarshal in spice-common while main part in spice-protocol but this could be quite complicated for the limited usage of this code. Frediano > On Mon, Jul 06, 2015 at 06:33:09PM +0200, Christophe Fergeau wrote: > > Hey, > > > > My goal is (once again) to try to remove the use of spice-protocol as a > > submodule, but always use the installed version instead. This work was > > triggered this time by the botched spice-protocol release which might have > > been noticed before release if we did not use a submodule. > > > > This patch series moves the code generation python scripts as well as the > > .proto files to spice-protocol and makes sure they are installed so that > > spice-common can use them. The reason for having these files in > > spice-protocol > > now is so that we can still auto-generate enums.h when the .proto files > > change > > (before spice-common was writing in the spice-protocol submodule directory > > when > > this happened). > > > > Christophe > > _______________________________________________ Spice-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/spice-devel
