On Sun, May 31, 2015 at 12:30:56PM +0300, Dmitry Fleytman wrote: > > > On May 28, 2015, at 18:48 PM, Christophe Fergeau <[email protected]> > > wrote: > > > > On Thu, May 28, 2015 at 01:24:04PM +0300, Kirill Moizik wrote: > >> #ifdef USE_WINUSB > >> use_usbdk = is_usbdk_driver_installed(); > > > > Any reason why line was added before rather than in this commit? > > > Yes, this line is a part of backend selection mechanism. > use_usbdk variable needs to be set and used by previous patches.
But the rest of the code in this commit won't work at all when is_usbdk_driver_installed() returned TRUE, will it? I'd just set use_usbdk to FALSE in this commit as it's just in preparation for usbdk support, and then initialize properly to is_usbdk_driver_installed() once the rest of the code knows how to handle usbdk. Christophe
pgpq4CfBHqcz5.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/spice-devel
