On Mon, Jan 26, 2015 at 06:39:59PM +0100, Marc-André Lureau wrote: > On Mon, Jan 26, 2015 at 6:16 PM, Christophe Fergeau <[email protected]> > wrote: > > Is this hunk strictly needed ? The code flow when the error was emitted > > before exiting was not different, and I expect the old code needed to go > > through there before the coroutine exited ? > > > c->event must be NONE: it should not attempt to reconnect on TLS when > there is an error to report.
My understanding was that before these changes, when g_coroutine_signal_emit was used to emit an error, this part of the code relied on c->state != SPICE_CHANNEL_STATE_RECONNECTING to avoid calling channel_connect(). Is this assertion now wrong after your changes? Christophe
pgp4IfP1eFrC4.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/spice-devel
