On Tue, Nov 25, 2014 at 02:19:27PM +0100, Marc-André Lureau wrote: > It is idiomatic for client code to clean up it's reference on channel
"its reference" > disconnection. Keeping a reference during disconnect help solving "helps" > potential crashes if the session is unref during callbacks. "unref'ed" or something like that Looks good otherwise. Christophe > --- > gtk/spice-session.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gtk/spice-session.c b/gtk/spice-session.c > index f0347db..e00e2b3 100644 > --- a/gtk/spice-session.c > +++ b/gtk/spice-session.c > @@ -1740,6 +1740,7 @@ void spice_session_disconnect(SpiceSession *session) > if (s->disconnecting) > return; > > + g_object_ref(session); > s->disconnecting = TRUE; > s->cmain = NULL; > > @@ -1757,6 +1758,7 @@ void spice_session_disconnect(SpiceSession *session) > > spice_session_abort_migration(session); > s->disconnecting = FALSE; > + g_object_unref(session); > } > > /** > -- > 2.1.0 > > _______________________________________________ > Spice-devel mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/spice-devel
pgpFEc4MWMheg.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/spice-devel
