On Mon, Aug 19, 2013 at 04:53:21PM +0200, Hans de Goede wrote: > The destroy function passed to g_slist_free_full should be passed the elements > data pointer, not the element itself. > > Signed-off-by: Hans de Goede <[email protected]> > --- > gtk/glib-compat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gtk/glib-compat.c b/gtk/glib-compat.c > index 21be1f6..c3bb8e6 100644 > --- a/gtk/glib-compat.c > +++ b/gtk/glib-compat.c > @@ -88,7 +88,7 @@ g_slist_free_full(GSList *list, > > if (free_func) { > for (el = list; el ; el = g_slist_next(el)) { > - free_func(el); > + free_func(el->data); > }
Can't we just c&p the glib function instead? This is what I do whenever
possible:
void
g_slist_free_full (GSList *list, GDestroyNotify free_func)
{
g_slist_foreach (list, (GFunc) free_func, NULL);
g_slist_free (list);
}
Christophe
pgpYqpP3dFH0y.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/spice-devel
