Ack.

On 03/22/2011 05:22 PM, Christophe Fergeau wrote:
clang static analyzer warned that 'len' was computed but never
used in glc_vertex2d. glc_stroke_line_dash has side effects so
we have to call it, but we don't need to save its return value
since it's not used.
---
  common/glc.c |    5 ++---
  1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/common/glc.c b/common/glc.c
index e4263cd..e58718f 100644
--- a/common/glc.c
+++ b/common/glc.c
@@ -1147,10 +1147,9 @@ static double glc_stroke_line_dash(double x1, double y1, 
double x2, double y2,

  static void glc_vertex2d(InternaCtx *ctx, double x, double y)
  {
-    double len;
      if (ctx->path_stroke.state == GLC_STROKE_ACTIVE) {
-        len = glc_stroke_line_dash(ctx->path_stroke.x, ctx->path_stroke.y, x, 
y,
-                                   ctx->line_width,&ctx->line_dash);
+        glc_stroke_line_dash(ctx->path_stroke.x, ctx->path_stroke.y, x, y,
+                             ctx->line_width,&ctx->line_dash);
          ctx->path_stroke.x = x;
          ctx->path_stroke.y = y;
      } else if (ctx->path_stroke.state == GLC_STROKE_FIRST) {
_______________________________________________
Spice-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/spice-devel

Reply via email to