On Sat, Jan 30, 2010 at 5:08 AM, Chris Hostetter <hossman_luc...@fucit.org>wrote:
> > : never keep a <str name="maxOptimizedCommitsToKeep">0</str>. > : > : It is better to leave not mention the deletionPolicy at all. The > : defaults are usually fine. > > if setting the "keep" values to 0 results in NPEs we should do one (if not > both) of the following... > > 1) change the init code to warn/fail if the values are 0 (not sure if > there is ever a legitimate use for 0 as a value) > > 2) change the code that's currently throwing an NPE to check it's > assumptings and log a more meaninful error if it can't function because of > the existing config. > > Setting the keep values to 0 does not result in NPEs. Setting both maxCommitsToKeep and maxOptimizedCommitsToKeep to 0 is invalid and should be checked for. However, this problem is different. We use the same configuration in production and we haven't seen an NPE like that. I'm not able to reproduce this locally too. -- Regards, Shalin Shekhar Mangar.
