I haven't looked nor tried your patch (just saw it come into JIRA) yet, but I would welcome having stats in one place and real-time instead of (really: in addition to) analyzing logs.
Otis ----- Original Message ---- From: Will Johnson <[EMAIL PROTECTED]> To: solr-user@lucene.apache.org Sent: Wednesday, May 16, 2007 2:02:12 PM Subject: RE: Requests per second/minute monitor? Adding entries to RequestHandlerBase.getStatistics() sounds like it might be a reasonable compromise; backwards compatibility is kept in place but everything from now on gets the added advantages of more tracking. So far I've added (because I need) avgTimePerRequest avgRequestsPerSecond I agree that you can pull this kind of information from logs but jmx accessibility + the built in stats page make life a good bit simpler especially in distributed environments. Are there any others that people think would be nice to have or should I stop all together? - will -----Original Message----- From: Mike Klaas [mailto:[EMAIL PROTECTED] Sent: Tuesday, May 15, 2007 5:04 PM To: solr-user@lucene.apache.org Subject: Re: Requests per second/minute monitor? On 15-May-07, at 1:41 PM, Chris Hostetter wrote: > : I'm happy to make the changes and supply a patch to move the > logic as > : well as adding a few simple metrics unless enough people on this > thread > : really feel that it's always better to do it with log files and > : postmortem math. > > moving the logic would be bad .. adding new helper utilities to the > RequestHandler Base for handlers that want to do more sounds fine > to me. > > see also http://issues.apache.org/jira/browse/SOLR-176 which > already adds > a lot of timing info to requests. Yeah, I held off on that as it seemed that timing/statistics might be handleable on a larger scale. OTOH, it does give an easy way to requesthandlers to insert detailed timing data in a logical place in the output. -Mike
