[PATCH v2 xserver 3/4] dri2: refine dri2_probe_driver_name (v2)

2017-01-10 Thread Qiang Yu
V2: 1. update comment 2. check bustype if PCI 3. configure add libdrm version check for drmGetDevice Get PCI information from info->fd with drmGetDevice instead of assuming the info->fd is the first entity of scrn which is not true for multi entities scrn. Signed-off-by: Qiang Yu --- configure.

Re: [PATCH xserver 0/4] some bug fix and improvement

2017-01-10 Thread Peter Hutterer
On Tue, Jan 10, 2017 at 06:51:53PM +0800, Qiang Yu wrote: > FYI. Found when MS_ALL_IN_ONE work. > > Qiang Yu (4): > xfree86: fix wrong usage of xf86optionListMerge > randr: fix xserver crash when xrandr setprovideroutputsource > modesetting: cleanup pci device open these ones pushed as e47

Re: [PATCH xserver 3/4] dri2: refine dri2_probe_driver_name

2017-01-10 Thread Emil Velikov
Hi Yu, Qiang, Can I interest you in fixing your email client or using one that supports inline quoting ? On 10 January 2017 at 14:07, Yu, Qiang wrote: > > Hi Emil, > >> /* For non-PCI devices, just assume that the 3D driver is named >> * the same as the kernel driver. This is current

Re: [PATCH xserver 4/4] modesetting: cleanup pci device open

2017-01-10 Thread Hans de Goede
Hi, On 10-01-17 11:51, Qiang Yu wrote: Signed-off-by: Qiang Yu Patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans --- hw/xfree86/drivers/modesetting/driver.c | 24 +++- hw/xfree86/drivers/modesetting/driver.h | 6 -- 2 files changed, 11 insert

Re: [PATCH xserver 2/4] randr: fix xserver crash when xrandr setprovideroutputsource

2017-01-10 Thread Hans de Goede
Hi, On 10-01-17 11:51, Qiang Yu wrote: xrandr --setprovideroutputsource Xorg: ../../../xserver/dix/dispatch.c:4018: AttachOutputGPU: Assertion `new->isGPU' failed. GPUScreen is not allowed to be sink output. Signed-off-by: Qiang Yu Patch looks good to me: Reviewed-by: Hans de Goede Re

Re: [PATCH xserver 1/4] xfree86: fix wrong usage of xf86optionListMerge

2017-01-10 Thread Hans de Goede
Hi, On 10-01-17 11:51, Qiang Yu wrote: Signed-off-by: Qiang Yu Patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans --- hw/xfree86/common/xf86Option.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xfree86/common/xf86Option.c b/hw/xfree86/common/xf8

Re: [tigervnc-devel] PATCH: Add xorg-xserver 1.19 support to tigervnc

2017-01-10 Thread Pierre Ossman
On 09/01/17 20:15, Hans de Goede wrote: Yes I agree that would be better, Pierre, can you take care of merging Alan's improved version ? All done and available on master now. Thanks for fixing this. Regards -- Pierre Ossman Software Development Cendio AB https://cendi

Re: [PATCH xserver 3/4] dri2: refine dri2_probe_driver_name

2017-01-10 Thread Yu, Qiang
Hi Emil, > /* For non-PCI devices, just assume that the 3D driver is named > * the same as the kernel driver. This is currently true for vc4 > * and msm (freedreno). > */ > -if (!pdev) { > +if (drmGetDevice(info->fd, &dev)) { This does not align with the comment ab

Re: [PATCH xserver 3/4] dri2: refine dri2_probe_driver_name

2017-01-10 Thread Emil Velikov
On 10 January 2017 at 10:51, Qiang Yu wrote: > Get PCI information from info->fd with drmGetDevice instead of > assuming the info->fd is the first entity of scrn which is not > true for multi entities scrn. > IIRC you want to bump the libdrm version in configure to one that provides the API. > Si

[PATCH xserver 2/4] randr: fix xserver crash when xrandr setprovideroutputsource

2017-01-10 Thread Qiang Yu
xrandr --setprovideroutputsource Xorg: ../../../xserver/dix/dispatch.c:4018: AttachOutputGPU: Assertion `new->isGPU' failed. GPUScreen is not allowed to be sink output. Signed-off-by: Qiang Yu --- randr/rrprovider.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/randr/rrprovider.c b/r

[PATCH xserver 0/4] some bug fix and improvement

2017-01-10 Thread Qiang Yu
FYI. Found when MS_ALL_IN_ONE work. Qiang Yu (4): xfree86: fix wrong usage of xf86optionListMerge randr: fix xserver crash when xrandr setprovideroutputsource dri2: refine dri2_probe_driver_name modesetting: cleanup pci device open hw/xfree86/common/xf86Option.c | 2 +- hw/xfre

[PATCH xserver 1/4] xfree86: fix wrong usage of xf86optionListMerge

2017-01-10 Thread Qiang Yu
Signed-off-by: Qiang Yu --- hw/xfree86/common/xf86Option.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xfree86/common/xf86Option.c b/hw/xfree86/common/xf86Option.c index 929724d..06973bc 100644 --- a/hw/xfree86/common/xf86Option.c +++ b/hw/xfree86/common/xf86Option.c @@

[PATCH xserver 3/4] dri2: refine dri2_probe_driver_name

2017-01-10 Thread Qiang Yu
Get PCI information from info->fd with drmGetDevice instead of assuming the info->fd is the first entity of scrn which is not true for multi entities scrn. Signed-off-by: Qiang Yu --- hw/xfree86/dri2/dri2.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(

[PATCH xserver 4/4] modesetting: cleanup pci device open

2017-01-10 Thread Qiang Yu
Signed-off-by: Qiang Yu --- hw/xfree86/drivers/modesetting/driver.c | 24 +++- hw/xfree86/drivers/modesetting/driver.h | 6 -- 2 files changed, 11 insertions(+), 19 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/driver.c b/hw/xfree86/drivers/modesetting/driver