[PATCH 44/45] block: merge struct block_device and struct hd_struct

2020-11-24 Thread Christoph Hellwig
Instead of having two structures that represent each block device with different life time rules, merge them into a single one. This also greatly simplifies the reference counting rules, as we can use the inode reference count as the main reference count for the new struct block_device, with the d

merge struct block_device and struct hd_struct v2

2020-11-24 Thread Christoph Hellwig
Hi Jens, this series cleans up our main per-device node data structure by merging the block_device and hd_struct data structures that have the same scope, but different life times. The main effect (besides removing lots of code) is that instead of having two device sizes that need complex synchro

Re: [PATCH 15/20] block: merge struct block_device and struct hd_struct

2020-11-20 Thread Jan Kara
On Fri 20-11-20 10:15:46, Christoph Hellwig wrote: > On Thu, Nov 19, 2020 at 03:39:21PM +0100, Jan Kara wrote: > > This patch is kind of difficult to review due to the size of mostly > > mechanical changes mixed with not completely mechanical changes. Can we > > perhaps split out the mechanical bit

Re: [PATCH 15/20] block: merge struct block_device and struct hd_struct

2020-11-20 Thread Christoph Hellwig
On Thu, Nov 19, 2020 at 03:39:21PM +0100, Jan Kara wrote: > This patch is kind of difficult to review due to the size of mostly > mechanical changes mixed with not completely mechanical changes. Can we > perhaps split out the mechanical bits? E.g. the rq->part => rq->bdev > renaming is mechanical a

Re: [PATCH 74/78] block: merge struct block_device and struct hd_struct

2020-11-20 Thread Hannes Reinecke
On 11/16/20 3:58 PM, Christoph Hellwig wrote: Instead of having two structures that represent each block device with different lift time rules merged them into a single one. This also greatly simplifies the reference counting rules, as we can use the inode reference count as the main reference c

Re: [PATCH 15/20] block: merge struct block_device and struct hd_struct

2020-11-19 Thread Jan Kara
On Wed 18-11-20 09:47:55, Christoph Hellwig wrote: > Instead of having two structures that represent each block device with > different lift time rules merged them into a single one. This also ^^^ :) life merge > greatly simplifies the reference counting rules, as we can use

Re: merge struct block_device and struct hd_struct

2020-11-18 Thread Matthew Wilcox
On Wed, Nov 18, 2020 at 10:23:51AM +0100, Jan Beulich wrote: > On 18.11.2020 10:09, Greg KH wrote: > > On Wed, Nov 18, 2020 at 10:04:04AM +0100, Jan Beulich wrote: > >> On 18.11.2020 09:58, Christoph Hellwig wrote: > >>> On Wed, Nov 18, 2020 at 09:56:11AM +0100, Jan Beulich wrote: > since this

Re: merge struct block_device and struct hd_struct

2020-11-18 Thread Greg KH
On Wed, Nov 18, 2020 at 10:23:51AM +0100, Jan Beulich wrote: > On 18.11.2020 10:09, Greg KH wrote: > > On Wed, Nov 18, 2020 at 10:04:04AM +0100, Jan Beulich wrote: > >> On 18.11.2020 09:58, Christoph Hellwig wrote: > >>> On Wed, Nov 18, 2020 at 09:56:11AM +0100, Jan Beulich wrote: > since this

Re: merge struct block_device and struct hd_struct

2020-11-18 Thread Jan Beulich
On 18.11.2020 10:09, Greg KH wrote: > On Wed, Nov 18, 2020 at 10:04:04AM +0100, Jan Beulich wrote: >> On 18.11.2020 09:58, Christoph Hellwig wrote: >>> On Wed, Nov 18, 2020 at 09:56:11AM +0100, Jan Beulich wrote: since this isn't the first series from you recently spamming xen-devel, may

Re: merge struct block_device and struct hd_struct

2020-11-18 Thread Greg KH
On Wed, Nov 18, 2020 at 09:47:40AM +0100, Christoph Hellwig wrote: > Hi Jens, > > this series cleans up our main per-device node data structure by merging > the block_device and hd_struct data structures that have the same scope, > but different life times. The main effect (besides removing lots

Re: merge struct block_device and struct hd_struct

2020-11-18 Thread Greg KH
On Wed, Nov 18, 2020 at 10:04:04AM +0100, Jan Beulich wrote: > On 18.11.2020 09:58, Christoph Hellwig wrote: > > On Wed, Nov 18, 2020 at 09:56:11AM +0100, Jan Beulich wrote: > >> since this isn't the first series from you recently spamming > >> xen-devel, may I ask that you don't Cc entire series t

Re: merge struct block_device and struct hd_struct

2020-11-18 Thread Christoph Hellwig
On Wed, Nov 18, 2020 at 10:04:04AM +0100, Jan Beulich wrote: > That's the view of some people, but not all. Context can be easily > established by those who care going to one of the many archives on > which the entire series lands. Getting spammed, however, can't be > avoided by the dozens or hundr

Re: merge struct block_device and struct hd_struct

2020-11-18 Thread Jan Beulich
On 18.11.2020 09:58, Christoph Hellwig wrote: > On Wed, Nov 18, 2020 at 09:56:11AM +0100, Jan Beulich wrote: >> since this isn't the first series from you recently spamming >> xen-devel, may I ask that you don't Cc entire series to lists >> which are involved with perhaps just one out of the many p

[PATCH 15/20] block: merge struct block_device and struct hd_struct

2020-11-18 Thread Christoph Hellwig
Instead of having two structures that represent each block device with different lift time rules merged them into a single one. This also greatly simplifies the reference counting rules, as we can use the inode reference count as the main reference count for the new struct block_device, with the d

Re: merge struct block_device and struct hd_struct

2020-11-18 Thread Christoph Hellwig
On Wed, Nov 18, 2020 at 09:56:11AM +0100, Jan Beulich wrote: > since this isn't the first series from you recently spamming > xen-devel, may I ask that you don't Cc entire series to lists > which are involved with perhaps just one out of the many patches? > IMO Cc lists should be compiled on a per-

Re: merge struct block_device and struct hd_struct

2020-11-18 Thread Jan Beulich
Christoph, On 18.11.2020 09:47, Christoph Hellwig wrote: > Diffstat: > block/bio.c |6 > block/blk-cgroup.c | 50 +- > block/blk-core.c | 85 +-- > block/blk-flush.c|2

merge struct block_device and struct hd_struct

2020-11-18 Thread Christoph Hellwig
Hi Jens, this series cleans up our main per-device node data structure by merging the block_device and hd_struct data structures that have the same scope, but different life times. The main effect (besides removing lots of code) is that instead of having two device sizes that need complex synchro

[PATCH 74/78] block: merge struct block_device and struct hd_struct

2020-11-16 Thread Christoph Hellwig
Instead of having two structures that represent each block device with different lift time rules merged them into a single one. This also greatly simplifies the reference counting rules, as we can use the inode reference count as the main reference count for the new struct block_device, with the d