Re: Xen Coding style and clang-format

октября 2020 г. 13:24 > > > To: Anastasiia Lukianenko ; > > > [email protected]; [email protected] > > > Cc: Artem Mygaiev ; [email protected]; > > > [email protected]; [email protected]; > > > [email protected]; Volody

Re: Xen Coding style and clang-format

; [email protected]; [email protected]; [email protected]; Volodymyr Babchuk Subject: Re: Xen Coding style and clang-format Hi, On 16/10/2020 10:42, Anastasiia Lukianenko wrote: Thanks for your advices, which helped me improve the checker. I understand that there

RE: Xen Coding style and clang-format

nproject.org; [email protected]; > [email protected]; Volodymyr Babchuk > Subject: Re: Xen Coding style and clang-format > > > Hi, > > > > On 16/10/2020 10:42, Anastasiia Lukianenko wrote: > > > Thanks for your advices, which helped me improve

RE: Xen Coding style and clang-format

; Volodymyr Babchuk Subject: Re: Xen Coding style and clang-format > Hi, > > On 16/10/2020 10:42, Anastasiia Lukianenko wrote: > > Thanks for your advices, which helped me improve the checker. I > > understand that there are still some disagreements about the > > formatting

Re: Xen Coding style and clang-format

Hi, On 16/10/2020 10:42, Anastasiia Lukianenko wrote: Thanks for your advices, which helped me improve the checker. I understand that there are still some disagreements about the formatting, but as I said before, the checker cannot be very flexible and take into account all the author's ideas.

Re: Xen Coding style and clang-format

Hi all, On Tue, 2020-10-13 at 14:30 +0200, Jan Beulich wrote: > On 12.10.2020 20:09, George Dunlap wrote: > > > On Oct 7, 2020, at 11:19 AM, Anastasiia Lukianenko < > > > [email protected]> wrote: > > > So I want to know if the community is ready to add new formatting > > > options an

Re: Xen Coding style and clang-format

On 12.10.2020 20:09, George Dunlap wrote: >> On Oct 7, 2020, at 11:19 AM, Anastasiia Lukianenko >> wrote: >> So I want to know if the community is ready to add new formatting >> options and edit old ones. Below I will give examples of what >> corrections the checker is currently making (the first

Re: Xen Coding style and clang-format

> On Oct 7, 2020, at 11:19 AM, Anastasiia Lukianenko > wrote: > > Hi all, > > On Thu, 2020-10-01 at 10:06 +, George Dunlap wrote: >>> On Oct 1, 2020, at 10:06 AM, Anastasiia Lukianenko < >>> [email protected]> wrote: >>> >>> Hi, >>> >>> On Wed, 2020-09-30 at 10:24 +, Ge

Re: Xen Coding style and clang-format

Hi all, On Wed, 2020-10-07 at 18:07 -0700, Stefano Stabellini wrote: > On Wed, 7 Oct 2020, Anastasiia Lukianenko wrote: > > On Thu, 2020-10-01 at 10:06 +, George Dunlap wrote: > > > > On Oct 1, 2020, at 10:06 AM, Anastasiia Lukianenko < > > > > [email protected]> wrote: > > > > >

Re: Xen Coding style and clang-format

On Wed, 7 Oct 2020, Anastasiia Lukianenko wrote: > On Thu, 2020-10-01 at 10:06 +, George Dunlap wrote: > > > On Oct 1, 2020, at 10:06 AM, Anastasiia Lukianenko < > > > [email protected]> wrote: > > > > > > Hi, > > > > > > On Wed, 2020-09-30 at 10:24 +, George Dunlap wrote: >

Re: Xen Coding style and clang-format

Hi all, On Thu, 2020-10-01 at 10:06 +, George Dunlap wrote: > > On Oct 1, 2020, at 10:06 AM, Anastasiia Lukianenko < > > [email protected]> wrote: > > > > Hi, > > > > On Wed, 2020-09-30 at 10:24 +, George Dunlap wrote: > > > > On Sep 30, 2020, at 10:57 AM, Jan Beulich > > >

Re: Xen Coding style and clang-format

> On Oct 1, 2020, at 10:06 AM, Anastasiia Lukianenko > wrote: > > Hi, > > On Wed, 2020-09-30 at 10:24 +, George Dunlap wrote: >>> On Sep 30, 2020, at 10:57 AM, Jan Beulich >>> wrote: >>> >>> On 30.09.2020 11:18, Anastasiia Lukianenko wrote: I would like to know your opinion on the

Re: Xen Coding style and clang-format

Hi, On Wed, 2020-09-30 at 10:24 +, George Dunlap wrote: > > On Sep 30, 2020, at 10:57 AM, Jan Beulich > > wrote: > > > > On 30.09.2020 11:18, Anastasiia Lukianenko wrote: > > > I would like to know your opinion on the following coding style > > > cases. > > > Which option do you think is cor

Re: Xen Coding style and clang-format

> On Sep 30, 2020, at 10:57 AM, Jan Beulich wrote: > > On 30.09.2020 11:18, Anastasiia Lukianenko wrote: >> I would like to know your opinion on the following coding style cases. >> Which option do you think is correct? >> 1) Function prototype when the string length is longer than the allowed

Re: Xen Coding style and clang-format

On 30.09.2020 11:18, Anastasiia Lukianenko wrote: > I would like to know your opinion on the following coding style cases. > Which option do you think is correct? > 1) Function prototype when the string length is longer than the allowed > one > -static int __init > -acpi_parse_gic_cpu_interface(str

Xen Coding style and clang-format

Hi all, I would like to bring up a discussion about a Xen-checker tool, the development of which has been temporarily suspended. The idea of this tool is to use the clang-format approach as a base for Xen ‘checkpatch’ process. The new tool consists of modified clang-format binary and modified clan

Re: [Xen-devel] Xen Coding style and clang-format

Hi Tamas, On Thu, Aug 1, 2019 at 6:58 PM Tamas K Lengyel wrote: > > On Thu, Aug 1, 2019 at 4:06 AM Viktor Mitin wrote: > > > > On Wed, Jul 31, 2019 at 8:05 PM Viktor Mitin > > wrote: > > > > > > On Wed, Jul 31, 2019 at 7:27 PM Lars Kurth > > > wrote: > > > > > > > Viktor: thank you for spend

Re: [Xen-devel] Xen Coding style and clang-format

On Thu, Aug 1, 2019 at 4:06 AM Viktor Mitin wrote: > > On Wed, Jul 31, 2019 at 8:05 PM Viktor Mitin > wrote: > > > > On Wed, Jul 31, 2019 at 7:27 PM Lars Kurth wrote: > > > > > Viktor: thank you for spending time on this > > > > > > I added an item to community call tomorrow and CC'ed you in th

Re: [Xen-devel] Xen Coding style and clang-format

On Wed, Jul 31, 2019 at 8:05 PM Viktor Mitin wrote: > > On Wed, Jul 31, 2019 at 7:27 PM Lars Kurth wrote: > > > Viktor: thank you for spending time on this > > > > I added an item to community call tomorrow and CC'ed you in the invite. So > > I think what we need to do is figure out a way on how

Re: [Xen-devel] Xen Coding style and clang-format

On Wed, Jul 31, 2019 at 7:27 PM Lars Kurth wrote: > Viktor: thank you for spending time on this > > I added an item to community call tomorrow and CC'ed you in the invite. So I > think what we need to do is figure out a way on how to make the coding > standard enforceable by a coding standard c

Re: [Xen-devel] Xen Coding style and clang-format

> On 31 Jul 2019, at 12:43, Viktor Mitin wrote: > > On Wed, Jul 31, 2019 at 2:25 PM Julien Grall > wrote: >> >> >> >> On 31/07/2019 12:16, Viktor Mitin wrote: >>> On Mon, Jul 29, 2019 at 3:35 PM Julien Grall wrote: On 7/29/19 1:21 PM, Viktor Mitin wrote: >

Re: [Xen-devel] Xen Coding style and clang-format

On Wed, Jul 31, 2019 at 2:25 PM Julien Grall wrote: > > > > On 31/07/2019 12:16, Viktor Mitin wrote: > > On Mon, Jul 29, 2019 at 3:35 PM Julien Grall wrote: > >> On 7/29/19 1:21 PM, Viktor Mitin wrote: > >>> On Mon, Jul 29, 2019 at 1:49 PM Julien Grall wrote: > On 7/29/19 10:13 AM, Viktor M

Re: [Xen-devel] Xen Coding style and clang-format

On 31/07/2019 12:16, Viktor Mitin wrote: On Mon, Jul 29, 2019 at 3:35 PM Julien Grall wrote: On 7/29/19 1:21 PM, Viktor Mitin wrote: On Mon, Jul 29, 2019 at 1:49 PM Julien Grall wrote: On 7/29/19 10:13 AM, Viktor Mitin wrote: On Fri, Jul 26, 2019 at 3:50 PM Julien Grall wrote: * -

Re: [Xen-devel] Xen Coding style and clang-format

Hi Julien, On Mon, Jul 29, 2019 at 3:35 PM Julien Grall wrote: > > Hi Viktor, > > On 7/29/19 1:21 PM, Viktor Mitin wrote: > > On Mon, Jul 29, 2019 at 1:49 PM Julien Grall wrote: > >> On 7/29/19 10:13 AM, Viktor Mitin wrote: > >>> On Fri, Jul 26, 2019 at 3:50 PM Julien Grall wrote: > >> > >>> It

Re: [Xen-devel] Xen Coding style and clang-format

Hi Viktor, On 7/29/19 1:21 PM, Viktor Mitin wrote: On Mon, Jul 29, 2019 at 1:49 PM Julien Grall wrote: On 7/29/19 10:13 AM, Viktor Mitin wrote: On Fri, Jul 26, 2019 at 3:50 PM Julien Grall wrote: It is unknown how difficult it would be to implement that with clang-format, however, it can

Re: [Xen-devel] Xen Coding style and clang-format

Hi Julien, On Mon, Jul 29, 2019 at 1:49 PM Julien Grall wrote: > > Hi, > > On 7/29/19 10:13 AM, Viktor Mitin wrote: > > On Fri, Jul 26, 2019 at 3:50 PM Julien Grall wrote: > >> > >> I have already done some testings a couple of weeks ago with the patch > >> [1]. I > >> have sent some comments r

Re: [Xen-devel] Xen Coding style and clang-format

Hi, On 7/29/19 10:13 AM, Viktor Mitin wrote: On Fri, Jul 26, 2019 at 3:50 PM Julien Grall wrote: I have already done some testings a couple of weeks ago with the patch [1]. I have sent some comments regarding the change made by the tools that require some attention. It would be good if someon

Re: [Xen-devel] Xen Coding style and clang-format

Hi Julien, On Fri, Jul 26, 2019 at 3:50 PM Julien Grall wrote: > > I have already done some testings a couple of weeks ago with the patch [1]. I > have sent some comments regarding the change made by the tools that require > some > attention. It would be good if someone go through them and try t

Re: [Xen-devel] Xen Coding style and clang-format

> On 26 Jul 2019, at 15:17, Viktor Mitin wrote: > > On Fri, Jul 26, 2019 at 4:52 PM Lars Kurth wrote: thank you for putting this mail together and driving this forward. I added committers@ as well as Doug. I am going to let others respond first. I am assuming we are looking for

Re: [Xen-devel] Xen Coding style and clang-format

On Fri, Jul 26, 2019 at 4:52 PM Lars Kurth wrote: > >> thank you for putting this mail together and driving this forward. I added > >> committers@ as well as Doug. I am going to let others respond first. > >> I am assuming we are looking for some testing? > > > > Yes, you are right. > > The imple

Re: [Xen-devel] Xen Coding style and clang-format

> On 26 Jul 2019, at 14:45, Viktor Mitin wrote: > >> Hi Viktor, > > Hi Lars, > >> thank you for putting this mail together and driving this forward. I added >> committers@ as well as Doug. I am going to let others respond first. >> I am assuming we are looking for some testing? > > Yes, you

Re: [Xen-devel] Xen Coding style and clang-format

Hi Julien, > I have already done some testings a couple of weeks ago with the patch [1]. I > have sent some comments regarding the change made by the tools that require > some > attention. It would be good if someone go through them and try to address one > by > one. For convenience I have repli

Re: [Xen-devel] Xen Coding style and clang-format

> Hi Viktor, Hi Lars, > thank you for putting this mail together and driving this forward. I added > committers@ as well as Doug. I am going to let others respond first. > I am assuming we are looking for some testing? Yes, you are right. The implementation has been updated and retested with ne

Re: [Xen-devel] Xen Coding style and clang-format

On 26/07/2019 13:42, Lars Kurth wrote: Hi Viktor, Hi, thank you for putting this mail together and driving this forward. I added committers@ as well as Doug. I am going to let others respond first. I am assuming we are looking for some testing? I have already done some testings a couple

Re: [Xen-devel] Xen Coding style and clang-format

> On 26 Jul 2019, at 13:30, Viktor Mitin wrote: > > Hi All, > > The Xen Project has a coding standard in place, but like many > projects, the standard is only enforced through peer review. Such > mistakes slip through and code is imported from other projects which > may not follow the same sta

[Xen-devel] Xen Coding style and clang-format

Hi All, The Xen Project has a coding standard in place, but like many projects, the standard is only enforced through peer review. Such mistakes slip through and code is imported from other projects which may not follow the same standard. The goal would be to come up with a tool that can audit the