Re: [PATCH v4 01/12] powerpc/64s: Do not re-activate batched TLB flush

Kevin Brodsky writes: > On 05/11/2025 02:46, Ritesh Harjani (IBM) wrote: >> Kevin Brodsky writes: >> >>> From: Alexander Gordeev >>> >>> Since commit b9ef323ea168 ("powerpc/64s: Disable preemption in hash >>> lazy mmu mode") a ta

Re: [PATCH v4 07/12] mm: enable lazy_mmu sections to nest

Ritesh Harjani (IBM) writes: > For e.g... > > arch_enter_lazy_mmu_mode() > hpte_need_flush() > get_cpu_var() // this takes care of preempt_disable() > adds vpns to per-cpu batch[i] > put_cpu_var() // >

Re: [PATCH v4 07/12] mm: enable lazy_mmu sections to nest

Alexander Gordeev writes: > On Wed, Nov 05, 2025 at 02:19:03PM +0530, Ritesh Harjani wrote: >> > + * in_lazy_mmu_mode() can be used to check whether the lazy MMU mode is >> > + * currently enabled. >> > */ >> > #ifdef CONFIG_ARCH_HAS_LAZY_MMU_MODE >> > static inline void lazy_mmu_mode_enable(

Re: [PATCH v4 03/12] powerpc/mm: implement arch_flush_lazy_mmu_mode()

Ritesh Harjani (IBM) writes: > Kevin Brodsky writes: > >> Upcoming changes to the lazy_mmu API will cause >> arch_flush_lazy_mmu_mode() to be called when leaving a nested >> lazy_mmu section. >> >> Move the relevant logic from arch_leave_lazy_mmu_mode() to &g

Re: [PATCH v4 09/12] powerpc/mm: replace batch->active with in_lazy_mmu_mode()

clude/asm/book3s/64/tlbflush-hash.h | 9 - > arch/powerpc/mm/book3s64/hash_tlb.c| 2 +- > 2 files changed, 1 insertion(+), 10 deletions(-) > This looks good to me. Reviewed-by: Ritesh Harjani (IBM)

Re: [PATCH v4 07/12] mm: enable lazy_mmu sections to nest

Kevin Brodsky writes: > Despite recent efforts to prevent lazy_mmu sections from nesting, it > remains difficult to ensure that it never occurs - and in fact it > does occur on arm64 in certain situations (CONFIG_DEBUG_PAGEALLOC). > Commit 1ef3095b1405 ("arm64/mm: Permit lazy_mmu_mode to be neste

Re: [PATCH v4 05/12] mm: introduce CONFIG_ARCH_HAS_LAZY_MMU_MODE

patch, the changes are mostly straight forward around the configs part. This looks good to me. Please feel free to add: Reviewed-by: Ritesh Harjani (IBM) -ritesh

Re: [PATCH v4 03/12] powerpc/mm: implement arch_flush_lazy_mmu_mode()

Kevin Brodsky writes: > Upcoming changes to the lazy_mmu API will cause > arch_flush_lazy_mmu_mode() to be called when leaving a nested > lazy_mmu section. > > Move the relevant logic from arch_leave_lazy_mmu_mode() to > arch_flush_lazy_mmu_mode() and have the former call the latter. > > Note: th

Re: [PATCH v4 01/12] powerpc/64s: Do not re-activate batched TLB flush

patch series a try on Power HW with Hash mmu too (which uses lazy mmu and let you know the results of that)! For this patch please feel free to add: Reviewed-by: Ritesh Harjani (IBM) CC: Venkat who also runs CI on linux Power HW for upstream testing :) -ritesh > diff --git a/arch/powerpc/inc

Re: [PATCH v3 06/11] powerpc/ptdump: rename "struct pgtable_level" to "struct ptdump_pglevel"

my book3s64 and ppc32 platform. I think we should fix the subject line.. s/ptdump_pglevel/ptdump_pg_level Otherwise the changes looks good to me. So please feel free to add - Reviewed-by: Ritesh Harjani (IBM) > > diff --git a/arch/powerpc/mm/ptdump/8xx.c b/arch/powerpc/mm/ptdump/8xx.c >