[xen-unstable-smoke test] 186216: tolerable all pass - PUSHED

2024-05-31 Thread osstest service owner
flight 186216 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/186216/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[linux-linus test] 186212: tolerable FAIL - PUSHED

2024-05-31 Thread osstest service owner
flight 186212 linux-linus real [real] flight 186215 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/186212/ http://logs.test-lab.xenproject.org/osstest/logs/186215/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-

Re: [PATCH v2 07/13] x86/bitops: Improve arch_ffs() in the general case

2024-05-31 Thread Andrew Cooper
On 28/05/2024 2:12 pm, Jan Beulich wrote: > On 28.05.2024 14:30, Andrew Cooper wrote: >> On 27/05/2024 2:37 pm, Jan Beulich wrote: >>> On 27.05.2024 15:27, Jan Beulich wrote: On 24.05.2024 22:03, Andrew Cooper wrote: > --- a/xen/arch/x86/include/asm/bitops.h > +++ b/xen/arch/x86/includ

[xen-unstable-smoke test] 186213: tolerable all pass - PUSHED

2024-05-31 Thread osstest service owner
flight 186213 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/186213/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: NULL pointer dereference in xenbus_thread->...

2024-05-31 Thread Marek Marczykowski-Górecki
On Tue, Mar 26, 2024 at 11:00:50AM +, Julien Grall wrote: > Hi Marek, > > +Juergen for visibility > > When sending a bug report, I would suggest to CC relevant people as > otherwise it can get lost (not may people monitors Xen devel if they are not > CCed). > > Cheers, > > On 25/03/2024 16:

Re: [PATCH v2 02/13] xen/bitops: Cleanup ahead of rearrangements

2024-05-31 Thread Andrew Cooper
On 27/05/2024 9:24 am, Jan Beulich wrote: > On 24.05.2024 22:03, Andrew Cooper wrote: >> * Rename __attribute_pure__ to just __pure before it gains users. >> * Introduce __constructor which is going to be used in lib/, and is >>unconditionally cf_check. >> * Identify the areas of xen/bitops.

[ovmf test] 186211: all pass - PUSHED

2024-05-31 Thread osstest service owner
flight 186211 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/186211/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 3b36aa96de1d5f7a4660bec5c0cbad2616183dd6 baseline version: ovmf 7c584bb04874bb5bad16f

Re: [RFC PATCH v2] arm: dom0less: add TEE support

2024-05-31 Thread Volodymyr Babchuk
Hello all, Volodymyr Babchuk writes: > Extend TEE mediator interface with two functions : > > - tee_get_type_from_dts() returns TEE type based on input string > - tee_make_dtb_node() creates a DTB entry for the selected >TEE mediator > [..] > bool __init is_dom0less_mode(void) > { > @

[RFC PATCH v2] arm: dom0less: add TEE support

2024-05-31 Thread Volodymyr Babchuk
Extend TEE mediator interface with two functions : - tee_get_type_from_dts() returns TEE type based on input string - tee_make_dtb_node() creates a DTB entry for the selected TEE mediator Use those new functions to parse "xen,tee" DTS property for dom0less guests and enable appropriate TEE m

[xen-unstable test] 186208: tolerable FAIL - PUSHED

2024-05-31 Thread osstest service owner
flight 186208 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/186208/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 186200 test-amd64-amd64-xl-qemut-win7-amd64

Re: [XEN PATCH v5 7/7] xen/arm: ffa: support notification

2024-05-31 Thread Bertrand Marquis
Hi Jens, > On 29 May 2024, at 09:25, Jens Wiklander wrote: > > Add support for FF-A notifications, currently limited to an SP (Secure > Partition) sending an asynchronous notification to a guest. > > Guests and Xen itself are made aware of pending notifications with an > interrupt. The interrup

[ovmf test] 186210: all pass - PUSHED

2024-05-31 Thread osstest service owner
flight 186210 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/186210/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 7c584bb04874bb5bad16fcf3996f5a893cc81a1c baseline version: ovmf 746cc5cc40bef22d606cd

Re: [XEN PATCH v5 6/7] xen/arm: add and call tee_free_domain_ctx()

2024-05-31 Thread Bertrand Marquis
Hi Jens, > On 29 May 2024, at 09:25, Jens Wiklander wrote: > > Add tee_free_domain_ctx() to the TEE mediator framework. > tee_free_domain_ctx() is called from arch_domain_destroy() to allow late > freeing of the d->arch.tee context. This will simplify access to > d->arch.tee for domains retrieve

Re: [XEN PATCH v5 5/7] xen/arm: add and call init_tee_interrupt()

2024-05-31 Thread Bertrand Marquis
Hi Jens, > On 29 May 2024, at 09:25, Jens Wiklander wrote: > > Add init_tee_interrupt() to the TEE mediator framework and call it from > start_secondary() late enough that per-cpu interrupts can be configured > on CPUs as they are initialized. This is needed in later patches. Just a NIT: The fu

Re: [XEN PATCH v5 4/7] xen/arm: allow dynamically assigned SGI handlers

2024-05-31 Thread Bertrand Marquis
Hi Jens, > On 29 May 2024, at 09:25, Jens Wiklander wrote: > > Updates so request_irq() can be used with a dynamically assigned SGI irq > as input. This prepares for a later patch where an FF-A schedule > receiver interrupt handler is installed for an SGI generated by the > secure world. > > Fr

Re: [PATCH] arm: dom0less: add TEE support

2024-05-31 Thread Julien Grall
Hi Bertrand, On 30/05/2024 14:22, Bertrand Marquis wrote: On 30 May 2024, at 12:35, Julien Grall wrote: Hi Bertrand, On 30/05/2024 10:40, Bertrand Marquis wrote: But we are making assumption that all TEE implementation will have its node inside "/firmware/". I am not 100% sure that this is c

Re: [PATCH 2/2] arch/irq: Centralise no_irq_type

2024-05-31 Thread Julien Grall
Hi Andrew, On 30/05/2024 19:40, Andrew Cooper wrote: Having no_irq_type defined per arch, but using common callbacks is a mess, and particualrly hard to bootstrap a new architecture with. Now that the ack()/end() hooks have been exported suitably, move the definition of no_irq_type into common/

Re: [PATCH 1/2] arch/irq: Make irq_ack_none() mandatory

2024-05-31 Thread Julien Grall
Hi, On 30/05/2024 19:40, Andrew Cooper wrote: Any non-stub implementation of these is going to have to do something here. irq_end_none() is more complicated and has arch-specific interactions with irq_ack_none(), so make it optional. For PPC, introduce a stub irq_ack_none(). For ARM and x86,

Re: convert the SCSI ULDs to the atomic queue limits API v2

2024-05-31 Thread Christoph Hellwig
On Fri, May 31, 2024 at 08:07:54AM -0400, Martin K. Petersen wrote: > If you have other block layer changes depending on this series we'll > probably need a shared branch. I'll need to make several changes to sd.c > to fix reported issues, including a couple in the zeroing/discard > department. Ye

Re: convert the SCSI ULDs to the atomic queue limits API v2

2024-05-31 Thread Martin K. Petersen
Christoph, > The patches are against Jens' block-6.10 tree. Due to the amount of > block layer changes in here, and other that will depend on it, it > would be good if this could eventually be merged through the block > tree, or at least a shared branch between the SCSI and block trees. If you

Re: [PATCH 14/14] block: add special APIs for run-time disabling of discard and friends

2024-05-31 Thread Nitesh Shetty
On 31/05/24 09:48AM, Christoph Hellwig wrote: A few drivers optimistically try to support discard, write zeroes and secure erase and disable the features from the I/O completion handler if the hardware can't support them. This disable can't be done using the atomic queue limits API because the I

Re: [PATCH 1/3] CI: Remove CI_COMMIT_REF_PROTECTED requirement for HW jobs

2024-05-31 Thread Marek Marczykowski-Górecki
On Thu, May 30, 2024 at 05:43:12PM -0700, Stefano Stabellini wrote: > On Thu, 30 May 2024, Marek Marczykowski-Górecki wrote: > > On Wed, May 29, 2024 at 03:19:43PM +0100, Andrew Cooper wrote: > > > This restriction doesn't provide any security because anyone with suitable > > > permissions on the H

Re: [PATCH 11/14] sd: convert to the atomic queue limits API

2024-05-31 Thread John Garry
On 31/05/2024 08:48, Christoph Hellwig wrote: Assign all queue limits through a local queue_limits variable and queue_limits_commit_update so that we can't race updating them from multiple places, and freeze the queue when updating them so that in-progress I/O submissions don't see half-updated l

Re: convert the SCSI ULDs to the atomic queue limits API v2

2024-05-31 Thread John Garry
On 31/05/2024 08:47, Christoph Hellwig wrote: Hi all, Just saying that b4 for some reason does not create a .mbox to apply for this series when using "b4 am". It also no longer does for v1 (when it did previously). I guess that the series versioning confused it. this series converts the S

Re: [PATCH 14/14] block: add special APIs for run-time disabling of discard and friends

2024-05-31 Thread John Garry
On 31/05/2024 08:48, Christoph Hellwig wrote: A few drivers optimistically try to support discard, write zeroes and secure erase and disable the features from the I/O completion handler if the hardware can't support them. This disable can't be done using the atomic queue limits API because the I

Re: [PATCH 13/14] block: remove unused queue limits API

2024-05-31 Thread John Garry
On 31/05/2024 08:48, Christoph Hellwig wrote: Remove all APIs that are unused now that sd and sr have been converted to the atomic queue limits API. Signed-off-by: Christoph Hellwig Reviewed-by: Bart Van Assche Reviewed-by: John Garry

[libvirt test] 186206: tolerable all pass - PUSHED

2024-05-31 Thread osstest service owner
flight 186206 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/186206/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 186190 test-amd64-amd64-libvirt-xsm 15 migrate-s

Re: [PATCH v3 2/6] xen/x86: Add initial x2APIC ID to the per-vLAPIC save area

2024-05-31 Thread Roger Pau Monné
On Thu, May 30, 2024 at 12:08:26PM +0100, Andrew Cooper wrote: > On 29/05/2024 3:32 pm, Alejandro Vallejo wrote: > > diff --git a/xen/lib/x86/policy.c b/xen/lib/x86/policy.c > > index f033d22785be..b70b22d55fcf 100644 > > --- a/xen/lib/x86/policy.c > > +++ b/xen/lib/x86/policy.c > > @@ -2,6 +2,17 @

[ANNOUNCE] Join us for free virtually at Xen Summit 2024 + FAQs!

2024-05-31 Thread Kelly Choi
Hello Xen Community, Join us virtually at Xen Summit (4-6th June), for free using Jitsi! We want to encourage as many of you to participate in the Xen Summit as possible. Just because you are not physically attending, doesn't mean you can't get involved. *(Please note, there will be no profession

Re: [PATCH v2 7/7] hw/xen: Register framebuffer backend via xen_backend_init()

2024-05-31 Thread Paul Durrant
On 10/05/2024 11:49, Philippe Mathieu-Daudé wrote: Align the framebuffer backend with the other legacy ones, register it via xen_backend_init() when '-vga xenfb' is used. It is safe because MODULE_INIT_XEN_BACKEND is called in xen_bus_realize(), long after CLI processing initialized the vga_inter

Re: [PATCH v2 6/7] hw/xen: register legacy backends via xen_backend_init

2024-05-31 Thread Paul Durrant
On 10/05/2024 11:49, Philippe Mathieu-Daudé wrote: From: Paolo Bonzini It is okay to register legacy backends in the middle of xen_bus_init(). All that the registration does is record the existence of the backend in xenstore. This makes it possible to remove them from the build without introdu

Re: [PATCH v2 5/7] hw/xen: initialize legacy backends from xen_bus_init()

2024-05-31 Thread Paul Durrant
On 10/05/2024 11:49, Philippe Mathieu-Daudé wrote: From: Paolo Bonzini Prepare for moving the calls to xen_be_register() under the control of xen_bus_init(), using the normal xen_backend_init() method that is used by the "modern" backends. This requires the xenstore global variable to be initi

Re: [PATCH v2 4/7] hw/xen: Make XenDevOps structures const

2024-05-31 Thread Paul Durrant
On 10/05/2024 11:49, Philippe Mathieu-Daudé wrote: Keep XenDevOps structures in .rodata. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/xen/xen-legacy-backend.h | 8 hw/9pfs/xen-9p-backend.c| 2 +- hw/display/xenfb.c | 4 ++-- hw/usb/xen-usb.c

[ovmf test] 186209: all pass - PUSHED

2024-05-31 Thread osstest service owner
flight 186209 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/186209/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 746cc5cc40bef22d606cd22d1feb10d73a7b3d11 baseline version: ovmf 5f68a363d0d95bd0d3838

Re: [PATCH for-4.19 3/9] xen/cpu: ensure get_cpu_maps() returns false if CPU operations are underway

2024-05-31 Thread Roger Pau Monné
On Fri, May 31, 2024 at 10:33:58AM +0200, Jan Beulich wrote: > On 31.05.2024 09:31, Roger Pau Monné wrote: > > On Fri, May 31, 2024 at 09:02:20AM +0200, Jan Beulich wrote: > >> On 29.05.2024 18:14, Roger Pau Monné wrote: > >>> On Wed, May 29, 2024 at 05:49:48PM +0200, Jan Beulich wrote: > On 2

Re: [PATCH 12/12] block: add special APIs for run-time disabling of discard and friends

2024-05-31 Thread John Garry
On 29/05/2024 06:04, Christoph Hellwig wrote: A few drivers optimistically try to support discard, write zeroes and secure erase and disable the features from the I/O completion handler if the hardware can't support them. This disable can't be done using the atomic queue limits API because the I

Re: [PATCH 11/12] block: remove unused queue limits API

2024-05-31 Thread John Garry
On 29/05/2024 06:04, Christoph Hellwig wrote: Remove all APIs that are unused now that sd and sr have been converted to the atomic queue limits API. Signed-off-by: Christoph Hellwig --- Reviewed-by: John Garry

Re: [PATCH 04/14] block: take io_opt and io_min into account for max_sectors

2024-05-31 Thread Ilya Dryomov
On Fri, May 31, 2024 at 9:48 AM Christoph Hellwig wrote: > > The soft max_sectors limit is normally capped by the hardware limits and > an arbitrary upper limit enforced by the kernel, but can be modified by > the user. A few drivers want to increase this limit (nbd, rbd) or > adjust it up or dow

Re: [PATCH v2 3/7] hw/xen: Constify xenstore_be::XenDevOps

2024-05-31 Thread Paul Durrant
On 10/05/2024 11:49, Philippe Mathieu-Daudé wrote: XenDevOps @ops is not updated, mark it const. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/xen/xen-legacy-backend.h | 2 +- hw/xen/xen-legacy-backend.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) Reviewed

Re: [PATCH v2 2/7] hw/xen: Constify XenLegacyDevice::XenDevOps

2024-05-31 Thread Paul Durrant
On 10/05/2024 11:49, Philippe Mathieu-Daudé wrote: XenDevOps @ops is not updated, mark it const. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/xen/xen_pvdev.h | 2 +- hw/xen/xen-legacy-backend.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Paul Durrant

Re: [PATCH 03/14] rbd: increase io_opt again

2024-05-31 Thread Ilya Dryomov
On Fri, May 31, 2024 at 9:48 AM Christoph Hellwig wrote: > > Commit 16d80c54ad42 ("rbd: set io_min, io_opt and discard_granularity to > alloc_size") lowered the io_opt size for rbd from objset_bytes which is > 4MB for typical setup to alloc_size which is typically 64KB. > > The commit mostly talks

Re: [PATCH v2 1/7] hw/xen: Remove declarations left over in 'xen-legacy-backend.h'

2024-05-31 Thread Paul Durrant
On 10/05/2024 11:49, Philippe Mathieu-Daudé wrote: 'xen_blkdev_ops' was removed in commit 19f87870ba ("xen: remove the legacy 'xen_disk' backend"), 'xen_netdev_ops' in commit 25967ff69f ("hw/xen: update Xen PV NIC to XenDevice model") and 'xen_console_ops' in commit 9b77374690 ("hw/xen: update Xe

Re: [PATCH v2 06/13] xen/bitops: Implement ffs() in common logic

2024-05-31 Thread Andrew Cooper
On 31/05/2024 9:34 am, Andrew Cooper wrote: > On 31/05/2024 7:56 am, Nicola Vetrini wrote: >> On 2024-05-31 03:14, Stefano Stabellini wrote: >>> On Fri, 24 May 2024, Andrew Cooper wrote: Perform constant-folding unconditionally, rather than having it implemented inconsistency between

[linux-linus test] 186202: tolerable FAIL - PUSHED

2024-05-31 Thread osstest service owner
flight 186202 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/186202/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-raw 8 xen-boot fail like 186174 test-armhf-armhf-libvirt 16 saver

Re: [PATCH v2 06/13] xen/bitops: Implement ffs() in common logic

2024-05-31 Thread Andrew Cooper
On 31/05/2024 7:56 am, Nicola Vetrini wrote: > On 2024-05-31 03:14, Stefano Stabellini wrote: >> On Fri, 24 May 2024, Andrew Cooper wrote: >>> Perform constant-folding unconditionally, rather than having it >>> implemented >>> inconsistency between architectures. >>> >>> Confirm the expected behavi

Re: [PATCH for-4.19 3/9] xen/cpu: ensure get_cpu_maps() returns false if CPU operations are underway

2024-05-31 Thread Jan Beulich
On 31.05.2024 09:31, Roger Pau Monné wrote: > On Fri, May 31, 2024 at 09:02:20AM +0200, Jan Beulich wrote: >> On 29.05.2024 18:14, Roger Pau Monné wrote: >>> On Wed, May 29, 2024 at 05:49:48PM +0200, Jan Beulich wrote: On 29.05.2024 17:03, Roger Pau Monné wrote: > On Wed, May 29, 2024 at 0

Re: [XEN PATCH v2 13/15] x86/ioreq: guard VIO_realmode_completion with CONFIG_VMX

2024-05-31 Thread Jan Beulich
On 31.05.2024 10:05, Sergiy Kibrik wrote: > 16.05.24 15:11, Jan Beulich: >> On 15.05.2024 11:24, Sergiy Kibrik wrote: >>> --- a/xen/arch/x86/hvm/emulate.c >>> +++ b/xen/arch/x86/hvm/emulate.c >>> @@ -2667,7 +2667,9 @@ static int _hvm_emulate_one(struct hvm_emulate_ctxt >>> *hvmemul_ctxt, >>>

Re: [PATCH 1/2] arch/irq: Make irq_ack_none() mandatory

2024-05-31 Thread Andrew Cooper
On 31/05/2024 7:42 am, Jan Beulich wrote: > On 30.05.2024 20:40, Andrew Cooper wrote: >> Any non-stub implementation of these is going to have to do something here. > For whatever definition of "something", seeing ... > >> --- a/xen/arch/arm/irq.c >> +++ b/xen/arch/arm/irq.c >> @@ -31,12 +31,12 @@

[XEN PATCH RFC] ioreq: make arch_vcpu_ioreq_completion() an optional callback

2024-05-31 Thread Sergiy Kibrik
For the most cases arch_vcpu_ioreq_completion() routine is just an empty stub, except when handling VIO_realmode_completion, which only happens on HVM domains running on VT-x machine. When VT-x is disabled in build configuration, both x86 & arm version of routine become empty stubs. To dispose of t

Re: [XEN PATCH v2 13/15] x86/ioreq: guard VIO_realmode_completion with CONFIG_VMX

2024-05-31 Thread Sergiy Kibrik
16.05.24 15:11, Jan Beulich: On 15.05.2024 11:24, Sergiy Kibrik wrote: --- a/xen/arch/x86/hvm/emulate.c +++ b/xen/arch/x86/hvm/emulate.c @@ -2667,7 +2667,9 @@ static int _hvm_emulate_one(struct hvm_emulate_ctxt *hvmemul_ctxt, break; case VIO_mmio_completion: +#ifdef CONFIG_V

[PATCH 12/14] sr: convert to the atomic queue limits API

2024-05-31 Thread Christoph Hellwig
Assign all queue limits through a local queue_limits variable and queue_limits_commit_update so that we can't race updating them from multiple places, and free the queue when updating them so that in-progress I/O submissions don't see half-updated limits. Also use the chance to clean up variable n

[PATCH 13/14] block: remove unused queue limits API

2024-05-31 Thread Christoph Hellwig
Remove all APIs that are unused now that sd and sr have been converted to the atomic queue limits API. Signed-off-by: Christoph Hellwig Reviewed-by: Bart Van Assche --- block/blk-settings.c | 190 - include/linux/blkdev.h | 24 -- 2 files changed,

[PATCH 11/14] sd: convert to the atomic queue limits API

2024-05-31 Thread Christoph Hellwig
Assign all queue limits through a local queue_limits variable and queue_limits_commit_update so that we can't race updating them from multiple places, and freeze the queue when updating them so that in-progress I/O submissions don't see half-updated limits. Signed-off-by: Christoph Hellwig Review

[PATCH 14/14] block: add special APIs for run-time disabling of discard and friends

2024-05-31 Thread Christoph Hellwig
A few drivers optimistically try to support discard, write zeroes and secure erase and disable the features from the I/O completion handler if the hardware can't support them. This disable can't be done using the atomic queue limits API because the I/O completion handlers can't take sleeping locks

[PATCH 09/14] sd: factor out a sd_discard_mode helper

2024-05-31 Thread Christoph Hellwig
Split the logic to pick the right discard mode into a little helper to prepare for further changes. Signed-off-by: Christoph Hellwig Reviewed-by: Bart Van Assche Reviewed-by: Damien Le Moal --- drivers/scsi/sd.c | 37 - 1 file changed, 20 insertions(+), 17 d

[PATCH 07/14] sd: add a sd_disable_write_same helper

2024-05-31 Thread Christoph Hellwig
Add helper to disable WRITE SAME when it is not supported and use it instead of sd_config_write_same in the I/O completion handler. This avoids touching more fields than required in the I/O completion handler and prepares for converting sd to use the atomic queue limits API. Signed-off-by: Chris

[PATCH 01/14] ubd: refactor the interrupt handler

2024-05-31 Thread Christoph Hellwig
Instead of a separate handler function that leaves no work in the interrupt hanler itself, split out a per-request end I/O helper and clean up the coding style and variable naming while we're at it. Signed-off-by: Christoph Hellwig --- arch/um/drivers/ubd_kern.c | 49 ++--

[PATCH 03/14] rbd: increase io_opt again

2024-05-31 Thread Christoph Hellwig
Commit 16d80c54ad42 ("rbd: set io_min, io_opt and discard_granularity to alloc_size") lowered the io_opt size for rbd from objset_bytes which is 4MB for typical setup to alloc_size which is typically 64KB. The commit mostly talks about discard behavior and does mention io_min in passing. Reducing

[PATCH 08/14] sd: simplify the disable case in sd_config_discard

2024-05-31 Thread Christoph Hellwig
Fall through to the main call to blk_queue_max_discard_sectors given that max_blocks has been initialized to zero above instead of duplicating the call. Signed-off-by: Christoph Hellwig Reviewed-by: Bart Van Assche Reviewed-by: Damien Le Moal --- drivers/scsi/sd.c | 3 +-- 1 file changed, 1 in

[PATCH 10/14] sd: cleanup zoned queue limits initialization

2024-05-31 Thread Christoph Hellwig
Consolidate setting zone-related queue limits in sd_zbc_read_zones instead of splitting them between sd_zbc_revalidate_zones and sd_zbc_read_zones, and move the early_zone_information initialization in sd_zbc_read_zones above setting up the queue limits. Signed-off-by: Christoph Hellwig Reviewed-

[PATCH 05/14] sd: simplify the ZBC case in provisioning_mode_store

2024-05-31 Thread Christoph Hellwig
Don't reset the discard settings to no-op over and over when a user writes to the provisioning attribute as that is already the default mode for ZBC devices. In hindsight we should have made writing to the attribute fail for ZBC devices, but the code has probably been around for far too long to ch

[PATCH 06/14] sd: add a sd_disable_discard helper

2024-05-31 Thread Christoph Hellwig
Add helper to disable discard when it is not supported and use it instead of sd_config_discard in the I/O completion handler. This avoids touching more fields than required in the I/O completion handler and prepares for converting sd to use the atomic queue limits API. Signed-off-by: Christoph He

[PATCH 04/14] block: take io_opt and io_min into account for max_sectors

2024-05-31 Thread Christoph Hellwig
The soft max_sectors limit is normally capped by the hardware limits and an arbitrary upper limit enforced by the kernel, but can be modified by the user. A few drivers want to increase this limit (nbd, rbd) or adjust it up or down based on hardware capabilities (sd). Change blk_validate_limits t

[PATCH 02/14] ubd: untagle discard vs write zeroes not support handling

2024-05-31 Thread Christoph Hellwig
Discard and Write Zeroes are different operation and implemented by different fallocate opcodes for ubd. If one fails the other one can work and vice versa. Split the code to disable the operations in ubd_handler to only disable the operation that actually failed. Fixes: 50109b5a03b4 ("um: Add s

convert the SCSI ULDs to the atomic queue limits API v2

2024-05-31 Thread Christoph Hellwig
Hi all, this series converts the SCSI upper level drivers to the atomic queue limits API. The first patch is a bug fix for ubd that later patches depend on and might be worth picking up for 6.10. The second patch changes the max_sectors calculation to take the optimal I/O size into account so th

Re: [PATCH for-4.19 4/9] x86/irq: describe how the interrupt CPU movement works

2024-05-31 Thread Roger Pau Monné
On Fri, May 31, 2024 at 09:06:10AM +0200, Jan Beulich wrote: > On 29.05.2024 17:28, Roger Pau Monné wrote: > > On Wed, May 29, 2024 at 03:57:19PM +0200, Jan Beulich wrote: > >> On 29.05.2024 11:01, Roger Pau Monne wrote: > >>> --- a/xen/arch/x86/include/asm/irq.h > >>> +++ b/xen/arch/x86/include/as

Re: [PATCH for-4.19 3/9] xen/cpu: ensure get_cpu_maps() returns false if CPU operations are underway

2024-05-31 Thread Roger Pau Monné
On Fri, May 31, 2024 at 09:02:20AM +0200, Jan Beulich wrote: > On 29.05.2024 18:14, Roger Pau Monné wrote: > > On Wed, May 29, 2024 at 05:49:48PM +0200, Jan Beulich wrote: > >> On 29.05.2024 17:03, Roger Pau Monné wrote: > >>> On Wed, May 29, 2024 at 03:35:04PM +0200, Jan Beulich wrote: > On 2

Re: [PATCH for-4.19 0/3] CI: Misc improvements

2024-05-31 Thread Oleksii K.
On Wed, 2024-05-29 at 15:19 +0100, Andrew Cooper wrote: > All found while making extensive use of Gitlab CI for the bitops boot > testing. > > For 4.19.  It's all very low risk, and improves the > utility/useability of our > testing. Release-Acked-by: Oleksii Kurochko ~ Oleksii > > Andrew Coope

Re: [PATCH for-4.19 4/9] x86/irq: describe how the interrupt CPU movement works

2024-05-31 Thread Jan Beulich
On 29.05.2024 17:28, Roger Pau Monné wrote: > On Wed, May 29, 2024 at 03:57:19PM +0200, Jan Beulich wrote: >> On 29.05.2024 11:01, Roger Pau Monne wrote: >>> --- a/xen/arch/x86/include/asm/irq.h >>> +++ b/xen/arch/x86/include/asm/irq.h >>> @@ -28,6 +28,32 @@ typedef struct { >>> >>> struct irq_d

Re: [PATCH for-4.19 3/9] xen/cpu: ensure get_cpu_maps() returns false if CPU operations are underway

2024-05-31 Thread Jan Beulich
On 29.05.2024 18:14, Roger Pau Monné wrote: > On Wed, May 29, 2024 at 05:49:48PM +0200, Jan Beulich wrote: >> On 29.05.2024 17:03, Roger Pau Monné wrote: >>> On Wed, May 29, 2024 at 03:35:04PM +0200, Jan Beulich wrote: On 29.05.2024 11:01, Roger Pau Monne wrote: > Due to the current rwlock