[xen-unstable test] 184518: tolerable FAIL - PUSHED

2024-01-29 Thread osstest service owner
flight 184518 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/184518/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 184509 test-amd64-amd64-xl-qemut-win7-amd64

[linux-linus test] 184517: tolerable FAIL - PUSHED

2024-01-29 Thread osstest service owner
flight 184517 linux-linus real [real] flight 184524 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/184517/ http://logs.test-lab.xenproject.org/osstest/logs/184524/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-

[ovmf test] 184522: all pass - PUSHED

2024-01-29 Thread osstest service owner
flight 184522 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184522/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 98c7cb3be73d0f15151133abe91bc880a4400794 baseline version: ovmf dc3339470166884197e9b

[linux-5.4 test] 184511: regressions - FAIL

2024-01-29 Thread osstest service owner
flight 184511 linux-5.4 real [real] flight 184521 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/184511/ http://logs.test-lab.xenproject.org/osstest/logs/184521/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: t

Re: Linux 6.7-rc1+: WARNING at drivers/xen/evtchn.c:167 evtchn_interrupt

2024-01-29 Thread Marek Marczykowski-Górecki
On Sat, Dec 02, 2023 at 10:46:38PM +0100, Marek Marczykowski-Górecki wrote: > On Fri, Dec 01, 2023 at 09:29:30AM +0100, Juergen Gross wrote: > > Hi Marek, > > > > On 30.11.23 03:34, Marek Marczykowski-Górecki wrote: > > > Hi, > > > > > > While testing 6.7-rc3 on Qubes OS I found several warning l

Re: [RFC KERNEL PATCH v4 3/3] PCI/sysfs: Add gsi sysfs for pci_dev

2024-01-29 Thread Bjorn Helgaas
On Thu, Jan 25, 2024 at 07:17:24AM +, Chen, Jiqian wrote: > On 2024/1/24 00:02, Bjorn Helgaas wrote: > > On Tue, Jan 23, 2024 at 10:13:52AM +, Chen, Jiqian wrote: > >> On 2024/1/23 07:37, Bjorn Helgaas wrote: > >>> On Fri, Jan 05, 2024 at 02:22:17PM +0800, Jiqian Chen wrote: > There is

[ovmf test] 184519: all pass - PUSHED

2024-01-29 Thread osstest service owner
flight 184519 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184519/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf dc3339470166884197e9be5a6b3e7afe13104f1f baseline version: ovmf 4c43209a740d4b38094f9

[xen-unstable-smoke test] 184520: tolerable all pass - PUSHED

2024-01-29 Thread osstest service owner
flight 184520 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/184520/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v3 01/29] bulk: Access existing variables initialized to &S->F when available

2024-01-29 Thread BALATON Zoltan
On Mon, 29 Jan 2024, Philippe Mathieu-Daudé wrote: When a variable is initialized to &struct->field, use it in place. Rationale: while this makes the code more concise, this also helps static analyzers. Mechanical change using the following Coccinelle spatch script: @@ type S, F; identifier s,

Re: [PATCH v3 01/29] bulk: Access existing variables initialized to &S->F when available

2024-01-29 Thread Fabiano Rosas
Philippe Mathieu-Daudé writes: > When a variable is initialized to &struct->field, use it > in place. Rationale: while this makes the code more concise, > this also helps static analyzers. > > Mechanical change using the following Coccinelle spatch script: > > @@ > type S, F; > identifier s, m

[PATCH v6 13/15] xen/arm: make consider_modules() available for xen relocation

2024-01-29 Thread Carlo Nonato
Cache coloring must physically relocate Xen in order to color the hypervisor and consider_modules() is a key function that is needed to find a new available physical address. 672d67f339c0 ("xen/arm: Split MMU-specific setup_mm() and related code out") moved consider_modules() under arm32. Move it

[PATCH v6 00/15] Arm cache coloring

2024-01-29 Thread Carlo Nonato
Shared caches in multi-core CPU architectures represent a problem for predictability of memory access latency. This jeopardizes applicability of many Arm platform in real-time critical and mixed-criticality scenarios. We introduce support for cache partitioning with page coloring, a transparent sof

[PATCH v6 09/15] xen/page_alloc: introduce preserved page flags macro

2024-01-29 Thread Carlo Nonato
PGC_static and PGC_extra are flags that needs to be preserved when assigning a page. Define a new macro that groups those flags and use it instead of or'ing every time. Signed-off-by: Carlo Nonato --- v6: - preserved_flags renamed to PGC_preserved - PGC_preserved is used only in assign_pages() v5

[PATCH v6 05/15] xen: extend domctl interface for cache coloring

2024-01-29 Thread Carlo Nonato
Update the domctl interface to allow the user to set coloring configurations from the toolstack. Implement also the functionality for arm64. Based on original work from: Luca Miccio Signed-off-by: Carlo Nonato Signed-off-by: Marco Solieri --- v6: - reverted the XEN_DOMCTL_INTERFACE_VERSION bu

[PATCH v6 15/15] support: add cache coloring arm64 experimental feature

2024-01-29 Thread Carlo Nonato
Signed-off-by: Carlo Nonato --- v6: - new patch --- SUPPORT.md | 7 +++ 1 file changed, 7 insertions(+) diff --git a/SUPPORT.md b/SUPPORT.md index a90d1108c9..f94569c862 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -363,6 +363,13 @@ by maintaining multiple physical to machine (p2m) memory ma

[PATCH v6 07/15] xen/arm: add support for cache coloring configuration via device-tree

2024-01-29 Thread Carlo Nonato
Add the "llc-colors" Device Tree attribute to express DomUs and Dom0less color configurations. Based on original work from: Luca Miccio Signed-off-by: Carlo Nonato Signed-off-by: Marco Solieri --- v6: - rewrote domain_set_llc_colors_from_str() to be more explicit v5: - static-mem check has bee

[PATCH v6 03/15] xen/arm: permit non direct-mapped Dom0 construction

2024-01-29 Thread Carlo Nonato
Cache coloring requires Dom0 not to be direct-mapped because of its non contiguous mapping nature, so allocate_memory() is needed in this case. 8d2c3ab18cc1 ("arm/dom0less: put dom0less feature code in a separate module") moved allocate_memory() in dom0less_build.c. In order to use it in Dom0 const

[PATCH v6 11/15] xen/arm: use domain memory to allocate p2m page tables

2024-01-29 Thread Carlo Nonato
Cache colored domains can benefit from having p2m page tables allocated with the same coloring schema so that isolation can be achieved also for those kind of memory accesses. In order to do that, the domain struct is passed to the allocator and the MEMF_no_owner flag is used. This will be useful

[PATCH v6 14/15] xen/arm: add cache coloring support for Xen

2024-01-29 Thread Carlo Nonato
Add the cache coloring support for Xen physical space. Since Xen must be relocated to a new physical space, some relocation functionalities must be brought back: - the virtual address of the new space is taken from 0c18fb76323b ("xen/arm: Remove unused BOOT_RELOC_VIRT_START"). - relocate_xen() a

[PATCH v6 10/15] xen: add cache coloring allocator for domains

2024-01-29 Thread Carlo Nonato
Add a new memory page allocator that implements the cache coloring mechanism. The allocation algorithm enforces equal frequency distribution of cache partitions, following the coloring configuration of a domain. This allows for an even utilization of cache sets for every domain. Pages are stored i

[PATCH v6 12/15] xen/arm: add Xen cache colors command line parameter

2024-01-29 Thread Carlo Nonato
From: Luca Miccio Add a new command line parameter to configure Xen cache colors. These colors can be dumped with the cache coloring info debug-key. By default, Xen uses the first color. Benchmarking the VM interrupt response time provides an estimation of LLC usage by Xen's most latency-critica

[PATCH v6 08/15] xen/page_alloc: introduce init_free_page_fields() helper

2024-01-29 Thread Carlo Nonato
Introduce a new helper to initialize fields that have different uses for free pages. Signed-off-by: Carlo Nonato --- v6: - Carlo Nonato as the only signed-off-by v5: - new patch --- xen/common/page_alloc.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/xen/c

[PATCH v6 06/15] tools: add support for cache coloring configuration

2024-01-29 Thread Carlo Nonato
Add a new "llc_colors" parameter that defines the LLC color assignment for a domain. The user can specify one or more color ranges using the same syntax used everywhere else for color config described in the documentation. The parameter is defined as a list of strings that represent the color range

[PATCH v6 01/15] xen/common: add cache coloring common code

2024-01-29 Thread Carlo Nonato
Last Level Cache (LLC) coloring allows to partition the cache in smaller chunks called cache colors. Since not all architectures can actually implement it, add a HAS_LLC_COLORING Kconfig and put other options under xen/arch. LLC colors are a property of the domain, so the domain struct has to be e

[PATCH v6 02/15] xen/arm: add initial support for LLC coloring on arm64

2024-01-29 Thread Carlo Nonato
LLC coloring needs to know the last level cache layout in order to make the best use of it. This can be probed by inspecting the CLIDR_EL1 register, so the Last Level is defined as the last level visible by this register. Note that this excludes system caches in some platforms. Static memory alloc

[PATCH v6 04/15] xen/arm: add Dom0 cache coloring support

2024-01-29 Thread Carlo Nonato
Add a command line parameter to allow the user to set the coloring configuration for Dom0. A common configuration syntax for cache colors is introduced and documented. Take the opportunity to also add: - default configuration notion. - function to check well-formed configurations. Direct mapping

Re: Xen 4.19 release schedule proposal

2024-01-29 Thread Kelly Choi
Hi all, I propose we raise this in the next community call (Thursday 1st Feb). We can decide on the official cadence then and any further feedback. Many thanks, Kelly Choi Community Manager Xen Project On Mon, Jan 8, 2024 at 2:58 PM Jan Beulich wrote: > On 08.01.2024 15:37, Oleksii wrote: >

Re: [PATCH v3 14/29] target/i386: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-29 Thread Philippe Mathieu-Daudé
On 29/1/24 17:44, Philippe Mathieu-Daudé wrote: Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/hvf/vmx.h| 13 ++--- hw/i386/fw_cfg.c |

[PATCH v3 14/29] target/i386: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-29 Thread Philippe Mathieu-Daudé
Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/hvf/vmx.h| 13 ++--- hw/i386/fw_cfg.c | 3 +- hw/i386/vmmouse.c| 6 ++-

[PATCH v3 01/29] bulk: Access existing variables initialized to &S->F when available

2024-01-29 Thread Philippe Mathieu-Daudé
When a variable is initialized to &struct->field, use it in place. Rationale: while this makes the code more concise, this also helps static analyzers. Mechanical change using the following Coccinelle spatch script: @@ type S, F; identifier s, m, v; @@ S *s; ... F *v = &s->m

Re: [PATCH v5 3/3] x86/iommu: cleanup unused functions

2024-01-29 Thread Paul Durrant
On 24/01/2024 17:29, Roger Pau Monne wrote: Remove xen_in_range() and vpci_is_mmcfg_address() now that hey are unused. Adjust comments to point to the new functions that replace the existing ones. No functional change. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich --- Changes since

Re: [PATCH v5 2/3] x86/iommu: switch hwdom IOMMU to use a rangeset

2024-01-29 Thread Paul Durrant
On 24/01/2024 17:29, Roger Pau Monne wrote: The current loop that iterates from 0 to the maximum RAM address in order to setup the IOMMU mappings is highly inefficient, and it will get worse as the amount of RAM increases. It's also not accounting for any reserved regions past the last RAM addre

Re: [PATCH v6 1/3] x86/iommu: remove regions not to be mapped

2024-01-29 Thread Paul Durrant
On 25/01/2024 13:26, Roger Pau Monne wrote: Introduce the code to remove regions not to be mapped from the rangeset that will be used to setup the IOMMU page tables for the hardware domain. This change also introduces two new functions: remove_xen_ranges() and vpci_subtract_mmcfg() that copy the

Re: Community Process Group - Proposal

2024-01-29 Thread Kelly Choi
Thank you everyone for your feedback so far. I will be sending out a formal vote to committers this week on this proposal. Once I receive the results I will announce to xen-devel the next steps or if any further changes are needed. Many thanks, Kelly Choi Community Manager Xen Project On Wed,

[PATCH v3 4/6] hw/xen/xen-mapcache.c: convert DPRINTF to tracepoints

2024-01-29 Thread Manos Pitsidianakis
Tracing DPRINTFs to stderr might not be desired. A developer that relies on tracepoints should be able to opt-in to each tracepoint and rely on QEMU's log redirection, instead of stderr by default. This commit converts DPRINTFs in this file that are used for tracing into tracepoints. Signed-off-b

[PATCH v3 5/6] hw/xen/xen-hvm-common.c: convert DPRINTF to tracepoints

2024-01-29 Thread Manos Pitsidianakis
Tracing DPRINTFs to stderr might not be desired. A developer that relies on tracepoints should be able to opt-in to each tracepoint and rely on QEMU's log redirection, instead of stderr by default. This commit converts DPRINTFs in this file that are used for tracing into tracepoints. Signed-off-b

[PATCH v3 6/6] hw/xen: convert stderr prints to error/warn reports

2024-01-29 Thread Manos Pitsidianakis
According to the QEMU Coding Style document: > Do not use printf(), fprintf() or monitor_printf(). Instead, use > error_report() or error_vreport() from error-report.h. This ensures the > error is reported in the right place (current monitor or stderr), and in > a uniform format. > Use error_print

[xen-unstable test] 184509: tolerable FAIL

2024-01-29 Thread osstest service owner
flight 184509 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/184509/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 184492 test-armhf-armhf-libvirt 1

Final reminder: Xen Project Annual Survey

2024-01-29 Thread Kelly Choi
Hi all, Final reminder to have your chance to say how the community is performing! What are we doing well and what can we improve on? Tell us here anonymously: https://cryptpad.fr/form/#/2/form/view/uG22fJfe8UILyP9+jJ-YesXsINKMZRpuWh2c58bhBYI/ *Survey closes on 31st January 2024* Many thanks,

[PATCH net] xen-netback: properly sync TX responses

2024-01-29 Thread Jan Beulich
Invoking the make_tx_response() / push_tx_responses() pair with no lock held would be acceptable only if all such invocations happened from the same context (NAPI instance or dealloc thread). Since this isn't the case, and since the interface "spec" also doesn't demand that multicast operations may

[linux-linus test] 184508: tolerable FAIL - PUSHED

2024-01-29 Thread osstest service owner
flight 184508 linux-linus real [real] flight 184514 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/184508/ http://logs.test-lab.xenproject.org/osstest/logs/184514/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-

[xen-unstable-smoke test] 184512: tolerable all pass - PUSHED

2024-01-29 Thread osstest service owner
flight 184512 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/184512/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH] xen/lib: introduce generic find next bit operations

2024-01-29 Thread Oleksii
Hi Julien, > > > > > > > > On 26/01/2024 12:20, Oleksii Kurochko wrote: > > > > find-next-bit.c is common for Arm64, PPC and RISCV64, > > > > so it is moved to xen/lib. > > > > > > > > Suggested-by: Jan Beulich > > > > Signed-off-by: Oleksii Kurochko > > > > --- > > > >    docs/misra/exclude-

Re: [PATCH v2 (resend) 00/27] Remove the directmap

2024-01-29 Thread Jan Beulich
On 16.01.2024 20:25, Elias El Yandouzi wrote: > Elias El Yandouzi (3): > xen/x86: Add build assertion for fixmap entries > Rename mfn_to_virt() calls > Rename maddr_to_virt() calls > > Hongyan Xia (13): > acpi: vmap pages in acpi_os_alloc_memory > xen/numa: vmap the pages for memnodemap