[ovmf test] 183991: all pass - PUSHED

2023-12-04 Thread osstest service owner
flight 183991 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/183991/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 120aa6064465496c962b6664a9365a2573e54d1f baseline version: ovmf 3e133f730b69a2b5a5cb8

Re: [PATCH v11 06/17] vpci/header: rework exit path in init_bars

2023-12-04 Thread Jan Beulich
On 05.12.2023 01:53, Volodymyr Babchuk wrote: > Jan Beulich writes: >> On 02.12.2023 02:27, Volodymyr Babchuk wrote: >>> Introduce "fail" label in init_bars() function to have the centralized >>> error return path. This is the pre-requirement for the future changes >>> in this function. >>> >>> Th

Re: [PATCH] CODING_STYLE: Add a section of the naming convention

2023-12-04 Thread Jan Beulich
On 04.12.2023 20:05, Julien Grall wrote: > On 04/12/2023 09:39, Jan Beulich wrote: >> On 01.12.2023 19:49, Julien Grall wrote: >>> +Naming convention >>> +- >>> + >>> +'-' should be used to separate words in commandline options and filenames. >>> +E.g. timer-works. >>> + >>> +Note t

Re: [PATCH] sched: correct sched_move_domain()'s cleanup path

2023-12-04 Thread Juergen Gross
On 04.12.23 20:33, George Dunlap wrote: On Mon, Dec 4, 2023 at 2:44 PM Juergen Gross wrote: Personally I prefer to keep the "goto out", rather than duplicating the rcu_read_unlock(). I'd yield if Jan said he preferred duplication, however. I'm on the edge there actually. In this case I'd p

Re: [RFC KERNEL PATCH v2 2/3] xen/pvh: Unmask irq for passthrough device in PVH dom0

2023-12-04 Thread Chen, Jiqian
Hi Thomas Gleixner, Thank you for review, and you are right, it seems more like a XEN internal issue. We are discussing it and maybe will fix it in Xen code next version. On 2023/12/4 16:13, Thomas Gleixner wrote: > On Fri, Nov 24 2023 at 18:31, Jiqian Chen wrote: >> diff --git a/drivers/xen/xen

Re: [RFC KERNEL PATCH v2 1/3] xen/pci: Add xen_reset_device_state function

2023-12-04 Thread Chen, Jiqian
On 2023/12/5 05:31, Stefano Stabellini wrote: > On Mon, 3 Dec 2023, Chen, Jiqian wrote: vpci device state when device is reset on dom0 side. And call that function in pcistub_init_device. Because when we use "pci-assignable-add" to assign a passthrough device in Xen, it wil

Re: [RFC KERNEL PATCH v2 2/3] xen/pvh: Unmask irq for passthrough device in PVH dom0

2023-12-04 Thread Chen, Jiqian
On 2023/12/4 18:28, Roger Pau Monné wrote: > On Fri, Dec 01, 2023 at 07:37:55PM -0800, Stefano Stabellini wrote: >> On Fri, 1 Dec 2023, Roger Pau Monné wrote: >>> On Thu, Nov 30, 2023 at 07:15:17PM -0800, Stefano Stabellini wrote: On Thu, 30 Nov 2023, Roger Pau Monné wrote: > On Wed, Nov 2

Re: [PATCH v2 05/29] tools/xenlogd: add 9pfs response generation support

2023-12-04 Thread Juergen Gross
On 01.12.23 20:30, Jason Andryuk wrote: On Fri, Nov 10, 2023 at 1:41 PM Juergen Gross wrote: +static void fill_buffer(struct ring *ring, uint8_t cmd, uint16_t tag, +const char *fmt, ...) +{ +struct p9_header *hdr = ring->buffer; +void *data = hdr + 1; +const

Re: Trying add smt=off disabled cores to cpupool crash xen

2023-12-04 Thread Juergen Gross
On 04.12.23 18:40, René Winther Højgaard wrote: Hi Juergen, Sorry for the late reply. Here are the commands I execute, it is 'xl cpupool-cpu-add pcores 4-15' that crash the system. xl cpupool-cpu-remove Pool-0 4-31 xl cpupool-create name=\"ecores\" sched=\"credit\" xl cpupool-cpu-add ecores 1

Re: [RFC XEN PATCH v2 1/3] xen/vpci: Clear all vpci status of device

2023-12-04 Thread Chen, Jiqian
On 2023/12/4 19:10, Roger Pau Monné wrote: > On Mon, Dec 04, 2023 at 06:57:03AM +, Chen, Jiqian wrote: >> Hi Daniel P. Smith, >> >> On 2023/11/30 22:52, Roger Pau Monné wrote: >>> On Thu, Nov 30, 2023 at 07:39:38AM -0500, Daniel P. Smith wrote: On 11/30/23 07:25, Daniel P. Smith wrote: >>>

[PATCH] xen/domain: fix error path in domain_create()

2023-12-04 Thread Stewart Hildebrand
If rangeset_new() fails, err would not be set to an appropriate error code. Set it to -ENOMEM. Fixes: 580c458699e3 ("xen/domain: Call arch_domain_create() as early as possible in domain_create()") Signed-off-by: Stewart Hildebrand --- xen/common/domain.c | 1 + 1 file changed, 1 insertion(+) d

[PATCH v11.2 16/17] xen/arm: vpci: permit access to guest vpci space

2023-12-04 Thread Stewart Hildebrand
Move iomem_caps initialization earlier (before arch_domain_create()). Signed-off-by: Stewart Hildebrand Signed-off-by: Volodymyr Babchuk --- Changes in v11: * move both iomem_caps and irq_caps initializations earlier, along with NULL check Changes in v10: * fix off-by-one * also permit access

Re: [PATCH v11.1 16/17] xen/arm: vpci: permit access to guest vpci space

2023-12-04 Thread Stewart Hildebrand
On 12/4/23 11:18, Stewart Hildebrand wrote: > Move iomem_caps initialization earlier (before arch_domain_create()). > > Signed-off-by: Stewart Hildebrand > Signed-off-by: Volodymyr Babchuk So sorry, I cherry-picked the wrong one, this one didn't apply. Let me try again.

Re: [PATCH v11 12/17] vpci/header: emulate PCI_COMMAND register for guests

2023-12-04 Thread Stewart Hildebrand
On 12/1/23 20:27, Volodymyr Babchuk wrote: > diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c > index 21b3fb5579..bc2ebe125b 100644 > --- a/xen/drivers/vpci/header.c > +++ b/xen/drivers/vpci/header.c > @@ -167,6 +167,9 @@ static void modify_decoding(const struct pci_dev *pdev, >

Re: Informal voting proposal

2023-12-04 Thread Kelly Choi
Hi Rich, I am away on business travel, so did not see your reply before sending my last email. The problem we have noted is that there are frequent disagreements within the project, mainly due to a difference in opinion among other factors. As a bid to help us move quicker and progress within the

Re: [PATCH v11 06/17] vpci/header: rework exit path in init_bars

2023-12-04 Thread Volodymyr Babchuk
Hello Jan, Jan Beulich writes: > On 02.12.2023 02:27, Volodymyr Babchuk wrote: >> Introduce "fail" label in init_bars() function to have the centralized >> error return path. This is the pre-requirement for the future changes >> in this function. >> >> This patch does not introduce functional c

Re: [PATCH v11 09/17] rangeset: add rangeset_empty() function

2023-12-04 Thread Volodymyr Babchuk
Hi Jan, Jan Beulich writes: > On 02.12.2023 02:27, Volodymyr Babchuk wrote: >> This function can be used when user wants to remove all rangeset >> entries but do not want to destroy rangeset itself. > > I have to admit that I'm not happy with the name: We're not consistently > naming all predi

Re: INFORMAL VOTE REQUIRED - DOCUMENTATION WORDING

2023-12-04 Thread Stefano Stabellini
On Mon, 4 Dec 2023, George Dunlap wrote: > And how do we give people practical options to respond to a maintainer > who they think is being "picky" If a maintainer is too picky the contributor and the other maintainers should say that the patch is good enough in their view. If the maintainers disa

Re: [XEN PATCH 7/7] xen/page_alloc: deviate first_valid_mfn for MISRA C Rule 8.4

2023-12-04 Thread Stefano Stabellini
On Sat, 2 Dec 2023, Julien Grall wrote: > Hi, > > On 02/12/2023 04:03, Stefano Stabellini wrote: > > On Fri, 1 Dec 2023, Jan Beulich wrote: > > > On 01.12.2023 03:47, Stefano Stabellini wrote: > > > > On Wed, 29 Nov 2023, Nicola Vetrini wrote: > > > > > No functional change. > > > > > > > > > > S

Re: [XEN PATCH 7/7] xen/page_alloc: deviate first_valid_mfn for MISRA C Rule 8.4

2023-12-04 Thread Stefano Stabellini
On Mon, 4 Dec 2023, Nicola Vetrini wrote: > On 2023-12-04 08:44, Jan Beulich wrote: > > On 02.12.2023 04:03, Stefano Stabellini wrote: > > > On Fri, 1 Dec 2023, Jan Beulich wrote: > > > > On 01.12.2023 03:47, Stefano Stabellini wrote: > > > > > On Wed, 29 Nov 2023, Nicola Vetrini wrote: > > > > > >

Re: [XEN PATCH] docs/misra: deviate deliberately unused labels

2023-12-04 Thread Stefano Stabellini
On Mon, 4 Dec 2023, Nicola Vetrini wrote: > The labels marked with __maybe_unused are either used only > in certain build configurations or deliberately unused. > See the justification in docs/misra/deviations.rst. > > No functional changes. > > Signed-off-by: Nicola Vetrini Reviewed-by: Stefan

Re: [XEN PATCH v2 1/3] automation/eclair: tag function calls to address violations of MISRA C:2012 Rule 13.1

2023-12-04 Thread Stefano Stabellini
On Mon, 4 Dec 2023, Simone Ballarin wrote: > On 02/12/23 04:19, Stefano Stabellini wrote: > > On Fri, 24 Nov 2023, Simone Ballarin wrote: > > > Rule 13.1: Initializer lists shall not contain persistent side effects > > > > > > Invocations of functions in initializer lists cause violations of rule

Re: [RFC KERNEL PATCH v2 2/3] xen/pvh: Unmask irq for passthrough device in PVH dom0

2023-12-04 Thread Stefano Stabellini
On Mon, 4 Dec 2023, Roger Pau Monné wrote: > On Fri, Dec 01, 2023 at 07:37:55PM -0800, Stefano Stabellini wrote: > > On Fri, 1 Dec 2023, Roger Pau Monné wrote: > > > On Thu, Nov 30, 2023 at 07:15:17PM -0800, Stefano Stabellini wrote: > > > > On Thu, 30 Nov 2023, Roger Pau Monné wrote: > > > > > On

Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

2023-12-04 Thread Stefano Stabellini
On Mon, 4 Dec 2023, Roger Pau Monné wrote: > On Fri, Dec 01, 2023 at 06:56:32PM -0800, Stefano Stabellini wrote: > > On Fri, 1 Dec 2023, Roger Pau Monné wrote: > > > On Mon, Nov 13, 2023 at 05:21:13PM -0500, Stewart Hildebrand wrote: > > > > @@ -1618,6 +1630,14 @@ int iommu_do_pci_domctl( > > > >

Re: [RFC KERNEL PATCH v2 1/3] xen/pci: Add xen_reset_device_state function

2023-12-04 Thread Stefano Stabellini
On Mon, 3 Dec 2023, Chen, Jiqian wrote: > >> vpci device state when device is reset on dom0 side. > >> > >> And call that function in pcistub_init_device. Because when > >> we use "pci-assignable-add" to assign a passthrough device in > >> Xen, it will reset passthrough device and the vpci state wi

[PATCH v10 2/2] xen/vpci: header: filter PCI capabilities

2023-12-04 Thread Stewart Hildebrand
Currently, Xen vPCI only supports virtualizing the MSI and MSI-X capabilities. Hide all other PCI capabilities (including extended capabilities) from domUs for now, even though there may be certain devices/drivers that depend on being able to discover certain capabilities. We parse the physical PC

[PATCH v10 1/2] xen/vpci: header: status register handler

2023-12-04 Thread Stewart Hildebrand
Introduce a handler for the PCI status register, with ability to mask the capabilities bit. The status register contains RsvdZ bits, read-only bits, and write-1-to-clear bits. Additionally, we use RsvdP to mask the capabilities bit. Introduce bitmasks to handle these in vPCI. If a bit in the bitmas

[PATCH v10 0/2] vPCI capabilities filtering

2023-12-04 Thread Stewart Hildebrand
This small series enables vPCI to filter which PCI capabilities we expose to a domU. This series adds vPCI register handlers within xen/drivers/vpci/header.c:init_bars(), along with some supporting functions. Note there are minor rebase conflicts with the in-progress vPCI series [1]. These conflic

Re: [RFC PATCH] xen/arm: Add emulation of Debug Data Transfer Registers

2023-12-04 Thread Julien Grall
On 04/12/2023 13:02, Ayan Kumar Halder wrote: On 04/12/2023 10:31, Julien Grall wrote: Hi Ayan, Hi Julien, On 01/12/2023 18:50, Ayan Kumar Halder wrote: Currently if user enables HVC_DCC config option in Linux, it invokes access to debug data transfer registers (ie DBGDTRTX_EL0 on arm64,

Re: [ANNOUNCE] Call for agenda items for 7 DECEMBER Community Call @ 1600 UTC

2023-12-04 Thread George Dunlap
> > Note the following administrative conventions for the call: > > * Unless, agreed in the previous meeting otherwise, the call is on the > > 1st Thursday of each month at 1600 British Time (either GMT or BST) > > IOW in the subject it's 1600 UTC and YYY == Dec 7? Oops -- yes, 7 December, 1600UTC

Re: [PATCH] sched: correct sched_move_domain()'s cleanup path

2023-12-04 Thread George Dunlap
On Mon, Dec 4, 2023 at 2:44 PM Juergen Gross wrote: > >> Personally I prefer to keep the "goto out", rather than duplicating > >> the rcu_read_unlock(). I'd yield if Jan said he preferred > >> duplication, however. > > > > I'm on the edge there actually. > > In this case I'd prefer it my way, as

Re: [RFC XEN PATCH] xen/arm: ffa: reclaim shared memory on guest destroy

2023-12-04 Thread Julien Grall
Hi Jens, On 04/12/2023 07:55, Jens Wiklander wrote: When an FF-A enabled guest is destroyed it may leave behind memory shared with SPs. This memory must be reclaimed before it's reused or an SP may make changes to memory used by a new unrelated guest. So when the domain is teared down add FF-A r

Re: [BUG]i2c_hid_acpi broken with 4.17.2 on Framework Laptop 13 AMD

2023-12-04 Thread Sébastien Chaumat
Le lun. 4 déc. 2023 à 10:06, Jan Beulich a écrit : > On 03.12.2023 10:56, Sébastien Chaumat wrote: > > Hello, > > > > Trying to get the Framework Laptop 13 AMD to work with QubesOS I hit the > > following Xen issue : > > > > Xen version : 4.17.2 > + tested with 4.18.0 > > Kernel : 6.5.12-300.f

Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

2023-12-04 Thread Stewart Hildebrand
On 12/4/23 05:58, Roger Pau Monné wrote: > On Fri, Dec 01, 2023 at 06:56:32PM -0800, Stefano Stabellini wrote: >> On Fri, 1 Dec 2023, Roger Pau Monné wrote: >>> On Mon, Nov 13, 2023 at 05:21:13PM -0500, Stewart Hildebrand wrote: @@ -1618,6 +1630,14 @@ int iommu_do_pci_domctl( bus

Re: [PATCH] CODING_STYLE: Add a section of the naming convention

2023-12-04 Thread Julien Grall
Hi Jan, On 04/12/2023 09:39, Jan Beulich wrote: On 01.12.2023 19:49, Julien Grall wrote: +Naming convention +- + +'-' should be used to separate words in commandline options and filenames. +E.g. timer-works. + +Note that some of the options and filenames are using '_'. This is n

[XEN PATCH] docs/misra: deviate deliberately unused labels

2023-12-04 Thread Nicola Vetrini
The labels marked with __maybe_unused are either used only in certain build configurations or deliberately unused. See the justification in docs/misra/deviations.rst. No functional changes. Signed-off-by: Nicola Vetrini --- automation/eclair_analysis/ECLAIR/deviations.ecl | 4 docs/misra/d

Re: [PATCH v3 4/6] x86/vPIT: check values loaded from state save record

2023-12-04 Thread Roger Pau Monné
On Tue, Nov 28, 2023 at 11:35:18AM +0100, Jan Beulich wrote: > In particular pit_latch_status() and speaker_ioport_read() perform > calculations which assume in-bounds values. Several of the state save > record fields can hold wider ranges, though. Refuse to load values which > cannot result from n

Re: Trying add smt=off disabled cores to cpupool crash xen

2023-12-04 Thread René Winther Højgaard
Hi Juergen, Sorry for the late reply. Here are the commands I execute, it is 'xl cpupool-cpu-add pcores 4-15' that crash the system. xl cpupool-cpu-remove Pool-0 4-31 xl cpupool-create name=\"ecores\" sched=\"credit\" xl cpupool-cpu-add ecores 16-31 xl cpupool-create name=\"pcores\" sched=\"cr

Re: [PATCH v3] xen: address violations of MISRA C:2012 Rule 11.8.

2023-12-04 Thread Julien Grall
On 04/12/2023 16:32, Simone Ballarin wrote: From: Maria Celeste Cesario Remove or amend casts to comply with Rule 11.8. Fix violations by adding missing const qualifier in cast. Fix violations by removing unnecessary cast. Change type of operands from char* to uintptr_t: uintptr_t is the ap

Re: [PATCH v3 2/6] x86/HVM: split restore state checking from state loading

2023-12-04 Thread Roger Pau Monné
On Tue, Nov 28, 2023 at 11:34:04AM +0100, Jan Beulich wrote: > ..., at least as reasonably feasible without making a check hook > mandatory (in particular strict vs relaxed/zero-extend length checking > can't be done early this way). > > Note that only one of the two uses of hvm_load() is accompan

[linux-linus test] 183984: regressions - FAIL

2023-12-04 Thread osstest service owner
flight 183984 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/183984/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-pvops 6 kernel-build fail REGR. vs. 183973 Tests which are fai

Re: [PATCH v3] xen: address violations of MISRA C:2012 Rule 11.8.

2023-12-04 Thread Simone Ballarin
On 04/12/23 17:54, Jan Beulich wrote: On 04.12.2023 17:32, Simone Ballarin wrote: From: Maria Celeste Cesario Remove or amend casts to comply with Rule 11.8. Fix violations by adding missing const qualifier in cast. Fix violations by removing unnecessary cast. Change type of operands from cha

Re: [PATCH v2 2/3] xen/sched: fix sched_move_domain()

2023-12-04 Thread Jan Beulich
On 04.12.2023 16:23, Juergen Gross wrote: > Do cleanup in sched_move_domain() in a dedicated service function, > which is called either in error case with newly allocated data, or in > success case with the old data to be freed. > > This will at once fix some subtle bugs which sneaked in due to >

Re: [PATCH v2 1/3] xen/sched: fix adding offline cpu to cpupool

2023-12-04 Thread Jan Beulich
On 04.12.2023 16:23, Juergen Gross wrote: > Trying to add an offline cpu to a cpupool can crash the hypervisor, > as the probably non-existing percpu area of the cpu is accessed before > the availability of the cpu is being tested. This can happen in case > the cpupool's granularity is "core" or "s

Re: [PATCH v3] xen: address violations of MISRA C:2012 Rule 11.8.

2023-12-04 Thread Jan Beulich
On 04.12.2023 17:32, Simone Ballarin wrote: > From: Maria Celeste Cesario > > Remove or amend casts to comply with Rule 11.8. > > Fix violations by adding missing const qualifier in cast. > Fix violations by removing unnecessary cast. > Change type of operands from char* to uintptr_t: uintptr_t

Re: [XEN PATCH 6/7] xen/x86: remove stale comment

2023-12-04 Thread Nicola Vetrini
On 2023-12-04 17:40, Jan Beulich wrote: On 04.12.2023 17:26, Nicola Vetrini wrote: On 2023-12-01 17:57, Nicola Vetrini wrote: On 2023-11-30 17:41, Jan Beulich wrote: On 29.11.2023 16:24, Nicola Vetrini wrote: The comment referred to the declaration for do_mca, which now is part of hypercall-d

Re: [ANNOUNCE] Call for agenda items for YYY Community Call @ 1500 UTC

2023-12-04 Thread Jan Beulich
On 04.12.2023 17:25, George Dunlap wrote: > I'll be running the community call while Kelly is travelling. > > The proposed agenda is in > https://cryptpad.fr/pad/#/2/pad/edit/SvabZ2utDN3G7XRSG2k1NSLJ/ and you > can edit to add items. Alternatively, you can reply to this mail > directly. > > Agen

Re: [XEN PATCH 1/2] x86/p2m: preparation work for xenmem_add_to_physmap_one()

2023-12-04 Thread Jan Beulich
On 04.12.2023 16:42, Federico Serafini wrote: > On 04/12/23 15:51, Jan Beulich wrote: >> On 30.11.2023 16:48, Federico Serafini wrote: >>> The objective is to use parameter name "gfn" for >>> xenmem_add_to_physmap_one(). >>> Since the name "gfn" is currently used as identifier for a local >>> varia

Re: [XEN PATCH 6/7] xen/x86: remove stale comment

2023-12-04 Thread Jan Beulich
On 04.12.2023 17:26, Nicola Vetrini wrote: > On 2023-12-01 17:57, Nicola Vetrini wrote: >> On 2023-11-30 17:41, Jan Beulich wrote: >>> On 29.11.2023 16:24, Nicola Vetrini wrote: The comment referred to the declaration for do_mca, which now is part of hypercall-defs.h, therefore the commen

[PATCH v3] xen: address violations of MISRA C:2012 Rule 11.8.

2023-12-04 Thread Simone Ballarin
From: Maria Celeste Cesario Remove or amend casts to comply with Rule 11.8. Fix violations by adding missing const qualifier in cast. Fix violations by removing unnecessary cast. Change type of operands from char* to uintptr_t: uintptr_t is the appropriate type for memory address operations. No

Re: [XEN PATCH 6/7] xen/x86: remove stale comment

2023-12-04 Thread Nicola Vetrini
On 2023-12-01 17:57, Nicola Vetrini wrote: On 2023-11-30 17:41, Jan Beulich wrote: On 29.11.2023 16:24, Nicola Vetrini wrote: The comment referred to the declaration for do_mca, which now is part of hypercall-defs.h, therefore the comment is stale. If the comments were stale, the #include-s s

[ANNOUNCE] Call for agenda items for YYY Community Call @ 1500 UTC

2023-12-04 Thread George Dunlap
Hi all, I'll be running the community call while Kelly is travelling. The proposed agenda is in https://cryptpad.fr/pad/#/2/pad/edit/SvabZ2utDN3G7XRSG2k1NSLJ/ and you can edit to add items. Alternatively, you can reply to this mail directly. Agenda items appreciated a few days before the call:

[PATCH v11.1 16/17] xen/arm: vpci: permit access to guest vpci space

2023-12-04 Thread Stewart Hildebrand
Move iomem_caps initialization earlier (before arch_domain_create()). Signed-off-by: Stewart Hildebrand Signed-off-by: Volodymyr Babchuk --- Changes in v11: * move both iomem_caps and irq_caps initializations earlier, along with NULL check Changes in v10: * fix off-by-one * also permit access

Re: [PATCH v11 16/17] xen/arm: vpci: permit access to guest vpci space

2023-12-04 Thread Stewart Hildebrand
On 12/4/23 03:29, Jan Beulich wrote: > On 02.12.2023 02:27, Volodymyr Babchuk wrote: >> --- a/xen/common/domain.c >> +++ b/xen/common/domain.c >> @@ -695,6 +695,9 @@ struct domain *domain_create(domid_t domid, >> radix_tree_init(&d->pirq_tree); >> } >> >> +if ( !is_idle_domain(d

Re: [XEN PATCH 1/2] x86/p2m: preparation work for xenmem_add_to_physmap_one()

2023-12-04 Thread Federico Serafini
On 04/12/23 15:51, Jan Beulich wrote: On 30.11.2023 16:48, Federico Serafini wrote: The objective is to use parameter name "gfn" for xenmem_add_to_physmap_one(). Since the name "gfn" is currently used as identifier for a local variable, bad things could happen if new uses of such variable are co

Re: [PATCH 05/12] block: remove AioContext locking

2023-12-04 Thread Stefan Hajnoczi
On Thu, Nov 30, 2023 at 03:31:37PM -0600, Eric Blake wrote: > On Wed, Nov 29, 2023 at 02:55:46PM -0500, Stefan Hajnoczi wrote: > > This is the big patch that removes > > aio_context_acquire()/aio_context_release() from the block layer and > > affected block layer users. > > > > There isn't a clean

Re: [PATCH 06/12] scsi: remove AioContext locking

2023-12-04 Thread Stefan Hajnoczi
On Mon, Dec 04, 2023 at 01:23:09PM +0100, Kevin Wolf wrote: > Am 29.11.2023 um 20:55 hat Stefan Hajnoczi geschrieben: > > The AioContext lock no longer has any effect. Remove it. > > > > Signed-off-by: Stefan Hajnoczi > > --- > > include/hw/virtio/virtio-scsi.h | 14 -- > > hw/scsi/s

[PATCH v2 0/3] xen/sched: fixes and cleanup related to cpupools

2023-12-04 Thread Juergen Gross
Fix 2 bugs related to cpupool handling and do some related cleanups. V2: - send out the fixes tagged properly as "PATCH" - add cleanup patch Juergen Gross (3): xen/sched: fix adding offline cpu to cpupool xen/sched: fix sched_move_domain() xen/sched: do some minor cleanup of sched_move_dom

[PATCH v2 2/3] xen/sched: fix sched_move_domain()

2023-12-04 Thread Juergen Gross
Do cleanup in sched_move_domain() in a dedicated service function, which is called either in error case with newly allocated data, or in success case with the old data to be freed. This will at once fix some subtle bugs which sneaked in due to forgetting to overwrite some pointers in the error cas

[PATCH v2 3/3] xen/sched: do some minor cleanup of sched_move_domain()

2023-12-04 Thread Juergen Gross
Do some minor cleanups: - Move setting of old_domdata and old_units next to each other - Drop incrementing unit_idx in the final loop of sched_move_domain() as it isn't used afterwards - Rename new_p to new_cpu and unit_p to unit_cpu Signed-off-by: Juergen Gross --- V2: - new patch --- xen/co

[PATCH v2 1/3] xen/sched: fix adding offline cpu to cpupool

2023-12-04 Thread Juergen Gross
Trying to add an offline cpu to a cpupool can crash the hypervisor, as the probably non-existing percpu area of the cpu is accessed before the availability of the cpu is being tested. This can happen in case the cpupool's granularity is "core" or "socket". Fix that by testing the cpu to be online.

Re: [XEN PATCH 2/2] x86/p2m: address a violation of MISRA C:2012 Rule 8.3

2023-12-04 Thread Federico Serafini
On 04/12/23 15:54, Jan Beulich wrote: On 30.11.2023 16:48, Federico Serafini wrote: Make function declaration and definition consistent changing parameter name from "gpfn" to "gfn". For consistency, rename also "old_gpfn" to "old_gfn". No functional change. Signed-off-by: Federico Serafini R

Re: [PATCH 05/12] block: remove AioContext locking

2023-12-04 Thread Stefan Hajnoczi
On Mon, Dec 04, 2023 at 03:33:57PM +0100, Kevin Wolf wrote: > Am 29.11.2023 um 20:55 hat Stefan Hajnoczi geschrieben: > > This is the big patch that removes > > aio_context_acquire()/aio_context_release() from the block layer and > > affected block layer users. > > > > There isn't a clean way to s

Re: [XEN PATCH 2/2] x86/p2m: address a violation of MISRA C:2012 Rule 8.3

2023-12-04 Thread Jan Beulich
On 30.11.2023 16:48, Federico Serafini wrote: > Make function declaration and definition consistent changing > parameter name from "gpfn" to "gfn". > For consistency, rename also "old_gpfn" to "old_gfn". > No functional change. > > Signed-off-by: Federico Serafini Reviewed-by: Jan Beulich > --

Re: [XEN PATCH 1/2] x86/p2m: preparation work for xenmem_add_to_physmap_one()

2023-12-04 Thread Jan Beulich
On 30.11.2023 16:48, Federico Serafini wrote: > The objective is to use parameter name "gfn" for > xenmem_add_to_physmap_one(). > Since the name "gfn" is currently used as identifier for a local > variable, bad things could happen if new uses of such variable are > committed while a renaming patch

Re: [PATCH 01/12] virtio-scsi: replace AioContext lock with tmf_bh_lock

2023-12-04 Thread Stefan Hajnoczi
On Mon, Dec 04, 2023 at 01:46:13PM +0100, Kevin Wolf wrote: > Am 29.11.2023 um 20:55 hat Stefan Hajnoczi geschrieben: > > Protect the Task Management Function BH state with a lock. The TMF BH > > runs in the main loop thread. An IOThread might process a TMF at the > > same time as the TMF BH is run

Re: [PATCH v4 3/6] xen: decouple generic xen code from legacy backends codebase

2023-12-04 Thread Paul Durrant
On 02/12/2023 01:41, Volodymyr Babchuk wrote: In xen-all.c there are unneeded dependencies on xen-legacy-backend.c: - xen_init() uses xen_pv_printf() to report errors, but it does not provide a pointer to the struct XenLegacyDevice, so it is kind of useless, we can use standard error_repor

Re: [PATCH 01/12] virtio-scsi: replace AioContext lock with tmf_bh_lock

2023-12-04 Thread Stefan Hajnoczi
On Thu, Nov 30, 2023 at 09:25:52AM -0600, Eric Blake wrote: > On Wed, Nov 29, 2023 at 02:55:42PM -0500, Stefan Hajnoczi wrote: > > Protect the Task Management Function BH state with a lock. The TMF BH > > runs in the main loop thread. An IOThread might process a TMF at the > > same time as the TMF

Re: [linux-linus test] 183981: regressions - FAIL

2023-12-04 Thread Juergen Gross
On 04.12.23 15:42, Anthony PERARD wrote: On Mon, Dec 04, 2023 at 06:56:50AM +0100, Juergen Gross wrote: On 04.12.23 00:51, osstest service owner wrote: flight 183981 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/183981/ Regressions :-( Tests which did not succeed an

Re: [PATCH] sched: correct sched_move_domain()'s cleanup path

2023-12-04 Thread Juergen Gross
On 04.12.23 15:39, Jan Beulich wrote: On 04.12.2023 15:18, George Dunlap wrote: On Mon, Dec 4, 2023 at 2:10 PM Juergen Gross wrote: On 04.12.23 14:00, George Dunlap wrote: On Mon, Dec 4, 2023 at 10:57 AM Jan Beulich wrote: It is only in the error case that we want to clean up the new pool

Re: [linux-linus test] 183981: regressions - FAIL

2023-12-04 Thread Anthony PERARD
On Mon, Dec 04, 2023 at 06:56:50AM +0100, Juergen Gross wrote: > On 04.12.23 00:51, osstest service owner wrote: > > flight 183981 linux-linus real [real] > > http://logs.test-lab.xenproject.org/osstest/logs/183981/ > > > > Regressions :-( > > > > Tests which did not succeed and are blocking, > >

Re: [PATCH] sched: correct sched_move_domain()'s cleanup path

2023-12-04 Thread Juergen Gross
On 04.12.23 15:38, Jan Beulich wrote: On 04.12.2023 15:10, Juergen Gross wrote: And I have again a third approach, making it crystal clear what is happening with which data. No need to explain what is freed via which variables. See attached patch (this time it should be really there). Looks mo

Re: [PATCH] sched: correct sched_move_domain()'s cleanup path

2023-12-04 Thread Jan Beulich
On 04.12.2023 15:18, George Dunlap wrote: > On Mon, Dec 4, 2023 at 2:10 PM Juergen Gross wrote: >> >> On 04.12.23 14:00, George Dunlap wrote: >>> On Mon, Dec 4, 2023 at 10:57 AM Jan Beulich wrote: It is only in the error case that we want to clean up the new pool's scheduler data;

Re: [PATCH] sched: correct sched_move_domain()'s cleanup path

2023-12-04 Thread Jan Beulich
On 04.12.2023 15:10, Juergen Gross wrote: > And I have again a third approach, making it crystal clear what is happening > with which data. No need to explain what is freed via which variables. See > attached patch (this time it should be really there). Looks more neat to me than George's. Just on

Re: [PATCH 05/12] block: remove AioContext locking

2023-12-04 Thread Kevin Wolf
Am 29.11.2023 um 20:55 hat Stefan Hajnoczi geschrieben: > This is the big patch that removes > aio_context_acquire()/aio_context_release() from the block layer and > affected block layer users. > > There isn't a clean way to split this patch and the reviewers are likely > the same group of people,

Re: [PATCH] sched: correct sched_move_domain()'s cleanup path

2023-12-04 Thread George Dunlap
On Mon, Dec 4, 2023 at 2:10 PM Juergen Gross wrote: > > On 04.12.23 14:00, George Dunlap wrote: > > On Mon, Dec 4, 2023 at 10:57 AM Jan Beulich wrote: > >> > >> It is only in the error case that we want to clean up the new pool's > >> scheduler data; in the success case it's rather the old schedu

Re: [PATCH] sched: correct sched_move_domain()'s cleanup path

2023-12-04 Thread Juergen Gross
On 04.12.23 14:00, George Dunlap wrote: On Mon, Dec 4, 2023 at 10:57 AM Jan Beulich wrote: It is only in the error case that we want to clean up the new pool's scheduler data; in the success case it's rather the old scheduler's data which needs cleaning up. Reported-by: René Winther Højgaard

Re: [PATCH v9 2/2] xen/vpci: header: filter PCI capabilities

2023-12-04 Thread Roger Pau Monné
On Mon, Dec 04, 2023 at 12:48:00PM +0100, Jan Beulich wrote: > On 01.12.2023 16:45, Stewart Hildebrand wrote: > > --- a/xen/drivers/pci/pci.c > > +++ b/xen/drivers/pci/pci.c > > @@ -39,31 +39,42 @@ unsigned int pci_find_cap_offset(pci_sbdf_t sbdf, > > unsigned int cap) > > return 0; > > } >

Re: [PATCH v9 1/2] xen/vpci: header: status register handler

2023-12-04 Thread Roger Pau Monné
On Fri, Dec 01, 2023 at 10:45:49AM -0500, Stewart Hildebrand wrote: > Introduce a handler for the PCI status register, with ability to mask > the capabilities bit. The status register contains RsvdZ bits, > read-only bits, and write-1-to-clear bits. Additionally, we use RsvdP to > mask the capabili

Re: [PATCH] sched: correct sched_move_domain()'s cleanup path

2023-12-04 Thread George Dunlap
On Mon, Dec 4, 2023 at 1:47 PM Juergen Gross wrote: > > On 04.12.23 14:00, George Dunlap wrote: > > On Mon, Dec 4, 2023 at 10:57 AM Jan Beulich wrote: > >> > >> It is only in the error case that we want to clean up the new pool's > >> scheduler data; in the success case it's rather the old schedu

xen | Successful pipeline for staging | 525c7c09

2023-12-04 Thread GitLab
Pipeline #1093622286 has passed! Project: xen ( https://gitlab.com/xen-project/xen ) Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) Commit: 525c7c09 ( https://gitlab.com/xen-project/xen/-/commit/525c7c094b258e8a46b494488eef96f5670eb352 ) Commit Message: xen/arm: Move

Re: [PATCH] sched: correct sched_move_domain()'s cleanup path

2023-12-04 Thread Juergen Gross
On 04.12.23 14:00, George Dunlap wrote: On Mon, Dec 4, 2023 at 10:57 AM Jan Beulich wrote: It is only in the error case that we want to clean up the new pool's scheduler data; in the success case it's rather the old scheduler's data which needs cleaning up. Reported-by: René Winther Højgaard

Re: [PATCH 04/12] graph-lock: remove AioContext locking

2023-12-04 Thread Kevin Wolf
Am 29.11.2023 um 20:55 hat Stefan Hajnoczi geschrieben: > Stop acquiring/releasing the AioContext lock in > bdrv_graph_wrlock()/bdrv_graph_unlock() since the lock no longer has any > effect. > > The distinction between bdrv_graph_wrunlock() and > bdrv_graph_wrunlock_ctx() becomes meaningless and t

Re: [PATCH v2] x86emul: avoid triggering event related assertions

2023-12-04 Thread Andrew Cooper
On 17/04/2023 1:23 pm, Jan Beulich wrote: > The assertion at the end of x86_emulate_wrapper() as well as the ones > in x86_emul_{hw_exception,pagefault}() can trigger if we ignore > X86EMUL_EXCEPTION coming back from certain hook functions. Squash > exceptions when merely probing MSRs, plus on SWAP

Re: [PATCH 03/12] aio: make aio_context_acquire()/aio_context_release() a no-op

2023-12-04 Thread Kevin Wolf
Am 29.11.2023 um 20:55 hat Stefan Hajnoczi geschrieben: > aio_context_acquire()/aio_context_release() has been replaced by > fine-grained locking to protect state shared by multiple threads. The > AioContext lock still plays the role of balancing locking in > AIO_WAIT_WHILE() and many functions in

Re: [PATCH] bump default SeaBIOS version to 1.16.3

2023-12-04 Thread Roger Pau Monné
On Mon, Dec 04, 2023 at 12:12:58PM +0100, Jan Beulich wrote: > Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Thanks, Roger.

Re: [RFC PATCH] xen/arm: Add emulation of Debug Data Transfer Registers

2023-12-04 Thread Ayan Kumar Halder
On 04/12/2023 10:31, Julien Grall wrote: Hi Ayan, Hi Julien, On 01/12/2023 18:50, Ayan Kumar Halder wrote: Currently if user enables HVC_DCC config option in Linux, it invokes access to debug data transfer registers (ie DBGDTRTX_EL0 on arm64, DBGDTRTXINT on arm32). As these registers are no

Re: [PATCH] sched: correct sched_move_domain()'s cleanup path

2023-12-04 Thread George Dunlap
On Mon, Dec 4, 2023 at 10:57 AM Jan Beulich wrote: > > It is only in the error case that we want to clean up the new pool's > scheduler data; in the success case it's rather the old scheduler's > data which needs cleaning up. > > Reported-by: René Winther Højgaard > Signed-off-by: Jan Beulich >

Re: [PATCH 1/2] x86/xen: add CPU dependencies for 32-bit build

2023-12-04 Thread Juergen Gross
On 04.12.23 09:47, Arnd Bergmann wrote: From: Arnd Bergmann Xen only supports modern CPUs even when running a 32-bit kernel, and it now requires a kernel built for a 64 byte (or larger) cache line: In file included from : In function 'xen_vcpu_setup', inlined from 'xen_vcpu_setup_restore'

Re: [PATCH 02/12] tests: remove aio_context_acquire() tests

2023-12-04 Thread Kevin Wolf
Am 29.11.2023 um 20:55 hat Stefan Hajnoczi geschrieben: > The aio_context_acquire() API is being removed. Drop the test case that > calls the API. > > Signed-off-by: Stefan Hajnoczi Reviewed-by: Kevin Wolf

Re: [PATCH 01/12] virtio-scsi: replace AioContext lock with tmf_bh_lock

2023-12-04 Thread Kevin Wolf
Am 29.11.2023 um 20:55 hat Stefan Hajnoczi geschrieben: > Protect the Task Management Function BH state with a lock. The TMF BH > runs in the main loop thread. An IOThread might process a TMF at the > same time as the TMF BH is running. Therefore tmf_bh_list and tmf_bh > must be protected by a lock

Re: [PATCH 01/12] virtio-scsi: replace AioContext lock with tmf_bh_lock

2023-12-04 Thread Kevin Wolf
Am 29.11.2023 um 20:55 hat Stefan Hajnoczi geschrieben: > Protect the Task Management Function BH state with a lock. The TMF BH > runs in the main loop thread. An IOThread might process a TMF at the > same time as the TMF BH is running. Therefore tmf_bh_list and tmf_bh > must be protected by a lock

Re: [PATCH 06/12] scsi: remove AioContext locking

2023-12-04 Thread Kevin Wolf
Am 29.11.2023 um 20:55 hat Stefan Hajnoczi geschrieben: > The AioContext lock no longer has any effect. Remove it. > > Signed-off-by: Stefan Hajnoczi > --- > include/hw/virtio/virtio-scsi.h | 14 -- > hw/scsi/scsi-bus.c | 2 -- > hw/scsi/scsi-disk.c | 28 +++

Re: [PATCH] x86/DMI: adjustments to comply with Misra C:2012 Rule 9.3

2023-12-04 Thread Jan Beulich
On 04.12.2023 12:52, Nicola Vetrini wrote: > On 2023-11-30 15:56, Jan Beulich wrote: >> On 30.11.2023 08:55, Jan Beulich wrote: >>> The rule demands that all array elements be initialized (or dedicated >>> initializers be used). Introduce a small set of macros to allow doing >>> so >>> without und

Re: Trying add smt=off disabled cores to cpupool crash xen

2023-12-04 Thread Juergen Gross
On 04.12.23 11:13, Jan Beulich wrote: On 04.12.2023 11:02, Juergen Gross wrote: On 04.12.23 10:15, Jan Beulich wrote: On 01.12.2023 21:12, Andrew Cooper wrote: On 01/12/2023 7:59 pm, René Winther Højgaard wrote: If I set smt=off and try to configure cpupools with credit(1) as if all cores are

[xen-unstable test] 183983: tolerable FAIL

2023-12-04 Thread osstest service owner
flight 183983 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/183983/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 183971 test-amd64-amd64-xl-qemut-win7-amd64

Re: [XEN PATCH 7/7] xen/page_alloc: deviate first_valid_mfn for MISRA C Rule 8.4

2023-12-04 Thread Nicola Vetrini
On 2023-12-04 08:44, Jan Beulich wrote: On 02.12.2023 04:03, Stefano Stabellini wrote: On Fri, 1 Dec 2023, Jan Beulich wrote: On 01.12.2023 03:47, Stefano Stabellini wrote: On Wed, 29 Nov 2023, Nicola Vetrini wrote: No functional change. Signed-off-by: Nicola Vetrini --- The preferred way t

Re: [PATCH] x86/DMI: adjustments to comply with Misra C:2012 Rule 9.3

2023-12-04 Thread Nicola Vetrini
On 2023-11-30 15:56, Jan Beulich wrote: On 30.11.2023 08:55, Jan Beulich wrote: The rule demands that all array elements be initialized (or dedicated initializers be used). Introduce a small set of macros to allow doing so without unduly affecting use sites (in particular in terms of how many

Re: [PATCH v9 2/2] xen/vpci: header: filter PCI capabilities

2023-12-04 Thread Jan Beulich
On 01.12.2023 16:45, Stewart Hildebrand wrote: > --- a/xen/drivers/pci/pci.c > +++ b/xen/drivers/pci/pci.c > @@ -39,31 +39,42 @@ unsigned int pci_find_cap_offset(pci_sbdf_t sbdf, > unsigned int cap) > return 0; > } > > -unsigned int pci_find_next_cap(pci_sbdf_t sbdf, unsigned int pos, > -

Re: [PATCH] CODING_STYLE: Add a section of the naming convention

2023-12-04 Thread Luca Fancellu
> On 4 Dec 2023, at 11:31, Julien Grall wrote: > > Hi Luca, > > On 04/12/2023 11:20, Luca Fancellu wrote: >>> On 1 Dec 2023, at 18:49, Julien Grall wrote: >>> >>> >>> >>> On 01/12/2023 18:47, Julien Grall wrote: From: Julien Grall Several maintainers have expressed a stronger pr

  1   2   >