Re: Xens handling of MCE

On 06.09.2023 23:38, Elliott Mitchell wrote: > On Thu, Aug 31, 2023 at 07:52:05PM +, Development wrote: >> >> However, in 2009-02, "cegger" wrote MCA/MCE_in_Xen, a proposal for >> having xen start checking the information >> Xen started accessing the EDAC information (now called "MCE")

Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT

On 06.09.2023 22:49, Stefano Stabellini wrote: > On Fri, 1 Sep 2023, Jan Beulich wrote: >> On 07.08.2023 11:38, Simon Gaiser wrote: >>> It seems some firmwares put dummy entries in the ACPI MADT table for non >>> existing processors. On my NUC11TNHi5 those have the invalid APIC ID >>> 0xff. Linux a

Re: [PATCH v2] docs/misra: add 14.3

On 07.09.2023 03:21, Stefano Stabellini wrote: > On Thu, 31 Aug 2023, Jan Beulich wrote: >> On 31.08.2023 03:53, Stefano Stabellini wrote: >>> @@ -332,6 +333,17 @@ maintainers if you want to suggest a change. >>> - A loop counter shall not have essentially floating type >>> - >>> >>>

Re: [XEN PATCH] xen/types: address Rule 10.1 for macro BITS_TO_LONGS

On 07.09.2023 03:33, Stefano Stabellini wrote: > On Wed, 6 Sep 2023, Jan Beulich wrote: >> On 06.09.2023 17:57, Nicola Vetrini wrote: >>> On 05/09/2023 10:33, Jan Beulich wrote: On 05.09.2023 10:20, Nicola Vetrini wrote: > On 05/09/2023 09:46, Jan Beulich wrote: >> On 05.09.2023 09:31,

[xen-unstable-smoke test] 182709: tolerable all pass - PUSHED

flight 182709 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182709/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[xen-4.15-testing test] 182658: tolerable trouble: fail/pass/starved - PUSHED

flight 182658 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/182658/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-migrupgrade 10 xen-install/src_host fail in 182633 pass in 182658 test-amd64-i386-migrupgr

[libvirt test] 182642: tolerable all pass - PUSHED

flight 182642 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/182642/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 182629 test-armhf-armhf-libvirt-qcow2 15 saveres

Re: [XEN PATCH] xen/types: address Rule 10.1 for macro BITS_TO_LONGS

On Wed, 6 Sep 2023, Jan Beulich wrote: > On 06.09.2023 17:57, Nicola Vetrini wrote: > > On 05/09/2023 10:33, Jan Beulich wrote: > >> On 05.09.2023 10:20, Nicola Vetrini wrote: > >>> On 05/09/2023 09:46, Jan Beulich wrote: > On 05.09.2023 09:31, Nicola Vetrini wrote: > > Given its use in th

[PATCH v2] docs/misra: add 14.3

From: Stefano Stabellini Add 14.3, with project-wide deviations. Also take the opportunity to clarify that parameters of function pointer types are expected to have names (Rule 8.2). Signed-off-by: Stefano Stabellini --- Changes in v2: - add switch to the Rule 14.3 exceptions - add "and alike"

Re: [PATCH v2] docs/misra: add 14.3

On Thu, 31 Aug 2023, Jan Beulich wrote: > On 31.08.2023 03:53, Stefano Stabellini wrote: > > @@ -332,6 +333,17 @@ maintainers if you want to suggest a change. > > - A loop counter shall not have essentially floating type > > - > > > > + * - `Rule 14.3 > >

Re: [XEN PATCH v2] xen/arm: ioreq: add header for 'handle_ioserv' and 'try_fwd_ioserv'

On Mon, 4 Sep 2023, Nicola Vetrini wrote: > The functions referenced by this patch should have had a compatible > declaration visible prior to their definition. This is achieved by > including the arch-specific header in 'xen/arch/arm/ioreq.c' > > Fixes: cb9953d2f2bc ("arm/ioreq: Introduce arch sp

Re: [XEN PATCH 12/13] xen: address violations of MISRA C:2012 Directive 4.10

On Wed, 6 Sep 2023, Jan Beulich wrote: > On 06.09.2023 00:27, Stefano Stabellini wrote: > > On Thu, 31 Aug 2023, Simone Ballarin wrote: > >> On 29/08/23 00:51, Stefano Stabellini wrote: > >>> On Mon, 28 Aug 2023, Simone Ballarin wrote: > Move or amended inclusion guards to address violations o

Re: [XEN PATCH v2 2/2] automation: execute SAF translation before the analysis with ECLAIR

On Wed, 6 Sep 2023, Nicola Vetrini wrote: > This allows local MISRA deviation comments to be translated into > the format recognized by ECLAIR. > > Signed-off-by: Nicola Vetrini Acked-by: Stefano Stabellini > --- > automation/eclair_analysis/prepare.sh | 3 +++ > 1 file changed, 3 insertions(

Re: [XEN PATCH v2 1/2] xen: apply deviation for Rule 8.4 (asm-only definitions)

On Wed, 6 Sep 2023, Nicola Vetrini wrote: > As stated in 'docs/misra/rules.rst' the functions that are used only by > asm modules do not need to conform to MISRA C:2012 Rule 8.4. > The deviations are carried out with a SAF comment. > > Signed-off-by: Nicola Vetrini This is better Reviewed-by: S

Re: [XEN PATCH 2/2] automation: execute SAF translation before the analysis with ECLAIR

On Fri, 1 Sep 2023, Nicola Vetrini wrote: > This allows local MISRA deviation comments to be translated into > the format recognized by ECLAIR. > > Signed-off-by: Nicola Vetrini Acked-by: Stefano Stabellini > --- > automation/eclair_analysis/prepare.sh | 3 +++ > 1 file changed, 3 insertions

Re: [XEN PATCH 1/2] xen: apply deviation for Rule 8.4 (asm-only definitions)

On Mon, 4 Sep 2023, Nicola Vetrini wrote: > > Further in the cover letter you say "Deviating variables needs more care, > > and > > is therefore postponed to another patch", yet then here you annotate a > > couple > > of variables as well. Could you clarify what the criteria are for "needs > > more

Re: [PATCH v2 1/2] automation: Switch ppc64le tests to PowerNV machine type

On Wed, 6 Sep 2023, Shawn Anastasio wrote: > Run ppc64le tests with the PowerNV machine type (bare metal) instead of > the paravirtualized pseries machine. This requires a more modern version > of QEMU than is present in debian bullseye's repository, so update the > dockerfile to build QEMU from so

[qemu-mainline test] 182638: tolerable FAIL - PUSHED

flight 182638 qemu-mainline real [real] flight 182698 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182638/ http://logs.test-lab.xenproject.org/osstest/logs/182698/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-am

RE: [EXT] Re: xen arm64 low power sleep support

On Wed, 6 Sep 2023, Anthony Chan wrote: > On Tue, 05 Sep 2023, Stefano Stabellini wrote: > > On Thu, 31 Aug 2023, Anthony Chan wrote: > > > On Thu, 30 Aug 2023, Stefano Stabellini wrote: > > > > On Wed, 30 Aug 2023, Anthony Chan wrote: > > > > > On Tue, 29 Aug 2023, Stefano Stabellini wrote: > > >

Re: [PATCH v2] acpi/processor: sanitize _PDC buffer bits when running as Xen dom0

Hi Jason, kernel test robot noticed the following build errors: [auto build test ERROR on tip/x86/core] [also build test ERROR on v6.5] [cannot apply to rafael-pm/linux-next linus/master next-20230906] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

[PATCH v2 0/2] ppc: Drop support for QEMU pseries

Hello all, This small series drops support for the QEMU paravirtualized pseries machine type in favor of the bare metal PowerNV platform. pseries support was broken by 74b725a64d80 ('xen/ppc: Implement initial Radix MMU support'), and instead of maintaining separate code paths to retain support fo

[PATCH v2 2/2] xen/ppc: Drop support for pseries/OpenFirmware

Since QEMU's PowerNV support has matured to the point where it is now suitable for development, drop support for booting on the paravirtualized pseries machine type and its associated interfaces. Support for booting on pseries was broken by 74b725a64d80 ('xen/ppc: Implement initial Radix MMU suppo

[PATCH v2 1/2] automation: Switch ppc64le tests to PowerNV machine type

Run ppc64le tests with the PowerNV machine type (bare metal) instead of the paravirtualized pseries machine. This requires a more modern version of QEMU than is present in debian bullseye's repository, so update the dockerfile to build QEMU from source. Support for booting on pseries was broken by

Re: [PATCH 2/2] xen/ppc: Drop support for pseries/OpenFirmware

On 9/6/23 1:44 AM, Jan Beulich wrote: > On 05.09.2023 23:46, Shawn Anastasio wrote: >> Since QEMU's PowerNV support has matured to the point where it is >> now suitable for development, drop support for booting on the >> paravirtualized pseries machine type and its associated interfaces. > > I thi

Re: [PATCH v2] acpi/processor: sanitize _PDC buffer bits when running as Xen dom0

Hi Jason, kernel test robot noticed the following build errors: [auto build test ERROR on tip/x86/core] [also build test ERROR on v6.5] [cannot apply to rafael-pm/linux-next linus/master next-20230906] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: Xens handling of MCE

On Thu, Aug 31, 2023 at 07:52:05PM +, Development wrote: > > However, in 2009-02, "cegger" wrote MCA/MCE_in_Xen, a proposal for having > xen start checking the information > Xen started accessing the EDAC information (now called "MCE") at some > point after that, which blocks the lin

Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT

On Fri, 1 Sep 2023, Jan Beulich wrote: > On 07.08.2023 11:38, Simon Gaiser wrote: > > It seems some firmwares put dummy entries in the ACPI MADT table for non > > existing processors. On my NUC11TNHi5 those have the invalid APIC ID > > 0xff. Linux already has code to handle those cases both in > >

Re: [PATCH v2] Arm: constrain {,u}int64_aligned_t in public header

On Tue, 5 Sep 2023, Henry Wang wrote: > Hi Jan, > > > On Sep 5, 2023, at 16:26, Jan Beulich wrote: > > > > For using a GNU extension, it may not be exposed in general, just like > > is done on x86 (except that here we need to also work around not all of > > the tool stack actually defining __XEN

Re: [PATCH] xen/arm: Fix printk specifiers and arguments in iomem_remove_cb()

On Wed, 6 Sep 2023, Vikram Garhwal wrote: > On Wed, Sep 06, 2023 at 12:30:14PM +0200, Michal Orzel wrote: > > When building Xen for arm32 with CONFIG_DTB_OVERLAY, the following > > error is printed: > > > > common/dt-overlay.c: In function ‘iomem_remove_cb’: > > ././include/xen/config.h:55:24: err

RE: [EXT] Re: xen arm64 low power sleep support

On Tue, 05 Sep 2023, Stefano Stabellini wrote: > On Thu, 31 Aug 2023, Anthony Chan wrote: > > On Thu, 30 Aug 2023, Stefano Stabellini wrote: > > > On Wed, 30 Aug 2023, Anthony Chan wrote: > > > > On Tue, 29 Aug 2023, Stefano Stabellini wrote: > > > > > On Tue, 29 Aug 2023, Anthony Chan wrote: > > >

Re: [PATCH v5 1/2] xen: asm-generic support

Hi all, Missed the comment (https://lore.kernel.org/xen- devel/[email protected]/T/#m99a4 dc8280439e84021c4e0546dc9ff539a60191 ) of Anthony so I'll sent a new one patch series tomorrow. Sorry for inconvenience. ~ Oleksii

Re: [PATCH v4 1/2] xen: asm-generic support

On Wed, 2023-09-06 at 16:57 +0100, Anthony PERARD wrote: > On Fri, Sep 01, 2023 at 07:02:14PM +0300, Oleksii Kurochko wrote: > > diff --git a/xen/Makefile b/xen/Makefile > > index f57e5a596c..698d6ddeb8 100644 > > --- a/xen/Makefile > > +++ b/xen/Makefile > > @@ -667,6 +669,12 @@ endif # need-sub-m

Re: [PATCH] xen/arm: Fix printk specifiers and arguments in iomem_remove_cb()

On Wed, Sep 06, 2023 at 12:30:14PM +0200, Michal Orzel wrote: > When building Xen for arm32 with CONFIG_DTB_OVERLAY, the following > error is printed: > > common/dt-overlay.c: In function ‘iomem_remove_cb’: > ././include/xen/config.h:55:24: error: format ‘%llx’ expects argument of type > ‘long lo

[PATCH v5 2/2] xen: move arm/include/asm/vm_event.h to stubs

asm/vm_event.h is common for ARM and RISC-V so it will be moved to stubs dir. Original asm/vm_event.h from ARM was updated: * use SPDX-License-Identifier. * update comment messages of stubs. * update #ifdef * instead of "include " -> "public/vm_event.h" As vm_event.h was moved to asm-generic

[PATCH v5 1/2] xen: asm-generic support

Some headers are shared between individual architectures or are empty. To avoid duplication of these headers, asm-generic is introduced. With the following patch, an architecture uses generic headers mentioned in the file arch/$(ARCH)/include/asm/Makefile To use a generic header is needed to add

[PATCH v5 0/2] introduce stub directory to storing empty/stub headers

A lot of empty/stub headers should be introduced during the early steps of adding support of new architecture. An example can be found here: 1. https://lore.kernel.org/xen-devel/[email protected]/ 2. https://lore.kernel.org/xen-devel/a92f99e8f697da99d77bfde562a549d

[linux-linus test] 182637: regressions - FAIL

flight 182637 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/182637/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 182531 test-amd64-amd64-xl

[PATCH v2] acpi/processor: sanitize _PDC buffer bits when running as Xen dom0

From: Roger Pau Monne The Processor _PDC buffer bits notify ACPI of the OS capabilities, and so ACPI can adjust the return of other Processor methods taking the OS capabilities into account. When Linux is running as a Xen dom0, it's the hypervisor the entity in charge of processor power manageme

[xen-unstable-smoke test] 182674: tolerable all pass - PUSHED

flight 182674 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182674/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[xen-unstable-smoke bisection] complete build-amd64

branch xen-unstable-smoke xenbranch xen-unstable-smoke job build-amd64 testid xen-build Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree

[ovmf test] 182665: all pass - PUSHED

flight 182665 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182665/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 4d196352f35ac516b477e568265b4e537b0283d8 baseline version: ovmf d1e4a16f868fb1ccfa8be

Re: [XEN PATCH] xen/types: address Rule 10.1 for macro BITS_TO_LONGS

On 06.09.2023 17:57, Nicola Vetrini wrote: > On 05/09/2023 10:33, Jan Beulich wrote: >> On 05.09.2023 10:20, Nicola Vetrini wrote: >>> On 05/09/2023 09:46, Jan Beulich wrote: On 05.09.2023 09:31, Nicola Vetrini wrote: > Given its use in the declaration > 'DECLARE_BITMAP(features, IOMMU

Re: [PATCH v4 1/2] xen: asm-generic support

On Fri, Sep 01, 2023 at 07:02:14PM +0300, Oleksii Kurochko wrote: > diff --git a/xen/Makefile b/xen/Makefile > index f57e5a596c..698d6ddeb8 100644 > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -667,6 +669,12 @@ endif # need-sub-make > PHONY += FORCE > FORCE: > > +# Support for using generic he

Re: [XEN PATCH] xen/types: address Rule 10.1 for macro BITS_TO_LONGS

On 05/09/2023 10:33, Jan Beulich wrote: On 05.09.2023 10:20, Nicola Vetrini wrote: On 05/09/2023 09:46, Jan Beulich wrote: On 05.09.2023 09:31, Nicola Vetrini wrote: Given its use in the declaration 'DECLARE_BITMAP(features, IOMMU_FEAT_count)' the argument 'bits' has essential type 'enum iommu

[xen-4.16-testing test] 182634: tolerable FAIL - PUSHED

flight 182634 xen-4.16-testing real [real] flight 182673 xen-4.16-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182634/ http://logs.test-lab.xenproject.org/osstest/logs/182673/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): t

Re: [PATCH v4 1/2] xen: asm-generic support

On Wed, Sep 06, 2023 at 01:03:32PM +, Bertrand Marquis wrote: > > On 6 Sep 2023, at 13:37, Oleksii wrote: > > On Mon, 2023-09-04 at 13:39 +, Bertrand Marquis wrote: > >>> diff --git a/xen/scripts/Makefile.asm-generic > >>> b/xen/scripts/Makefile.asm-generic > >>> new file mode 100644 > >>>

Re: [PATCH v2] MAINTAINERS: consolidate vm-event/monitor entry

On 06.09.2023 16:45, Anthony PERARD wrote: > On Wed, Sep 06, 2023 at 02:50:22PM +0200, Jan Beulich wrote: >> On 06.09.2023 14:40, Anthony PERARD wrote: >>> On Thu, Aug 31, 2023 at 08:15:13AM +0200, Jan Beulich wrote: If the F: description is to be trusted, the two xen/arch/x86/hvm/ lines

Re: [PATCH v4 1/2] xen: asm-generic support

On Wed, 2023-09-06 at 16:06 +0100, Anthony PERARD wrote: > On Wed, Sep 06, 2023 at 02:40:29PM +0200, Jan Beulich wrote: > > On 06.09.2023 14:28, Oleksii wrote: > > > On Wed, 2023-09-06 at 14:16 +0200, Jan Beulich wrote: > > > > You've removed quite a bit of functionality, comparing with the > > > >

Re: [XEN PATCH 1/2] xen: apply deviation for Rule 8.4 (asm-only definitions)

On 04/09/2023 10:09, Jan Beulich wrote: On 04.09.2023 09:19, Nicola Vetrini wrote: On 04/09/2023 09:02, Jan Beulich wrote: Further in the cover letter you say "Deviating variables needs more care, and is therefore postponed to another patch", yet then here you annotate a couple of variables a

Re: [PATCH v4 1/2] xen: asm-generic support

On Wed, Sep 06, 2023 at 02:40:29PM +0200, Jan Beulich wrote: > On 06.09.2023 14:28, Oleksii wrote: > > On Wed, 2023-09-06 at 14:16 +0200, Jan Beulich wrote: > >> You've removed quite a bit of functionality, comparing with the Linux > >> original. May I ask why that is? What they have all makes sens

Re: [PATCH v2] MAINTAINERS: consolidate vm-event/monitor entry

On Wed, Sep 06, 2023 at 02:50:22PM +0200, Jan Beulich wrote: > On 06.09.2023 14:40, Anthony PERARD wrote: > > On Thu, Aug 31, 2023 at 08:15:13AM +0200, Jan Beulich wrote: > >> If the F: description is to be trusted, the two xen/arch/x86/hvm/ > >> lines were fully redundant with the earlier wildcard

Re: [QEMU PATCH v4 09/13] virtio-gpu: Handle resource blob commands

On 2023/09/06 16:56, Huang Rui wrote: On Wed, Sep 06, 2023 at 11:39:09AM +0800, Akihiko Odaki wrote: On 2023/09/06 12:09, Huang Rui wrote: On Tue, Sep 05, 2023 at 05:20:43PM +0800, Akihiko Odaki wrote: On 2023/09/05 18:08, Huang Rui wrote: On Thu, Aug 31, 2023 at 06:24:32PM +0800, Akihiko Oda

[xen-unstable-smoke test] 182661: regressions - FAIL

flight 182661 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182661/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 182635 Tests which

[PATCH v1] tools/xentrace/xentrace_format: Add python 3 compatibility

Closes issue #155 Signed-off-by: Javi Merino --- Tested using the format file in tools/xentrace/formats. With this patch, both python2 and python3 produce the same output. tools/xentrace/xentrace_format | 63 +++--- 1 file changed, 36 insertions(+), 27 deletions(-

Re: [PATCH v4 1/2] xen: asm-generic support

Hi Oleksii, > On 6 Sep 2023, at 13:37, Oleksii wrote: > > Hello Bertrand > > On Mon, 2023-09-04 at 13:39 +, Bertrand Marquis wrote: >>> diff --git a/xen/scripts/Makefile.asm-generic >>> b/xen/scripts/Makefile.asm-generic >>> new file mode 100644 >>> index 00..0aac3f50b8 >>> --- /dev

Re: [PATCH v2] MAINTAINERS: consolidate vm-event/monitor entry

On 06.09.2023 14:40, Anthony PERARD wrote: > On Thu, Aug 31, 2023 at 08:15:13AM +0200, Jan Beulich wrote: >> If the F: description is to be trusted, the two xen/arch/x86/hvm/ >> lines were fully redundant with the earlier wildcard ones. Arch header >> files, otoh, were no longer covered by anything

Re: [PATCH v4 1/2] xen: asm-generic support

On 06.09.2023 14:28, Oleksii wrote: > On Wed, 2023-09-06 at 14:16 +0200, Jan Beulich wrote: >> On 01.09.2023 18:02, Oleksii Kurochko wrote: >>> --- /dev/null >>> +++ b/xen/scripts/Makefile.asm-generic >>> @@ -0,0 +1,23 @@ >>> +# SPDX-License-Identifier: GPL-2.0 >> >> While this is what the Linux fi

Re: [PATCH v2] MAINTAINERS: consolidate vm-event/monitor entry

On Thu, Aug 31, 2023 at 08:15:13AM +0200, Jan Beulich wrote: > If the F: description is to be trusted, the two xen/arch/x86/hvm/ > lines were fully redundant with the earlier wildcard ones. Arch header > files, otoh, were no longer covered by anything as of the move from > include/asm-*/ to arch/*/

Re: [XEN PATCH v3] drivers/video: make declarations of defined functions available

On 06.09.2023 14:36, Nicola Vetrini wrote: > On 05/09/2023 16:42, Jan Beulich wrote: >> On 01.09.2023 09:02, Nicola Vetrini wrote: >>> +#else >>> +#define vesa_early_init() ((void)0) >>> +#define vesa_endboot(x) ((void)0) >>> +static inline void vesa_init(void) {}; >> >> So why two #define-s and

Re: [XEN PATCH v3] drivers/video: make declarations of defined functions available

On 05/09/2023 16:42, Jan Beulich wrote: On 01.09.2023 09:02, Nicola Vetrini wrote: The declarations for 'vesa_{init,early_init,endboot}' needed by 'xen/drivers/video/vesa.c' and 'fill_console_start_info' in 'vga.c' are now available by moving the relative code inside 'vga.h'. While moving the c

Re: [PATCH v4 1/2] xen: asm-generic support

On Wed, 2023-09-06 at 14:16 +0200, Jan Beulich wrote: > On 01.09.2023 18:02, Oleksii Kurochko wrote: > > --- /dev/null > > +++ b/xen/scripts/Makefile.asm-generic > > @@ -0,0 +1,23 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > While this is what the Linux file presently says, you still want to > a

Re: [PATCH] tools/xl: Guard main_dt_overlay() with LIBXL_HAVE_DT_OVERLAY

On Wed, Sep 06, 2023 at 10:36:14AM +0200, Michal Orzel wrote: > main_dt_overlay() makes a call to libxl_dt_overlay() which is for now > only compiled for Arm. This causes the build failure as reported by > gitlab CI and OSSTEST. Fix it by guarding the function, prototype and > entry in cmd_table[]

Re: [PATCH v4 1/2] xen: asm-generic support

On 01.09.2023 18:02, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/scripts/Makefile.asm-generic > @@ -0,0 +1,23 @@ > +# SPDX-License-Identifier: GPL-2.0 While this is what the Linux file presently says, you still want to add "-only", which is merely the newer name for the same thing. > +# i

Re: [PATCH v4 1/2] xen: asm-generic support

Hello Bertrand On Mon, 2023-09-04 at 13:39 +, Bertrand Marquis wrote: > > diff --git a/xen/scripts/Makefile.asm-generic > > b/xen/scripts/Makefile.asm-generic > > new file mode 100644 > > index 00..0aac3f50b8 > > --- /dev/null > > +++ b/xen/scripts/Makefile.asm-generic > > @@ -0,0 +1,2

[XEN PATCH v2 1/2] xen: apply deviation for Rule 8.4 (asm-only definitions)

As stated in 'docs/misra/rules.rst' the functions that are used only by asm modules do not need to conform to MISRA C:2012 Rule 8.4. The deviations are carried out with a SAF comment. Signed-off-by: Nicola Vetrini --- Changes in v2: - Removed deviations on variables --- docs/misra/safe.json

[XEN PATCH v2 0/2] xen: deviate asm-only function definitions for Rule 8.4

As stated in 'docs/misra/rules.rst' the community decided to deviate from Rule 8.4 whereby the definitions concern entities that are only used in asm modules. The chosen deviation mechanism is that of textual deviations, through the use of /* SAF-n-safe */ comments. The deviation of variables is

[XEN PATCH v2 2/2] automation: execute SAF translation before the analysis with ECLAIR

This allows local MISRA deviation comments to be translated into the format recognized by ECLAIR. Signed-off-by: Nicola Vetrini --- automation/eclair_analysis/prepare.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/automation/eclair_analysis/prepare.sh b/automation/eclair_analysis/pre

[ovmf test] 182654: all pass - PUSHED

flight 182654 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182654/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d1e4a16f868fb1ccfa8bed8eaba5f9617ec8382d baseline version: ovmf f008890ae55929f7f17e7

Re: [PATCH v4 1/2] xen: asm-generic support

On Tue, 2023-09-05 at 14:10 +, Bertrand Marquis wrote: > Hi Oleksii, > > > On 5 Sep 2023, at 15:37, Oleksii > > wrote: > > > > Hi Bertrand, > > > > On Mon, 2023-09-04 at 13:39 +, Bertrand Marquis wrote: > > > Hi Oleksii, > > > > > > > On 1 Sep 2023, at 18:02, Oleksii Kurochko > > > >

[PATCH] xen/arm: Fix printk specifiers and arguments in iomem_remove_cb()

When building Xen for arm32 with CONFIG_DTB_OVERLAY, the following error is printed: common/dt-overlay.c: In function ‘iomem_remove_cb’: ././include/xen/config.h:55:24: error: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 3 has type ‘long unsigned int’ [-Werror=fo

[xen-4.15-testing test] 182633: regressions - FAIL

flight 182633 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/182633/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-migrupgrade 10 xen-install/src_host fail REGR. vs. 182235 test-amd64-i38

Re: [PATCH 3/3] sysemu/xen: Allow elision of xen_hvm_modified_memory()

On 05.09.23 14:21, Philippe Mathieu-Daudé wrote: Call xen_enabled() before xen_hvm_modified_memory() to let the compiler elide its call. Have xen_enabled() return a boolean to match its declaration in the CONFIG_XEN_IS_POSSIBLE case. Suggested-by: Daniel Henrique Barboza Signed-off-by: Philipp

Re: [PATCH] OvmfPkg/OvmfXen: Fix S3

On Thu, 13 Jul 2023 at 12:48, Xenia Ragiadakou wrote: > > Currently, resuming an S3 suspended guest results in the following > assertion failure: > ASSERT > MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.c(41): > MemoryLength > 0 > This happens because some parts of the S3 su

[xen-unstable-smoke test] 182646: regressions - FAIL

flight 182646 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182646/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 182635 Tests which

[XEN PATCH 2/4] x86/io: address violations of MISRA C:2012 Rule 8.3

Make declarations consistent, no functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/include/asm/io.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/include/asm/io.h b/xen/arch/x86/include/asm/io.h index 92b784a861..8c8a15bd06 100644 --- a/xen/a

[XEN PATCH 0/4] xen/x86: address some violations of MISRA C:2012 Rules 8.2 and 8.3

This serie addresses some violations of MISRA C:2012 Rules 8.2 and 8.3 for x86-64. Federico Serafini (4): x86/genapic: address a violation of MISRA C:2012 Rule 8.3 x86/io: address violations of MISRA C:2012 Rule 8.3 x86/io_apic: address violations of MISRA C:2012 Rules 8.2 and 8.3 xen/vpci

[XEN PATCH 3/4] x86/io_apic: address violations of MISRA C:2012 Rules 8.2 and 8.3

Add missing parameter names and make function declarations and definitions consistent. No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/include/asm/io_apic.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/include/asm/io_apic.h b/xen/

[XEN PATCH 4/4] xen/vpci: address a violation of MISRA C:2012 Rule 8.3

Make function declarations and definitions consistent. No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/include/asm/hap.h | 2 +- xen/include/xen/vpci.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/include/asm/hap.h b/xen/arch

[XEN PATCH 1/4] x86/genapic: address a violation of MISRA C:2012 Rule 8.3

Make function delcaration consistent with the corresponding definition. No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/include/asm/genapic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/include/asm/genapic.h b/xen/arch/x86/include/asm

Re: [PATCH] tools/xl: Guard main_dt_overlay() with LIBXL_HAVE_DT_OVERLAY

On 06/09/2023 10:42, Jan Beulich wrote: > > > On 06.09.2023 10:36, Michal Orzel wrote: >> main_dt_overlay() makes a call to libxl_dt_overlay() which is for now >> only compiled for Arm. This causes the build failure as reported by >> gitlab CI and OSSTEST. Fix it by guarding the function, prot

Re: [PATCH] tools/xl: Guard main_dt_overlay() with LIBXL_HAVE_DT_OVERLAY

On 06.09.2023 10:36, Michal Orzel wrote: > main_dt_overlay() makes a call to libxl_dt_overlay() which is for now > only compiled for Arm. This causes the build failure as reported by > gitlab CI and OSSTEST. Fix it by guarding the function, prototype and > entry in cmd_table[] using LIBXL_HAVE_DT_O

[PATCH] tools/xl: Guard main_dt_overlay() with LIBXL_HAVE_DT_OVERLAY

main_dt_overlay() makes a call to libxl_dt_overlay() which is for now only compiled for Arm. This causes the build failure as reported by gitlab CI and OSSTEST. Fix it by guarding the function, prototype and entry in cmd_table[] using LIBXL_HAVE_DT_OVERLAY. This has an advantage over regular Arm gu

Re: [XEN][PATCH v12 20/20] tools/xl: Add new xl command overlay for device tree overlay support

On 06.09.2023 10:06, Michal Orzel wrote: > > > On 06/09/2023 09:57, Jan Beulich wrote: >> >> >> On 06.09.2023 09:32, Michal Orzel wrote: >>> >>> >>> On 06/09/2023 08:55, Jan Beulich wrote: On 06.09.2023 03:16, Vikram Garhwal wrote: > --- a/tools/xl/xl_vmcontrol.c > +++ b/to

Re: [PATCH v5 4/5] xen/vpci: header: status register handler

On 01.09.2023 06:57, Stewart Hildebrand wrote: > Introduce a handler for the PCI status register, with ability to mask the > capabilities bit. The status register contains reserved bits, read-only bits, > and write-1-to-clear bits, so introduce bitmasks to handle these in vPCI. If a > bit in the bi

Re: [XEN][PATCH v12 20/20] tools/xl: Add new xl command overlay for device tree overlay support

On 06/09/2023 09:57, Jan Beulich wrote: > > > On 06.09.2023 09:32, Michal Orzel wrote: >> >> >> On 06/09/2023 08:55, Jan Beulich wrote: >>> >>> >>> On 06.09.2023 03:16, Vikram Garhwal wrote: --- a/tools/xl/xl_vmcontrol.c +++ b/tools/xl/xl_vmcontrol.c @@ -1265,6 +1265,58 @@ int m

Re: [PATCH v5 3/5] xen/pci: update PCI_STATUS_* constants

On 01.09.2023 06:57, Stewart Hildebrand wrote: > Interrupt status introduced in PCI 2.3 > Immediate readiness introduced in PCIe 4.0 > > Signed-off-by: Stewart Hildebrand Reviewed-by: Jan Beulich

Re: [XEN][PATCH v12 20/20] tools/xl: Add new xl command overlay for device tree overlay support

On 06.09.2023 09:32, Michal Orzel wrote: > > > On 06/09/2023 08:55, Jan Beulich wrote: >> >> >> On 06.09.2023 03:16, Vikram Garhwal wrote: >>> --- a/tools/xl/xl_vmcontrol.c >>> +++ b/tools/xl/xl_vmcontrol.c >>> @@ -1265,6 +1265,58 @@ int main_create(int argc, char **argv) >>> return 0; >>>

Re: [QEMU PATCH v4 09/13] virtio-gpu: Handle resource blob commands

On Wed, Sep 06, 2023 at 11:39:09AM +0800, Akihiko Odaki wrote: > On 2023/09/06 12:09, Huang Rui wrote: > > On Tue, Sep 05, 2023 at 05:20:43PM +0800, Akihiko Odaki wrote: > >> On 2023/09/05 18:08, Huang Rui wrote: > >>> On Thu, Aug 31, 2023 at 06:24:32PM +0800, Akihiko Odaki wrote: > On 2023/08

Re: [XEN PATCH 09/13] xen/common: address violations of MISRA C:2012 Directive 4.10

On 06/09/23 00:18, Stefano Stabellini wrote: On Thu, 31 Aug 2023, Simone Ballarin wrote: On 31/08/23 15:05, Jan Beulich wrote: On 31.08.2023 14:54, Simone Ballarin wrote: On 31/08/23 13:10, Jan Beulich wrote: On 31.08.2023 12:08, Simone Ballarin wrote: The danger of multi-inclusion also exis

Re: [XEN][PATCH v12 20/20] tools/xl: Add new xl command overlay for device tree overlay support

On 06/09/2023 08:55, Jan Beulich wrote: > > > On 06.09.2023 03:16, Vikram Garhwal wrote: >> --- a/tools/xl/xl_vmcontrol.c >> +++ b/tools/xl/xl_vmcontrol.c >> @@ -1265,6 +1265,58 @@ int main_create(int argc, char **argv) >> return 0; >> } >> >> +int main_dt_overlay(int argc, char **argv)