Re: [PATCH] public/io: xs_wire: Allow Xenstore to report EPERM

2022-06-26 Thread Jan Beulich
On 24.06.2022 18:51, Julien Grall wrote: > --- a/xen/include/public/io/xs_wire.h > +++ b/xen/include/public/io/xs_wire.h > @@ -76,6 +76,7 @@ static struct xsd_errors xsd_errors[] > __attribute__((unused)) > #endif > = { > +XSD_ERROR(EPERM), > XSD_ERROR(EINVAL), > XSD_ERROR(EACC

Re: [PATCH 4/7] xen/arm: mm: Add more ASSERT() in {destroy, modify}_xen_mappings()

2022-06-26 Thread Michal Orzel
Hi Julien, On 24.06.2022 11:11, Julien Grall wrote: > From: Julien Grall > > Both destroy_xen_mappings() and modify_xen_mappings() will take in > parameter a range [start, end[. Both end should be page aligned. > > Add extra ASSERT() to ensure start and end are page aligned. Take the > opportun

Re: [PATCH 3/7] xen/arm: head: Add missing isb after writing to SCTLR_EL2/HSCTLR

2022-06-26 Thread Michal Orzel
Hi Julien, On 24.06.2022 11:11, Julien Grall wrote: > From: Julien Grall > > Write to SCTLR_EL2/HSCTLR may not be visible until the next context > synchronization. When initializing the CPU, we want the update to take > effect right now. So add an isb afterwards. > > Spec references: > - AA

Re: [PATCH 2/2] x86/P2M: allow 2M superpage use for shadowed guests

2022-06-26 Thread Jan Beulich
On 24.06.2022 21:27, George Dunlap wrote: > > >> On 9 Dec 2021, at 11:27, Jan Beulich wrote: >> >> For guests in shadow mode the P2M table gets used only by software. The >> only place where it matters whether superpages in the P2M can be dealt >> with is sh_unshadow_for_p2m_change(). > > It’s

Re: [PATCH 2/7] xen/arm32: head.S: Introduce a macro to load the physical address of a symbol

2022-06-26 Thread Michal Orzel
Hi Julien, On 24.06.2022 11:11, Julien Grall wrote: > From: Julien Grall > > A lot of places in the ARM32 assembly requires to load the physical address > of a symbol. Rather than open-coding the translation, introduce a new macro > that will load the phyiscal address of a symbol. > > Lastly, u

Re: [PATCH 1/2] x86/shadow: slightly consolidate sh_unshadow_for_p2m_change()

2022-06-26 Thread Jan Beulich
On 24.06.2022 21:16, George Dunlap wrote: > > >> On 9 Dec 2021, at 11:26, Jan Beulich wrote: >> >> In preparation for reactivating the presently dead 2M page path of the >> function, >> - also deal with the case of replacing an L1 page table all in one go, >> - pull common checks out of the swit

Re: [PATCH 1/7] xen/arm: Remove most of the *_VIRT_END defines

2022-06-26 Thread Michal Orzel
Hi Julien, On 24.06.2022 11:11, Julien Grall wrote: > From: Julien Grall > > At the moment, *_VIRT_END may either point to the address after the end > or the last address of the region. > > The lack of consistency make quite difficult to reason with them. > > Furthermore, there is a risk of ov

[ovmf test] 171365: all pass - PUSHED

2022-06-26 Thread osstest service owner
flight 171365 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171365/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 7f4eca4cc2e01d4160ef265f477f9d098d7d33df baseline version: ovmf b600f253b307794390843

[PATCH] xen/arm: avoid extra caclulations when setting vtimer in context switch

2022-06-26 Thread Jiamei Xie
virt_vtimer_save is calculating the new time for the vtimer in: "v->arch.virt_timer.cval + v->domain->arch.virt_timer_base.offset - boot_count". In this formula, "cval + offset" might cause uint64_t overflow. Changing it to "v->domain->arch.virt_timer_base.offset - boot_count + v->arch.virt_timer.c

[ovmf test] 171362: all pass - PUSHED

2022-06-26 Thread osstest service owner
flight 171362 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171362/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b600f253b3077943908431cd780dbc1a9ed1bc81 baseline version: ovmf 15b25045e6db2c82bc129

[linux-linus test] 171361: regressions - FAIL

2022-06-26 Thread osstest service owner
flight 171361 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171361/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-intel 8 xen-bootfail REGR. vs. 171277 test-amd64-amd64-xl

[PATCH 5/5] xen/arm64: traps: Fix MISRA C 2012 Rule 8.4 violations

2022-06-26 Thread Xenia Ragiadakou
Add a function prototype for do_bad_mode() in and include header in traps.c, so that the declarations of the functions do_bad_mode() and finalize_instr_emulation(), which have external linkage, are visible before the function definitions. Signed-off-by: Xenia Ragiadakou --- xen/arch/arm/arm64/

[PATCH 4/5] xen/sched: credit: Fix MISRA C 2012 Rule 8.7 violation

2022-06-26 Thread Xenia Ragiadakou
The per-cpu variable last_tickle_cpu is referenced only in credit.c. Change its linkage from external to internal by adding the storage-class specifier static to its definitions. This patch aims to resolve indirectly a MISRA C 2012 Rule 8.4 violation warning. Signed-off-by: Xenia Ragiadakou ---

[PATCH 3/5] xen/drivers: iommu: Fix MISRA C 2012 Rule 8.7 violation

2022-06-26 Thread Xenia Ragiadakou
The variable iommu_crash_disable is referenced only in one translation unit. Change its linkage from external to internal by adding the storage-class specifier static to its definition. This patch aims to resolve indirectly a MISRA C 2012 Rule 8.4 violation warning. Signed-off-by: Xenia Ragiadako

[PATCH 2/5] xen/common: vm_event: Fix MISRA C 2012 Rule 8.7 violation

2022-06-26 Thread Xenia Ragiadakou
The function vm_event_wake() is referenced only in vm_event.c. Change the linkage of the function from external to internal by adding the storage-class specifier static to the function definition. This patch aims to resolve indirectly a MISRA C 2012 Rule 8.4 violation warning. Signed-off-by: Xeni

[PATCH 0/5] Fix MISRA C 2012 violations

2022-06-26 Thread Xenia Ragiadakou
Resolve MISRA C 2012 Rule 8.4 warnings. Xenia Ragiadakou (5): xen/common: page_alloc: Fix MISRA C 2012 Rule 8.7 violation xen/common: vm_event: Fix MISRA C 2012 Rule 8.7 violation xen/drivers: iommu: Fix MISRA C 2012 Rule 8.7 violation xen/sched: credit: Fix MISRA C 2012 Rule 8.7 violation

[PATCH 1/5] xen/common: page_alloc: Fix MISRA C 2012 Rule 8.7 violation

2022-06-26 Thread Xenia Ragiadakou
The variables page_offlined_list and page_broken_list are referenced only in page_alloc.c. Change their linkage from external to internal by adding the storage-class specifier static to their definitions. This patch aims to resolve indirectly a MISRA C 2012 Rule 8.4 violation warning. Signed-off-

[PATCH 2/2] uboot-script-gen: do not enable direct mapping by default

2022-06-26 Thread Xenia Ragiadakou
To be inline with XEN, do not enable direct mapping automatically for all statically allocated domains. Signed-off-by: Xenia Ragiadakou --- README.md| 4 ++-- scripts/uboot-script-gen | 8 ++-- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/README.md b/README.

[PATCH 1/2] uboot-script-gen: prevent user mistakes due to DOM0_KERNEL becoming optional

2022-06-26 Thread Xenia Ragiadakou
Before enabling true dom0less configuration, the script was failing instantly if DOM0_KERNEL parameter was not specified. This behaviour has changed and this needs to be communicated to the user. Mention in README.md that for dom0less configurations, the parameter DOM0_KERNEL is optional. If DOM0

Re: [PATCH 2/2] hw/i386/xen/xen-hvm: Inline xen_piix_pci_write_config_client() and remove it

2022-06-26 Thread Michael S. Tsirkin
On Sun, Jun 26, 2022 at 11:46:56AM +0200, Bernhard Beschow wrote: > xen_piix_pci_write_config_client() is implemented in the xen sub tree and > uses PIIX constants internally, thus creating a direct dependency on > PIIX. Now that xen_set_pci_link_route() is stubbable, the logic of > xen_piix_pci_wr

[xen-unstable test] 171357: tolerable FAIL

2022-06-26 Thread osstest service owner
flight 171357 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171357/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-rtds 18 guest-localmigrate fail pass in 171355 Tests which did not succeed, but

[PATCH 0/2] Decouple Xen-HVM from PIIX

2022-06-26 Thread Bernhard Beschow
hw/i386/xen/xen-hvm.c contains logic which is PIIX-specific. This makes xen-hvm.c depend on PIIX which can be avoided if PIIX logic was isolated in PIIX itself. Bernhard Beschow (2): hw/i386/xen/xen-hvm: Allow for stubbing xen_set_pci_link_route() hw/i386/xen/xen-hvm: Inline xen_piix_pci_wri

[PATCH 1/2] hw/i386/xen/xen-hvm: Allow for stubbing xen_set_pci_link_route()

2022-06-26 Thread Bernhard Beschow
The only user of xen_set_pci_link_route() is xen_piix_pci_write_config_client() which implements PIIX-specific logic in the xen namespace. This makes xen-hvm depend on PIIX which could be avoided if xen_piix_pci_write_config_client() was implemented in PIIX. In order to do this, xen_set_pci_link_ro

[PATCH 2/2] hw/i386/xen/xen-hvm: Inline xen_piix_pci_write_config_client() and remove it

2022-06-26 Thread Bernhard Beschow
xen_piix_pci_write_config_client() is implemented in the xen sub tree and uses PIIX constants internally, thus creating a direct dependency on PIIX. Now that xen_set_pci_link_route() is stubbable, the logic of xen_piix_pci_write_config_client() can be moved to PIIX which resolves the dependency. S

[libvirt test] 171358: regressions - FAIL

2022-06-26 Thread osstest service owner
flight 171358 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171358/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt