Re: [PATCH 3/4] wined3d: fix texm3x3spec coordinate mask bug

2010-04-28 Thread Roderick Colenbrander
gets this from the texture). This makes me believe the patch is fine unless the call which retrieves this info from the texture is wrong but I doubt it is wrong but if you want I can look closer to that. Roderick On Wed, Apr 28, 2010 at 2:54 PM, Henri Verbeet wrote: > On 28 April 20

Re: [PATCH 4/4] wined3d: use stretch_rect_fbo for swapchainless blits

2010-04-29 Thread Roderick Colenbrander
On Wed, Apr 28, 2010 at 2:56 PM, Henri Verbeet wrote: > On 28 April 2010 14:29, Roderick Colenbrander wrote: >> +    /* Early sort out of cases where no render target is used */ >> +    if (!dstSwapchain && !srcSwapchain >> +            && sr

Re: 3dmark2000, 3dmark06 results on both Wine and Vista

2010-05-02 Thread Roderick Colenbrander
When doing such benchmarks also try to write down the frame rates of the individual tests. The 3dmark score is some sort of weighted average (the result of the cpu test in it is also quite important). >From what I remember the scores in 2000/2001/2003 were actually good but 2005/2006 used to be qui

Re: Compilation failure in wine-1.1.44

2010-05-08 Thread Roderick Colenbrander
Yeah the -O0 bug was reported on #winehackers yesterday and will likely be fixed soon. Compiling using -O2 (which is what you should use by default anyway unless you have very good reasons not to) should work fine. Roderick On Sat, May 8, 2010 at 2:33 PM, wrote: > > Hi guys, i can't compile win

Re: today's performance results

2010-05-11 Thread Roderick Colenbrander
On Tue, May 11, 2010 at 7:27 AM, Dan Kegel wrote: > http://kegel.com/wine/yagmarkdata/wine-1.1.44-19-vs-wine-1.1.44-72.txt > shows yesterday's wine's performance compared to today's. > Highlights: > Comparing wine-1.1.44-19 with wine-1.1.44-72 > benchmark_variable        wine-1.1.44-19 wine-1.1.44

Re: today's performance results

2010-05-11 Thread Roderick Colenbrander
Setting the clocks must be performed using the gui. You need to have the Coolbits option in your xorg.conf. It reminds me to still update nvclock which can do this from cli fine ;) Roderick On Tue, May 11, 2010 at 3:45 PM, Dan Kegel wrote: > On Tue, May 11, 2010 at 1:27 AM, Roder

Re: Work on WineQuartz for MacOSX

2010-05-16 Thread Roderick Colenbrander
The fact that Cocoa is objective C is one of the issues (Charles Davis made some C wrapper I think). The most problematic thing is that it really need is a DIB engine. The Cocoa graphics APIs are similar to Cairo / XRender / Direct2D and other modern APIs. These APIs are great for vector drawing, a

Re: [PATCH 4/4] wined3d: add BLIT_OP_COMPLEX_UPLOAD

2010-05-17 Thread Roderick Colenbrander
On Mon, May 17, 2010 at 1:29 PM, Henri Verbeet wrote: > On 17 May 2010 13:11, Roderick Colenbrander wrote: >> This patch introduces a new blit operation to allow complex uploads from >> LoadLocation. It allows hw accelerated >> p8 uploads to function again (I broke them

Re: [PATCH 1/4] wined3d: only activate blit_shader in arbfp_blit_surface for source fixups

2010-05-18 Thread Roderick Colenbrander
On Tue, May 18, 2010 at 9:56 AM, Henri Verbeet wrote: > On 18 May 2010 09:30, Roderick Colenbrander wrote: >> -    arbfp_blit_set((IWineD3DDevice *)device, src_surface); >> +    if (is_complex_fixup(src_surface->resource.format_desc->color_fixup) && >> +  

Re: [PATCH 3/4] wined3d: allow complex -> complex blits in arbfp blit_shader under special circumstances

2010-05-18 Thread Roderick Colenbrander
>> +        && (dst_usage & WINED3DUSAGE_RENDERTARGET)) > What is that condition for? For a part it was meant to disable sysmem -> sysmem copies using the arbfp blit_shader (but that should be done in general, so outside this check). I wasn't sure whether dst_pool == D3DPOOL_DEFAULT would be safe

Re: [PATCH 1/4] wined3d: only activate blit_shader in arbfp_blit_surface for source fixups

2010-05-18 Thread Roderick Colenbrander
On Tue, May 18, 2010 at 10:58 AM, Henri Verbeet wrote: > On 18 May 2010 10:45, Roderick Colenbrander wrote: >> isn't right since set_shader does useful things as well like >> glEnable(tex_type). > Yeah. In the bigger picture it's also slightly insane that we have a

Re: Work on WineQuartz for MacOSX

2010-05-18 Thread Roderick Colenbrander
On Tue, May 18, 2010 at 3:12 PM, Mike Kronenberg wrote: > On 17.05.2010, at 07:52, Charles Davis wrote: > >> On 5/16/10 9:04 PM, James Mckenzie wrote: >>> Roderick Colenbrander wrote: >>>> On Sun, May 16, 2010 at 6:02 PM, C.W. Betts >>>> wrote: >

Re: Nightly performance regression graphs

2010-05-18 Thread Roderick Colenbrander
On Tue, May 18, 2010 at 2:42 PM, Dan Kegel wrote: > On Tue, May 18, 2010 at 3:07 AM, Scott Ritchie wrote: >> > http://kegel.com/wine/yagmarkdata/wine-1.1.44-245.html >> >> What tool are you using to make them? > > gnuplot.  The script (if you can call it that) I use is at > http://code.google.com

Re: [PATCH 0/7] wined3d: blit set_shader texture_target activation cleanup

2010-05-19 Thread Roderick Colenbrander
>> At a later stage I might disallow calling set_shader when we don't need the >> shader. > How does the caller know when a shader is needed? > In the end set_shader will only be called by blit_shader->blit_surface. The main issue I'm facing is p8 uploads which are completely broken right now (a

Re: [PATCH 0/7] wined3d: blit set_shader texture_target activation cleanup

2010-05-19 Thread Roderick Colenbrander
On Wed, May 19, 2010 at 11:30 AM, Roderick Colenbrander wrote: >>> At a later stage I might disallow calling set_shader when we don't need the >>> shader. >> How does the caller know when a shader is needed? >> > > In the end set_shader will only be cal

Re: [PATCH 0/7] wined3d: blit set_shader texture_target activation cleanup

2010-05-19 Thread Roderick Colenbrander
On Wed, May 19, 2010 at 7:02 PM, Henri Verbeet wrote: > On 19 May 2010 14:46, Roderick Colenbrander wrote: >>> The main issue I'm facing is p8 uploads which are completely broken >>> right now (a regression). At the beginning of the week I wanted to add > ... >&g

Re: Voting for own bugs not allowed?

2010-05-25 Thread Roderick Colenbrander
On Tue, May 25, 2010 at 8:46 AM, Florian Köberle wrote: > Hello, > > just someone informed me that I MUST NOT vote for my own bugs. Is there > a reason for it? > I think it is disallowed because self promotion can make an app more important while only few people may use it. To be honest I would

Re: [PATCH 0/7] wined3d: blit set_shader texture_target activation cleanup

2010-05-26 Thread Roderick Colenbrander
On Wed, May 19, 2010 at 8:27 PM, Roderick Colenbrander wrote: > On Wed, May 19, 2010 at 7:02 PM, Henri Verbeet wrote: >> On 19 May 2010 14:46, Roderick Colenbrander wrote: >>>> The main issue I'm facing is p8 uploads which are completely broken >>>> right n

Re: Building a CUDA 3.0 dll wrapper, compile errors

2010-05-30 Thread Roderick Colenbrander
> winegcc -shared cudart.dll.spec -mno-cygwin -o cudart.dll.so cudart.o > -L/usr/local/cuda/lib/ -lcudart   -lodbc32 -lole32 -loleaut32 -lwinspool > -lodbccp32 -luuid > cudart.o: In function `__saturatef': > cudart.c:(.text+0x3b6c): undefined reference to `__cuda___isnanf' > cudart.o: In function `

Re: Allowed reverse engineering methods

2010-05-30 Thread Roderick Colenbrander
>> But which methods are allowed? I assume that "obvious" >> methods (reading header files, registry dumps, etc.) are >> acceptable, but can I e.g. analyze .pdb symbol files >> (availble in e.g. Microsoft's DirectX SDK)? >> >> > > You can do the above as long as they are readily available.   The .p

Re: GPU driver version reporting

2010-06-02 Thread Roderick Colenbrander
On Wed, Jun 2, 2010 at 5:20 AM, Albert Lee wrote: > On Wed, 2 Jun 2010 03:14:34 +, Seth Shelnutt > wrote: >> I am trying to get folding at home gpu client working. The issue we are >> having now is that it detects the driver version and says it is not >> right, and it won't proceed. I've sear

Re: GPU driver version reporting

2010-06-02 Thread Roderick Colenbrander
On Wed, Jun 2, 2010 at 5:03 PM, Seth Shelnutt wrote: > Is there any reason that across all files we don't report the same driver > version? Does windows not do this? Maybe it'd be easier to keep the code in > wined3d and just have user32 and such call for the driver details? I haven't > looked at

Re: gameux: Add declaration of IGameExplorer2 interface

2010-06-02 Thread Roderick Colenbrander
2010/6/2 Mariusz Pluciński : > You're right, but I thought about numbering too late, when > I noticed my patches appeared in wrong order. > > I attached configure files, cause they're part of main > tree. I though, that if they're intended to being generated, > they would already be listed in .giti

Xinput / DirectInput xbox360 controller support

2010-06-16 Thread Roderick Colenbrander
Hi all, I'm interested in adding Xbox 360 controller support to Wine. For people who don't know how this works and what's so special I will first give a small introduction. The Xbox 360 controller is a normal USB device which you can use from 'xinput*.dll' (typically xinput1_3.dll is used). The x

Re: Wine on cygwin now compiles!

2010-06-16 Thread Roderick Colenbrander
I don't expect Wine itself to ever work on cygwin. Last year I asked AJ about it and there are some special file handle features which are needed. This stuff is supported in SUA but at least in the Vista version this was broken. They MIGHT have fixed it for Win7, so if Wine can work on Windows it w

Re: Xinput / DirectInput xbox360 controller support

2010-06-16 Thread Roderick Colenbrander
On Wed, Jun 16, 2010 at 11:42 PM, Alexandre Julliard wrote: > Roderick Colenbrander writes: > >> I'm wondering how to proceed with XInput. My main issue is the >> 'joystick access part'. Would it be fine to directly access the >> controller from Xin

wined3d: Add NPOT quirk for GeforceFX 5200

2010-06-17 Thread Roderick Colenbrander
From 3d19821425c857801abd51233ad01a2b6d436a5d Mon Sep 17 00:00:00 2001 From: Roderick Colenbrander Date: Mon, 14 Jun 2010 23:22:52 +0200 Subject: [PATCH] wined3d: Add NPOT quirk for GeforceFX 5200 This should fix bug 23169. --- dlls/wined3d/directx.c |4 +++- 1 files changed, 3 insertions

Re: Xinput / DirectInput xbox360 controller support

2010-06-17 Thread Roderick Colenbrander
On Thu, Jun 17, 2010 at 7:03 PM, Vitaliy Margolen wrote: > On 06/16/2010 12:59 PM, Roderick Colenbrander wrote: >> I'm wondering how to proceed with XInput. My main issue is the >> 'joystick access part'. Would it be fine to directly access the >> controller fr

Re: The __WINE__ macro does not identify the Wine platform

2010-06-18 Thread Roderick Colenbrander
On Fri, Jun 18, 2010 at 6:43 PM, Austin English wrote: > On Fri, Jun 18, 2010 at 11:37 AM, Alan W. Irwin > wrote: >>> If what you want is to add workarounds for Wine in your code, then >>> neither __WINE__ nor the build platform matter. What matters is the >>> platform your code is currently runn

Re: [PATCH 4/4] wined3d: use stretch_rect_fbo for swapchainless blits

2010-06-22 Thread Roderick Colenbrander
On Wed, Apr 28, 2010 at 2:56 PM, Henri Verbeet wrote: > On 28 April 2010 14:29, Roderick Colenbrander wrote: >> +    /* Early sort out of cases where no render target is used */ >> +    if (!dstSwapchain && !srcSwapchain >> +            && sr

Re: Porting Applications

2010-06-22 Thread Roderick Colenbrander
Hi, It is certainly nice that a company offers support for this. Last year I did something even cooler and it doesn't require much effort. I used Visual Studio itself to remotely debug on Wine. I'm not sure if I used native dbghelp.dll or not (I think I didn't use it). The only thing I needed for

Re: xinput1_3: Quiet a noisy fixme

2010-07-05 Thread Roderick Colenbrander
Yeah, this is the correct fix for this horribly broken API (did quite a bit of xinput hacking recently). There is no call to query what joysticks are available since the API was designed to allow you to plug in a joystick while you are playing a game. Games just use XInputGetState (which retrieves

Re: List of Video cards in directx.c

2010-07-10 Thread Roderick Colenbrander
On Sat, Jul 10, 2010 at 6:30 PM, Seth Shelnutt wrote: > > > On Sat, Jul 10, 2010 at 3:57 PM, Henri Verbeet wrote: >> >> What kind of issue? (Just curious.) >> >  Well a 8300 isn't cuda capable, and even with the forcegpu nvidia_g80 flag, > wine still makes the client think it's an 8300 not an 850

Re: wined3d/directx.c: Corrected Nvidia 8400 and 8500 reporting

2010-07-12 Thread Roderick Colenbrander
Hi Seth, It is not a good idea to advertise a 8400 and a 8500 as a 8600GT. All Geforce8 GPUs have the same features (except, some have different purevideo capabilities). As mentioned before even CUDA is allowed on all GPUs but only if they have 256MB or more. Likely the app you are using either d

Re: wined3d/directx.c: Corrected Nvidia 8400 and 8500 reporting

2010-07-12 Thread Roderick Colenbrander
issue we are having now. > > > Thanks, > > Seth Shelnutt > > On Mon, Jul 12, 2010 at 2:51 PM, Roderick Colenbrander > wrote: >> >> Hi Seth, >> >> It is not a good idea to advertise a 8400 and a 8500 as a 8600GT. All >> Geforce8 GPUs have the s

Re: D3DXCreateTeapot and reverse engineering?

2010-07-18 Thread Roderick Colenbrander
On Sun, Jul 18, 2010 at 11:05 AM, Misha Koshelev wrote: > Dear All: > > I just wanted to double check before I do anything with > D3DXCreateTeapot. > > I have several options for implementing this: > > Option A > > One, the slightly harder option, involves the original dataset: > http://w

Re: D3DXCreateTeapot and reverse engineering?

2010-07-18 Thread Roderick Colenbrander
On Sun, Jul 18, 2010 at 11:58 PM, Misha Koshelev wrote: > On Sun, 2010-07-18 at 14:37 -0700, Dan Kegel wrote: >> IMHO, our criterion is "we only need to implement what apps really need", >> and for the moment, that app probably could live with a stub for >> D3DXCreateTeapot.   When we run into a c

Re: wined3d: Add Nvidia 8800GTX detection

2010-07-20 Thread Roderick Colenbrander
On Tue, Jul 20, 2010 at 1:54 PM, Henri Verbeet wrote: > On 20 July 2010 15:49, Luke Bratch wrote: >> Adds detection for the Nvidia 8800GTX card and sets its video memory >> correctly. >> >> I have sent this patch in the past but it got rejected, as this method of >> calculating video card type/

Re: wined3d: Add Nvidia 8800GTX detection

2010-07-20 Thread Roderick Colenbrander
On Tue, Jul 20, 2010 at 11:54 PM, Luke Bratch wrote: > --- On Tue, 20/7/10, Henri Verbeet wrote: > >> Negative on using experimental extensions I'm afraid. >> Writing a proof >> of concept patch is ok, of course, and I'd be willing to >> review that, >> but it can't go in until the extension is f

Re: wined3d: Add Nvidia 8800GTX detection

2010-07-20 Thread Roderick Colenbrander
On Wed, Jul 21, 2010 at 1:57 AM, Seth Shelnutt wrote: > For ati there is also GL_ATI_mem_info [1] or WGL_AMD_gpu_association [2] . I > believe that [1] is now obsolete as from reading some of the wine-dev > mailing list [3], and some other site it seems AMD is now pushing the using > of WGL_AMD_gp

Re: wined3d: Add Nvidia 8800GTX detection

2010-07-20 Thread Roderick Colenbrander
On Wed, Jul 21, 2010 at 3:59 AM, Roderick Colenbrander wrote: > On Tue, Jul 20, 2010 at 11:54 PM, Luke Bratch wrote: >> --- On Tue, 20/7/10, Henri Verbeet wrote: >> >>> Negative on using experimental extensions I'm afraid. >>> Writing a proof >>>

Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces.

2010-07-20 Thread Roderick Colenbrander
2010/7/20 Oldřich Jedlička : > Hi Stefan, > > On Tuesday 20 July 2010 00:01:13 Stefan Dösinger wrote: >> Am 19.07.2010 um 21:24 schrieb Oldřich Jedlička: >> > Hi Stefan, >> > >> > On Monday 19 July 2010 20:56:35 Stefan Dösinger wrote: >> >> Allowing the creation of the surface is most likely not en

Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces.

2010-07-20 Thread Roderick Colenbrander
2010/7/20 Roderick Colenbrander : > 2010/7/20 Oldřich Jedlička : >> Hi Stefan, >> >> On Tuesday 20 July 2010 00:01:13 Stefan Dösinger wrote: >>> Am 19.07.2010 um 21:24 schrieb Oldřich Jedlička: >>> > Hi Stefan, >>> > >>> > On Monda

Re: wined3d: Add Nvidia 8800GTX detection

2010-07-21 Thread Roderick Colenbrander
On Wed, Jul 21, 2010 at 4:02 AM, Henri Verbeet wrote: > On 21 July 2010 05:08, Roderick Colenbrander wrote: >> I think 'select_card_*' should just return the pci device id and the >> default amount of video memory should be stored in lets say the driver >> version

Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces. (try 2)

2010-07-21 Thread Roderick Colenbrander
Hi Oldřich, Not to discourage you, but in Wine tests serve as proof to show that a patch is right, so you should first get all the tests you want in. The bug should be fixed afterward. It is likely that the test will reveal new issues. Like I mentioned yesterday, checking memory location related

Re: [PATCH 3/4] ddraw: Allow creating back buffer for pre-DirectX 7 interfaces. (try 3)

2010-07-22 Thread Roderick Colenbrander
On Thu, Jul 22, 2010 at 10:14 PM, Stefan Dösinger wrote: > > Am 22.07.2010 um 21:13 schrieb Oldřich Jedlička: > >> DirectX 1 interface allowed creation of explicit back buffers, so move the >> restrictive checks to DirectX 2+ implementations. > It is still missing testing/handling of AddAttachedSu

Re: [PATCH 1/4] wined3d: separate driver info from GPU info

2010-08-02 Thread Roderick Colenbrander
On Mon, Aug 2, 2010 at 2:58 AM, Henri Verbeet wrote: > On 1 August 2010 05:37, Roderick Colenbrander wrote: >>  struct driver_version_information >>  { >> +    WORD vendor;                        /* reported PCI card vendor ID  */ > ... >> +    enum wined3d_displa

Re: New and subtle ddraw:dsurface test failure

2010-08-08 Thread Roderick Colenbrander
2010/8/8 Oldřich Jedlička : > Hi W, > > On Sunday 08 August 2010 11:21:35 wy...@volny.cz wrote: >> Hi, >> >> i > just noticed some new and subtle failure in ddraw:dsurface >> tests. I don't > know how closely you watch and study tests >> results, so i thought it might > be a good idea bring it the

Re: X Presentation and Synchronization - will it help Wine performance

2010-08-10 Thread Roderick Colenbrander
On Tue, Aug 10, 2010 at 6:53 AM, Henri Verbeet wrote: > On 10 August 2010 15:27, Groeschel, Volker wrote: >> I wonder if Wine will profit from the new X Presentation and Synchronization >> feature NVIDIA is working on: >> >> >> >> http://people.freedesktop.org/~aplattner/x-presentation-and-synchr

Re: Windows Imaging Component

2010-08-12 Thread Roderick Colenbrander
On Thu, Aug 12, 2010 at 4:54 AM, Georgij Kirichenko wrote: > This patch add support for decoding Dds, Ppm(and pgm, pbm) and Tga files th > Windows Imaging Component. Each format you are adding requires its own patch. > This patch use dynamic linked FreeImage library, but i'am can't static link >

Re: Windows Imaging Component

2010-08-12 Thread Roderick Colenbrander
On Thu, Aug 12, 2010 at 8:42 AM, Roderick Colenbrander wrote: > On Thu, Aug 12, 2010 at 4:54 AM, Georgij Kirichenko > wrote: >> This patch add support for decoding Dds, Ppm(and pgm, pbm) and Tga files th >> Windows Imaging Component. > > Each format you are addin

Re: Bad CPU autoscaling is making games unplayable for a lot of users

2013-09-16 Thread Roderick Colenbrander
Hi Scott, On Linux power management decisions are made by cpufreq governors. Most distributions I have used recently use the 'ondemand' scheduler, which makes decisions as you would guess based on cpu load. This scheduler has various parameters you can tweak in '/sys/devices/system/cpu/cpufreq/ond

Re: winex11: Don't trace a garbage value or read past end of caller's array in X11DRV_wglChoosePixelFormatARB().

2013-09-20 Thread Roderick Colenbrander
That change looks suspicious. If switching to i+1 fixes a problem, the real problem is that the if-statement in question gets entered in the first place. Some bounds checking on the outer for-loop (the one which loops through nCfgs and nMaxFormats), is probably wrong then. I had issues with this pa

Re: Inviting Mono and pulseaudio to wineconf?

2010-08-24 Thread Roderick Colenbrander
I'm not against inviting Pulseaudio guys. Sure, Pulseaudio was added to distributions way too early and there still are a lot of issues but sound servers like pulseaudio are really the way to go for the future. People want to be able to plug in lets say a usb headset (so another soundcard) when pla

Re: DIB clarification

2010-08-30 Thread Roderick Colenbrander
On Sun, Aug 29, 2010 at 2:18 PM, Jeff Cook wrote: > I hate to stir the pot, especially as an unknown in the community, but > I've spent the last few hours reading WINE's history regarding DIB > engines and it is pretty distressing. > > I have seen expressions of frustration from many regarding the

Re: Wine Introduction Page

2010-09-04 Thread Roderick Colenbrander
On Sat, Sep 4, 2010 at 7:50 PM, James McKenzie wrote: > I was just going over this page and found a few things that I don't know > about but have questions on for building Wine on the Mac: > > The lowest MacOSX version that Wine will build on from the native package is > stated to be 10.4 (Tiger).

Re: [PATCH 2/5] d3d8.h: undefine INTERFACE before defining it

2010-09-08 Thread Roderick Colenbrander
. The Microsoft ddraw.h/d3d8/d3d9 and other headers do the same before declaring the IDirect3D interfaces (actually dsound and tons of other headers also do it). Roderick On Wed, Sep 8, 2010 at 5:22 AM, Alexandre Julliard wrote: > Roderick Colenbrander writes: > >> @@ -129,6 +129,7

Re: Keeping people from trying iTunes in Wine?

2010-09-09 Thread Roderick Colenbrander
On Thu, Sep 9, 2010 at 6:12 PM, Damjan Jovanovic wrote: > On Thu, Sep 9, 2010 at 5:47 PM, Austin English > wrote: >> On Thu, Sep 9, 2010 at 8:34 AM, Rosanne DiMesio >> wrote: >>> On Thu, 9 Sep 2010 00:59:32 -0700 >>> Dan Kegel wrote: >>> Watching Twitter, one fairly frequently seems peop

Re: [PATCH 2/3] wined3d: store amount of video memory in gpu_description_table

2010-09-12 Thread Roderick Colenbrander
Hi Jesse, I think the 465 change should go in after the gpu table patch. The gpu table patch could be modified but then it would essentially contain two patches (makes regression testing more complicated, though I doubt that would be an issue here). It is trivial to submit a patch after this is in

Re: Transparent windows (with alpha channel)

2010-11-04 Thread Roderick Colenbrander
On Thu, Nov 4, 2010 at 3:08 AM, Vassilis Virvilis wrote: > On 03/11/2010 12:36 πμ, Vassilis Virvilis wrote: >> >> On 02/11/2010 02:12 πμ, Vincent Povirk wrote: >>> >>> It is probably a layered window, in which case the following functions >>> in user32 are relevant: SetLayeredWindowAttributes, >>>

Re: [1/2] opengl32/tests: Add tests for special case of SetPixelFormat

2010-11-14 Thread Roderick Colenbrander
Hi Matijn, What 3D API is this game using? Is it using Direct3D or OpenGL? If it is Direct3D then I have the feeling the 'issue' is getting fixed in the wrong layer. Further I'm not really sure whether we want to allow pixel format 1 to be used at all. In case of Wine all pixel formats are hardw

Re: [1/2] opengl32/tests: Add tests for special case of SetPixelFormat

2010-11-14 Thread Roderick Colenbrander
at 3:33 PM, Matijn Woudt wrote: > On Mon, Nov 15, 2010 at 12:06 AM, Roderick Colenbrander > wrote: >> Hi Matijn, >> >> What 3D API is this game using? Is it using Direct3D or OpenGL? >> >> If it is Direct3D then I have the feeling the 'issue' is getting fi

Re: [1/2] opengl32/tests: Add tests for special case of SetPixelFormat

2010-11-21 Thread Roderick Colenbrander
On Sat, Nov 20, 2010 at 3:17 AM, Stefan Dösinger wrote: > Am Donnerstag 18 November 2010, 16:41:53 schrieb Matijn Woudt: >> There's only 1 difference, the first one really shows a window with >> all the triangle's, like it should. Second one doesn't show anything. >> So all the functions don't fai

Re: [PATCH 2/2] opencl: Basic OpenCL 1.0 implementation. (try 2)

2010-11-30 Thread Roderick Colenbrander
It looks fine to me, but I'm worried whether it can work properly in the end. A few months ago I worked on Cuda support for something (I implemented nvcuda.dll which is what cuda runtime libraries like cudart or physx are using). Certain lowlevel nvcuda applications worked, but more fancy applicati

Re: GSOC idea to implement the explorer

2011-02-20 Thread Roderick Colenbrander
On Sun, Feb 20, 2011 at 4:05 AM, Andrew Green wrote: > I was just looking at the Google summer of code(GSOC) ideas and > noticed "implement the explorer". This grabbed my attention as I have > recently been working on a windows xp explorer clone. > Also it mentions a reference to ReactOS explorer

Re: wined3d profiling

2011-02-22 Thread Roderick Colenbrander
In case of Intel make sure you use drivers with debug symbols :) Yeah, you could use oprofile, but for some quick and easy profiling sysprof can be easier and much quicker. Roderick On Tue, Feb 22, 2011 at 2:55 AM, Jeff Zaroyko wrote: > On Tue, Feb 22, 2011 at 8:53 PM, Tobias Jakobi wrote: >> >

Re: winegcc preprocessor macro containing wine version?

2011-03-08 Thread Roderick Colenbrander
On Tue, Mar 8, 2011 at 10:03 PM, Dan Kegel wrote: > Robert McDonald asked: >> I want to be able to define a structure if I'm compiling with Wine 1.2.2 >> but not with Wine 1.3.15, since the structure definition exists in the >> latter but not the former.  Is there a preprocessor macro pre-defined

Re: Xbox 360 controller compatibility

2011-03-20 Thread Roderick Colenbrander
On Sun, Mar 20, 2011 at 1:26 PM, Alesh Slovak wrote: > > On 21 March 2011 00:21, Vitaliy Margolen wrote: >> >> On 03/20/2011 08:20 AM, Alesh Slovak wrote: >>> >>> I am interested in getting the Xbox 360 controller working in wine. >> >> You'll need to implement xinput*.dll which is an empty stub

Re: wined3d: Prevent crash when blit_priv is NULL.

2011-03-20 Thread Roderick Colenbrander
Hi Konrad, You should try to figure out why blit_priv is NULL. That's the real issue. What drivers are you using? Do they support arb fragment program? Right now we may still call arbfp_blit_surface when the extension isn't around (was working on this a year ago, haven't had time since then :( ),

Re: Xbox 360 controller compatibility

2011-03-20 Thread Roderick Colenbrander
On Sun, Mar 20, 2011 at 3:48 PM, Stefan Dösinger wrote: > On Sunday 20 March 2011 21:46:34 Austin English wrote: >> > There are some patches still around (would have to look them up) and >> > they work. > > I think the main problem with implementing xinput.dll isn't xinput itself, it > is the lac

Re: wined3d: Prevent crash when blit_priv is NULL.

2011-03-21 Thread Roderick Colenbrander
Okay, as I expected no ARB_fragment_program support. Give the attached patch a try. For the time being (hope to get a little bit of time to finish what I started..) this patch may be acceptable. Roderick On Mon, Mar 21, 2011 at 8:36 AM, Konrad Rzepecki wrote: > Dnia poniedziałek, 21 marca 2011,

Re: wined3d: Prevent crash when blit_priv is NULL.

2011-03-21 Thread Roderick Colenbrander
On Mon, Mar 21, 2011 at 5:12 PM, Konrad Rzepecki wrote: > Dnia poniedziałek, 21 marca 2011, Roderick Colenbrander napisał(a): >> Okay, as I expected no ARB_fragment_program support. Give the attached >> patch a try. For the time being (hope to get a little bit of time to >>

Re: winex11.drv/opengl.c: add error handling to pglXMakeCurrent() call

2011-03-23 Thread Roderick Colenbrander
Hi Joshua, Was about to submit a similar patch (had a few tiny fixes in my tree left), but this patch is mostly fine with me. Except I would print to 'winediag' like some of the other errors for software / indirect rendering are doing. So do something like 'Unable to active OpenGL context, like so

Re: wined3d: check for ARB_fragment_program in arbfp_blit_supported

2011-03-26 Thread Roderick Colenbrander
On Sat, Mar 26, 2011 at 2:18 AM, Stefan Dösinger wrote: > > <0001-wined3d-check-for-ARB_fragment_program-in-arbfp_blit.patch> > > Considering this statement in select_blit_implementation, directx.c: >     if ((ps_selected_mode == SHADER_ARB || ps_selected_mode == SHADER_GLSL) >             && gl_i

Re: [2/3] winex11.drv: Don't modify current state if glXMakeCurrent fails.

2011-03-29 Thread Roderick Colenbrander
I'm not sure if the only value error wglMakeCurrent should return is INVALID_HANDLE. What if glXMakeCurrent fails because of an invalid context? The return value may be similar, but don't remember for sure. Roderick On Tue, Mar 29, 2011 at 7:42 AM, Matteo Bruni wrote: > > > > >

Re: [3/3] winex11.drv: Make wglMakeCurrent return the correct error when the drawable is invalid.

2011-03-29 Thread Roderick Colenbrander
The fact that a pixel format is not set on the physDev doesn't necessarily mean it is invalid, it just means SetPixelFormat wasn't called on it. Though slightly earlier in wglMakeCurrent we already catch that situation when compare the pixel format of the context and the hdc. Is there not somethin

Re: [3/3] winex11.drv: Make wglMakeCurrent return the correct error when the drawable is invalid.

2011-03-29 Thread Roderick Colenbrander
On Tue, Mar 29, 2011 at 5:58 PM, Matteo Bruni wrote: > 2011/3/29 Roderick Colenbrander : >> The fact that a pixel format is not set on the physDev doesn't >> necessarily mean it is invalid, it just means SetPixelFormat wasn't >> called on it. Though slightly earli

Re: [2/3] winex11.drv: Don't modify current state if glXMakeCurrent fails.

2011-03-29 Thread Roderick Colenbrander
n Tue, Mar 29, 2011 at 5:55 PM, Matteo Bruni wrote: > 2011/3/29 Roderick Colenbrander : >> I'm not sure if the only value error wglMakeCurrent should return is >> INVALID_HANDLE. What if glXMakeCurrent fails because of an invalid >> context? The return value may be

Re: wined3d: Enable blit stretching for 64 bpp

2011-06-04 Thread Roderick Colenbrander
Hi André, I'm not sure if we should add this change since for a part it hides the real problem. Sure this patch likely works, but >32bpp blits should never enter the software rendering code in the first place. The code used to be a huge mess and Henri cleaned it up quite a bit already (thanks, bec

Re: Ge (Greg) van Geldorp

2011-06-10 Thread Roderick Colenbrander
I'm sad to hear that Ge has passed away. He was really a nice guy and his contributions to Wine have been very helpful. We zullen hem missen. Roderick

Re: winelib an fpc

2011-08-30 Thread Roderick Colenbrander
On Tue, Aug 30, 2011 at 9:43 AM, Paul Chitescu wrote: > On Tuesday 30 August 2011 01:57:30 am Reinier Napoles Martinez wrote: >> >>This won't work. Simply doing a dlopen on the wine libraries won't get >> >>your environment setup properly. >> >> what can i do then to setup the wine environment cor

Re: [patch] Fake display interface

2011-09-05 Thread Roderick Colenbrander
On Mon, Sep 5, 2011 at 3:14 PM, Jari Vetoniemi wrote: > Yes, sorry about that.. Gmail does not seem to play nice with some > mailing lists which is weird. > Anyways, I looked at the bug report. This could work for resolution > and frequency, but it does not fake color depth. > > 2011/9/5 GOUJON Al

Re: amd processors seem slow at running configure?

2011-09-16 Thread Roderick Colenbrander
On Thu, Sep 15, 2011 at 8:35 PM, Dan Kegel wrote: > My new AMD a8-3850 takes 77 seconds to run wine's configure script. > (Using -C cuts the time by 40 seconds.) > Austin's Phenom II X4 940 takes 61 seconds. > My i7 takes 32 seconds... but even the lowly e7300 only takes 38 seconds. > The same see

Re: [PATCH] Enable X11DRV_DIB_GetImageBits_8 in all cases and optimize X11DRV_DIB_GetNearestIndex to fix bug 2666 and other strange behavior

2011-09-29 Thread Roderick Colenbrander
On Thu, Sep 29, 2011 at 12:57 PM, David Kiefer wrote: > While this patch indeed fixes bug 2666, it also kills performance, at > least with Age of Empires II. > The frame rate in the menu for me is about one frame every three seconds > and about 1 fps in-game. > > With the patch, the work previousl

Re: wined3d crosscompiling, implementing loadICD

2011-12-14 Thread Roderick Colenbrander
On Wed, Dec 14, 2011 at 2:38 PM, Patrick Rudolph wrote: > Hi, > I'm trying to get ddraw/d3d7 running in my virtual WindowsXP machine using > wined3d. > I managed to cross-compile all neccessary files and implemented a function > that loads the ICD instead of opengl32.dll. > > The name of the ICD i

Re: OpenGL child windows (SketchUp)

2012-02-08 Thread Roderick Colenbrander
On Wed, Feb 8, 2012 at 6:31 PM, Matteo Bruni wrote: > Il 08 febbraio 2012 18:19, Brian Bloniarz ha > scritto: >> Hi all, >> >> I could use a little help fixing a window lag and screen corruption >> issue in SketchUp: >> http://bugs.winehq.org/show_bug.cgi?id=25912 >> Long story short, I think th

Re: OpenGL child windows (SketchUp)

2012-02-09 Thread Roderick Colenbrander
Re-adding wine-devel. On Wed, Feb 8, 2012 at 2:42 PM, Brian Bloniarz wrote: > On Wed, Feb 8, 2012 at 12:33 PM, Roderick Colenbrander > wrote: >> >> On Wed, Feb 8, 2012 at 6:31 PM, Matteo Bruni >> wrote: >> > I'm not really such an expert in the area,

Re: OpenGL child windows (SketchUp)

2012-02-17 Thread Roderick Colenbrander
Hi, I have had a quick look. Although I'm not a big fan of the old OpenML extension. It would be really nice if DRI drivers could be fixed to get a proper glXWaitGL and friends. It still feels like the OpenML extension does a little more than we really need. Since all DRI2 drivers seem to support

Re: Request for help/advice in investigation of one interesting "huge FPS regression" bug

2012-04-16 Thread Roderick Colenbrander
On 4/16/12, Alexey Loukianov wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > 16.04.2012 04:28, Vitaliy Margolen wrote: >> Of course it won't - they are binary blobs from Nvidia. Not much to see >> there. All you really looking for are time spent in that library. >> > > Vitaliy, I don'

Re: A copyright question to wine developpers

2012-06-11 Thread Roderick Colenbrander
On Mon, Jun 11, 2012 at 6:50 AM, Christophe-Marie Duquesne wrote: > On Mon, Jun 11, 2012 at 3:09 PM, Ricardo Filipe > wrote: >> yeah, what happens is the header is reimplemented, not simply >> copy-pasted from Windows. >> Even if the API is not copyrighted, the header contents still are. >> > > W

Re: xbox 360 emulation with logitech cordless and dinput joy disable

2012-06-13 Thread Roderick Colenbrander
On Wed, Jun 13, 2012 at 8:52 AM, Stefan Dösinger wrote: > Hi, > > The patch needs a few improvements before it can be accepted into Wine. I > can't comment on the dinput / xinput specifics of the patch, so this is a non- > exhaustive list of general suggestions. > > Concerning the big picture, thi

Re: [PATCH 2/2] opengl32: Check for valid context in wglGetProcAddress

2012-06-25 Thread Roderick Colenbrander
On Mon, Jun 25, 2012 at 1:22 AM, Chris Robinson wrote: > On Sunday, June 24, 2012 10:42:11 PM Roderick Colenbrander wrote: >> @@ -797,7 +797,7 @@ static void test_getprocaddress(HDC hdc) >>      /* Temporarily disable the context, so we can see that we can't >&

Re: [PATCH] opengl32: Disable wglGetProcAddress for core GL 1.0/1.1 functions

2012-06-25 Thread Roderick Colenbrander
On Mon, Jun 25, 2012 at 10:40 PM, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://tes

Re: Use WM_PAINT to redraw button instead of directly calling unthemed paint routine

2012-08-14 Thread Roderick Colenbrander
On Tue, Aug 14, 2012 at 6:28 PM, Dmitry Timoshkov wrote: > Ruslan Kabatsayev wrote: > >> This patch makes buttons render correctly themed in various cases when >> e.g. they are pressed and released, made active etc. Without this >> patch they look win95-like in such cases even if desktop integrat

<    2   3   4   5   6   7