Re: DIB Engine - Separated in small patches

2009-02-02 Thread max
wine tree. Ciao Max Getting large patches into Wine takes time especially drastic changes like the DIB engine. Well, gdi32 part isn't that drastic with engine disabled is totally transparent Recently I aksed him about this DIB work on IRC and while he didn't check the pa

"remote" start/stop of relay/snoop output

2008-06-23 Thread max
ed up tests. Is it still not possible nor faisible ? Max

Re: Path reset on wine update

2008-07-26 Thread Max
a bug or a required behaviour. For me it's just annoying. Max Vitaliy Margolen ha scritto: > Massimo Del Fedele wrote: >> Maybe that's an already asked question, but why does wine reset >> path on each wine update ? That's becoming annoying... I mus r

d3d11 patch

2013-10-12 Thread Max .
Hi, I would like to know when the first patchs for d3d11 will be introduce into wine ? Beginning of 2014 ? middle 2014 ? End 2014 ? Thanks,

RE: d3d11 patch

2013-10-13 Thread Max .
Hum... WIR= When it's ready ??? Ok ok, i still wait > From: frederic.dela...@gmail.com > Date: Sun, 13 Oct 2013 01:49:04 +0200 > Subject: Re: d3d11 patch > To: asnl...@hotmail.com > CC: wine-devel@winehq.org > > On Fri, Oct 11, 2013 at 7:20 PM, Max . wrote: > >

Re: [PATCH] Label verbosity levels.

2011-03-19 Thread max
From: max On 03/19/2011 08:42 PM, Joris Huizer wrote: > On 03/19/2011 11:32 PM, Vitaliy Margolen wrote: >> On 03/18/2011 09:24 PM, m...@mtew.isa-geek.net wrote: >>> - if ($opt_verbose> 0) >>> - { >>> -print "Processing ".$spec_name."\

Trailing white space and other pedantry.

2011-05-16 Thread max
From: Max TenEyck Woodbury I have been working on the documentation extraction problem and code analysis problem. I have made some progress with the program I am writing to do this. It reads the same files as c2man.pl does, but does a more detailed parse of the code. In fact, it even reads

Re: Trailing white space and other pedantry.

2011-05-16 Thread max
On 05/16/2011 01:00 PM, André Hentschel wrote: Am 16.05.2011 18:34, schrieb m...@mtew.isa-geek.net: From: Max TenEyck Woodbury I have been working on the documentation extraction problem and code analysis problem. I have made some progress with the program I am writing to do this. It reads

Re: Trailing white space and other pedantry.

2011-05-16 Thread max
On 05/16/2011 09:39 PM, Ken Thomases wrote: On May 16, 2011, at 7:42 PM, max wrote: On 05/16/2011 01:00 PM, André Hentschel wrote: I understand that white space only patches will not be applied. Will they be applied if they accompany other corrections? If one would otherwise have modified a

Re: Glitch-free iTunes?

2011-07-04 Thread max
On 07/02/2011 03:46 PM, Keith Curtis wrote: Hi; Here is a rant about iTunes: http://www.pcworld.com/businesscenter/article/229398-2/day_3_dude_wheres_my_itunes.html You guys are doing great, but I think it would be better if you were to work more in priority order. There are 200M devices, last

Re: Glitch-free iTunes?

2011-07-04 Thread max
On 07/04/2011 02:15 PM, André Hentschel wrote: Am 04.07.2011 20:08, schrieb max: 1. Does it run on Windows? iTunes is an Apple product and it could be that it has been intentionally implemented so that it does not run on Microsoft's OS. Why then providing a Windowsversion??? :) S

Re: use Lithuanian letter in my name

2011-07-19 Thread max
At least in the case of c2man, the git logs are not consulted. Max

Re: [docs] winedev: Update code columns limit (resend)

2011-07-25 Thread max
tions. Wider and conflicts arise with the less expensive kinds of equipment. I've lived with the 80 column for more then 3 decades. It chafes a little at times, but ANY standard will irritate. Max 01122334455667

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-08-03 Thread max
em but different compilers may define them differently. Because different compilers DO define them differently, they are not portable. Since they are not portable, wine should not use them without cloaking them in macros that compensate for the differences. Which is a PITA. Has anybody done the cloaks already? Max

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-08-04 Thread max
x27;int' has 32 bits, the total size of all the fields in the group must be 32 bits. THIS HAS PROBABLY BEEN DONE ALREADY!, you just have to dig it out of the list of available configure tests. max (I'm in the middle of something else, otherwise, I'd dig it out myself...)

Re: GSoC-2011: Implement Missing Mesh Functions in Wine?s D3DX9

2011-08-04 Thread max
On 08/04/2011 12:36 PM, David Laight wrote: On Thu, Aug 04, 2011 at 08:30:41AM -0400, max wrote: On 08/03/2011 09:28 AM, Henri Verbeet wrote: Well yes, it's implementation defined, not undefined. The point is that there isn't necessarily any relation to endianness. Just use shifts

Re: w9x testbot state?

2011-08-08 Thread max
nt, but supporting older applications is also useful. Max

[PATCH] msvcrt: fix character/byte confusion in buffer overflow branch

2013-05-07 Thread Max Kellermann
The first memcpy() call in puts_clbk_str_w() confuses character count and byte count. It uses the number of characters (out->len) as number of bytes. This leaves half of the buffer undefined. Interestingly, the second memcpy() call in the same function is correct. This bug potentially makes app

Re: [PATCH] msvcrt: fix character/byte confusion in buffer overflow branch

2013-05-11 Thread Max Kellermann
t;buf is an "APICHAR*" (see printf.h), and adding out->len advances the pointer by "out->len * sizeof(APICHAR)" bytes. Am I missing something? Max

Re: Bugzilla upgrade - opening attachments in browser

2009-05-21 Thread Max Kanat-Alexander
Hey Jeremy. The allow_attachment_display parameter has a detailed description that notes that you are opening a security hole if you set it without setting another parameter (which you haven't set). Did you read the description of the parameter? -Max --

Re: Bugzilla upgrade - opening attachments in browser

2009-05-21 Thread Max Kanat-Alexander
Hey Jeremy. Which parameter, attachment_base or allow_attachment_display? And do you mean that you unset the cookiedomain parameter, or...? (Usually cookiedomain shouldn't be set at all.) -Max Jeremy Newman wrote: The parameter has been set, as well as the cookie domain

Some Questions From The Bugzilla Project

2008-06-24 Thread Max Kanat-Alexander
ply to me directly, since I'm not on the list.) -Max -- http://www.everythingsolved.com/ Competent, Friendly Bugzilla and Perl Services. Everything Else, too.

Re: Some Questions From The Bugzilla Project

2008-06-24 Thread Max Kanat-Alexander
you'd like--if you want to give us explanations of why you've answered certain things, or explain more about anything, go ahead! If you want any clarification on any question, just let me know. :-) And if you want to take time to research any of them within the community, that'

Re: Some Questions From The Bugzilla Project

2008-06-24 Thread Max Kanat-Alexander
s from each one. I don't need to be CC'ed on the actual discussions. -Max -- http://www.everythingsolved.com/ Competent, Friendly Bugzilla and Perl Services. Everything Else, too.

A Handle Cache?

2010-06-09 Thread Max TenEyck Woodbury
While Reading the developer's guide, I noticed that it said that translating windows' handles was always done by the server. I may have misunderstood this. Since interaction between the client and server requires at least two context switches and context switches are fairly heavy duty operation

Anotated 'make test' log

2010-06-13 Thread Max TenEyck Woodbury
I'm trying to get a start on helping with wine development. I'm still in the process of reading the developer's guide, and I think I am making progress on that. As a test of my understanding, I started to annotate the output of 'make -k test'. I'd like your opinion on the usefulness of this. A

Re:Anotated 'make test' log

2010-06-15 Thread Max TenEyck Woodbury
e reassurance that I am not crazy and have the social skills needed to contribute to the community are what I need at the moment. - Max

Re: Anotated 'make test' log

2010-06-16 Thread Max TenEyck Woodbury
ugh starting about two hours ago. I've been checking the mailing list archive. (Yes, messages do not get properly threaded that way.) I'm also in the process of reinstalling much software. That machine is not very fast... - Max

Re: Anotated 'make test' log

2010-06-16 Thread Max TenEyck Woodbury
That would limit ALL fixme's to one printing. The bug report mentioned variable information that might be included but implied that any such information is more properly included in a 'trace'. - Max

Re: Anotated 'make test' log

2010-06-17 Thread Max TenEyck Woodbury
On 06/16/2010 04:48 PM, Dan Kegel wrote: Max wrote: [Maybe we should modify FIXME itself to only print out once.] That's worth discussing, but changing FIXME itself might be going a bit too far during the current code freeze. You could try adding a FIXME_ONCE macro, though, and use

(Resent) Documentation - Reference to MSDN?

2010-06-30 Thread Max TenEyck Woodbury
I've been reading the Wine code and noticed that some of the external interfaces are practically undocumented. I did a web search on some of the names and found descriptions in MSDN. I realize that copying the information from MSDN directly into the code is a poor idea (like copyright violation)

Re: (Resent) Documentation - Reference to MSDN?

2010-06-30 Thread Max TenEyck Woodbury
Juan Lang: Of course one of the reasons to add documentation is precisely because the information on MSDN is less than perfect. Having a good interface definition makes things easier. I'm still in the process of learning how to submit patches. These would be low risk but useful changes so they m

Re: (Resent) Documentation - Reference to MSDN?

2010-06-30 Thread Max TenEyck Woodbury
On 06/30/2010 03:13 PM, Alexandre Julliard wrote: Erich Hoover writes: Alright, well then I won't do it. Is the existing documentation going to be stripped at some point? It seems to me like we would benefit from more-detailed function descriptions in the auto-generated API documentation. I

Documentation - Reference to MSDN?

2010-06-30 Thread Max TenEyck Woodbury
I've been reading the Wine code and noticed that some of the external interfaces are practically undocumented. I did a web search on some of the names and found descriptions in MSDN. I realize that copying the information from MSDN directly into the code is a poor idea (like copyright violati

Re: (Resent) Documentation - Reference to MSDN?

2010-06-30 Thread Max TenEyck Woodbury
On 06/30/2010 03:43 PM, Erich Hoover wrote: On Wed, Jun 30, 2010 at 1:36 PM, James Mckenzie wrote: ... How about some place on the Wiki along with an implementation status. That way we can also annotate items that are missing in MSDN (I just re-stumbled across something in my latest Richedi

Re: (Resent) Documentation - Reference to MSDN?

2010-07-01 Thread Max TenEyck Woodbury
On 06/30/2010 03:13 PM, Alexandre Julliard wrote: Erich Hoover writes: Alright, well then I won't do it. Is the existing documentation going to be stripped at some point? It seems to me like we would benefit from more-detailed function descriptions in the auto-generated API documentation. I

Re: dlls/ntdll/file.c: Use FIXME_ONCE for quieter reports.

2010-07-14 Thread Max TenEyck Woodbury
On 07/14/2010 03:57 PM, Sven Baars wrote: Michael Stefaniuc wrote: Hello Max, are you replacing all FIXME with FIXME_ONCE? While I do agree that we need the _ONCE variant changing all FIXME is not useful. bye michael On 07/14/2010 09:02 PM, Max TenEyck Woodbury wrote: --- dlls/ntdll/file.c

Re: dlls/ntdll/file.c: Use FIXME_ONCE for quieter reports.

2010-07-14 Thread Max TenEyck Woodbury
On 07/14/2010 05:57 PM, Henri Verbeet wrote: On 14 July 2010 22:57, Max TenEyck Woodbury wrote: 1) No, I am not replacing all 'FIXME's with 'FIXME_ONCE's. I'm working on things labeled 'stub' or equivalent. Also 'FIXME's that do not have any addit

Re: dlls/ntdll/file.c: Use FIXME_ONCE for quieter reports.

2010-07-14 Thread Max TenEyck Woodbury
On 07/14/2010 08:53 PM, Chris Robinson wrote: On Wednesday, July 14, 2010 5:02:59 pm Max TenEyck Woodbury wrote: 'FIXME's that contain no variable information are completely redundant after their first report. After the first reminder, the additional reports are just noise. T

Re: dlls/ntdll/file.c: Use FIXME_ONCE for quieter reports.

2010-07-15 Thread Max TenEyck Woodbury
On 07/15/2010 01:13 AM, Dmitry Timoshkov wrote: Max TenEyck Woodbury wrote: I may be new to Wine, but I have a substantial amount of experience designing, writing and fixing code. I learned programming by fixing my fathers code. I more than understand and accept your desire to decide that

Re: Anotated 'make test' log

2010-07-18 Thread Max TenEyck Woodbury
On 07/17/2010 10:27 AM, Detlef Riekenberg wrote: Hi Max Welcome to Wine. Your Patch "[Add '_ONCE' variants of DPRINTF, FIXME, WARN.]" ( http://source.winehq.org/patches/data/63503 ) has a typo near the end: #define ERR_ONCE WINE_ERR_ONCEE Thank you! Fixed and resubmitted.

Re: include/wine/debug.h: ... and uses of '_ONCE' variants.

2010-07-21 Thread Max TenEyck Woodbury
. 'FIXME_ONCE((...));'.) Also, the current implementation is imperfect. There should be a test in 'configure' for the various kinds of variadic macro support and the conditionals should be based on what configure finds, not on the use of any particular compiler. -Max

Re: include/wine/debug.h: ... and uses of '_ONCE' variants.

2010-07-22 Thread Max TenEyck Woodbury
On 07/22/2010 03:35 AM, Alexandre Julliard wrote: Max TenEyck Woodbury writes: Also, the current implementation is imperfect. There should be a test in 'configure' for the various kinds of variadic macro support and the conditionals should be based on what configure finds, not on

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-24 Thread Max TenEyck Woodbury
On 07/24/2010 10:58 AM, Nikolay Sivov wrote: On 7/24/2010 18:51, Max TenEyck Woodbury wrote: --- dlls/ntdll/file.c | 5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c index 0a6ee55..86c200f 100644 --- a/dlls/ntdll/file.c +++ b/dlls

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-24 Thread Max TenEyck Woodbury
On 07/25/2010 12:50 AM, Dmitry Timoshkov wrote: Max TenEyck Woodbury wrote: + /* Invalid requests - do not need 'fixing'. */ + case FileAllInformation: + io->u.Status = STATUS_NOT_IMPLEMENTED; + break; + default: FIXME("Unsupported class (%d)\n", class); io->u.Statu

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-25 Thread Max TenEyck Woodbury
On 07/25/2010 09:45 AM, James McKenzie wrote: Max TenEyck Woodbury wrote: --- dlls/ntdll/file.c | 5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c index 0a6ee55..86c200f 100644 --- a/dlls/ntdll/file.c +++ b/dlls/ntdll/file.c @@ -2148,6

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-25 Thread Max TenEyck Woodbury
On 07/25/2010 01:55 PM, James McKenzie wrote: Andrew Eikum wrote: On 07/25/2010 12:04 PM, Max TenEyck Woodbury wrote: On 07/25/2010 09:45 AM, James McKenzie wrote: I think you missed what Nicolay and Dmitry are trying to tell you. We are trying to implement, bug for bug, the functionality of

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-25 Thread Max TenEyck Woodbury
On 07/25/2010 01:34 PM, Andrew Eikum wrote: On 07/25/2010 12:04 PM, Max TenEyck Woodbury wrote: On 07/25/2010 09:45 AM, James McKenzie wrote: I think you missed what Nicolay and Dmitry are trying to tell you. We are trying to implement, bug for bug, the functionality of what Windows does. Does

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-25 Thread Max TenEyck Woodbury
On 07/25/2010 02:25 PM, Reece Dunn wrote: On 24 July 2010 16:10, Max TenEyck Woodbury wrote: On 07/24/2010 10:58 AM, Nikolay Sivov wrote: On 7/24/2010 18:51, Max TenEyck Woodbury wrote: --- dlls/ntdll/file.c | 5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/dlls

Creation of the Wine API wiki on SourceForge

2010-07-30 Thread Max TenEyck Woodbury
A wiki at https://sourceforge.net/apps/mediawiki/wineapi/index.php has been created for documenting the API interface of WINE (as opposed to Microsoft Windows). It is in the planning stage at this point. - Max

The WineAPI wiki.

2010-08-02 Thread Max TenEyck Woodbury
in should come from the wine source tree. Specifically, I'd like to create 'Overview.wiki' files to contain this information. - Max

Re: The WineAPI wiki.

2010-08-02 Thread Max TenEyck Woodbury
On 08/02/2010 07:00 AM, Dmitry Timoshkov wrote: Max TenEyck Woodbury wrote: I have started the WineAPI wiki at https://sourceforge.net/apps/mediawiki/wineapi/index.php?title=Main_Page You have chosen not very good name. There is no such a thing as Wine API, Wine implements Win32 API, and

Re: The WineAPI wiki.

2010-08-02 Thread Max TenEyck Woodbury
On 08/02/2010 07:53 AM, Dmitry Timoshkov wrote: Max TenEyck Woodbury wrote: You have chosen not very good name. There is no such a thing as Wine API, Wine implements Win32 API, and doesn't specify/add anything custom to it. The name "WineAPI" implies that Wine defines its own A

Re: The WineAPI wiki.

2010-08-02 Thread Max TenEyck Woodbury
On 08/02/2010 11:25 AM, Dmitry Timoshkov wrote: Max TenEyck Woodbury wrote: Further, there is a little confusing and incorrect information in the Microsoft documentation. Bluntly, the Microsoft documentation is what they want it to be. We need to document what it really is. Regardless of

Re: The WineAPI wiki.

2010-08-02 Thread Max TenEyck Woodbury
On 08/02/2010 11:18 AM, James Mckenzie wrote: Max TenEyck Woodbury wrote: On 08/02/2010 07:00 AM, Dmitry Timoshkov wrote: Max TenEyck Woodbury wrote: I have started the WineAPI wiki at https://sourceforge.net/apps/mediawiki/wineapi/index.php?title=Main_Page You have chosen not very

Re: The WineAPI wiki.

2010-08-02 Thread Max TenEyck Woodbury
telligent reviews of pages, such queries can probably be incorporated into that process. Can you help me with this, please? - Max

Re: The WineAPI wiki.

2010-08-04 Thread Max TenEyck Woodbury
On 08/04/2010 03:15 PM, Francois Gouget wrote: On Mon, 2 Aug 2010, Max TenEyck Woodbury wrote: [...] This has been discussed elsewhere on this mailing list. There is a lot of information specific to Wine, particularly its internal structure, that is not shared with Microsoft's product. Fu

Re: The WineAPI wiki.

2010-08-05 Thread Max TenEyck Woodbury
On 08/05/2010 03:56 AM, Francois Gouget wrote: On Wed, 4 Aug 2010, Max TenEyck Woodbury wrote: [...] There several things that have to be coordinated however: - This is not just the API documentation. It includes a great deal of information about the meta-structure of the Wine project. Easy

Re: The WineAPI wiki.

2010-08-06 Thread Max TenEyck Woodbury
On 08/06/2010 05:44 AM, Francois Gouget wrote: On Thu, 5 Aug 2010, Max TenEyck Woodbury wrote: [...] Here's roughly what I have in mind: 1. Win32 API 1. Overview 2. acledit API 1. Overview 2. Functions 1. Func1 2.

WineAPI structure plans

2010-08-16 Thread Max TenEyck Woodbury
for sub-pages and will be set up in the generated initial versions of those pages. That structure consists of a link back to the article that included the sub-page, markings that the page is editable and at least one section header to serve as a handle to enable easy editing of the sub-page. -Max

Re: [PATCH 1/5] d3dx9_36: Implement D3DXFileCreate. (try 3)

2012-10-24 Thread Max TenEyck Woodbury
On 10/24/2012 12:02 PM, Rico Schüller wrote: > On 24.10.2012 16:33, Dmitry Timoshkov wrote: >> Christian Costa wrote: >> > +if (!object) > +{ > +ERR("Out of memory\n"); > +return E_OUTOFMEMORY; > +} The ERR() is useless here, just return E_

Re: windowscodecs questions.

2012-10-24 Thread Max TenEyck Woodbury
On 10/24/2012 02:18 PM, Vincent Povirk wrote: >> I found some code that reads a generic chunk. I see where the size >> and type are read, where a correctly sized record is allocated and >> where the data is read into the record. > > That code is unused for reading and writing PNG images right

Re: [PATCH] Potential reference count races

2012-10-28 Thread Max TenEyck Woodbury
On 10/28/2012 12:07 PM, Alexandre Julliard wrote: > Nikolay Sivov writes: > >> On 10/28/2012 17:44, Max TenEyck Woodbury wrote: >>> Specifying the unnecessary use of a temporary store is a bad habit to >>> have. You should tell the compiler exactly what need

Re: [PATCH] Potential reference count races

2012-10-28 Thread Max TenEyck Woodbury
On 10/28/2012 12:06 PM, Nikolay Sivov wrote: > On 10/28/2012 17:44, Max TenEyck Woodbury wrote: >> On 10/28/2012 02:40 AM, Nikolay Sivov wrote: >>> On 10/28/2012 04:59, m...@mtew.isa-geek.net wrote: >>>> From: Max TenEyck Woodbury >>>> >>>>

Re: [PATCH] Remove potential reference count races

2012-10-28 Thread Max TenEyck Woodbury
On 10/28/2012 12:07 PM, Nikolay Sivov wrote: > On 10/28/2012 18:00, Max TenEyck Woodbury wrote: >> On 10/28/2012 03:13 AM, Nikolay Sivov wrote: >>> On 10/28/2012 04:59, m...@mtew.isa-geek.net wrote: >>>> From: Max TenEyck Woodbury >>>> >>>> -

Add data members to interface data structures?

2012-11-09 Thread Max TenEyck Woodbury
Would a patch that allows data members to be hacked into interface data structures be acceptable? Specifically, this would add sequences that follow this template: #ifdef _IFACE_DATA _IFACE_DATA #endif /* _IFACE_DATA defined */ for each inherited interface, in order.

Re: How to tell Mac from Linux wine within a Wine app? (steam hardware survey)

2012-11-10 Thread Max TenEyck Woodbury
On 11/10/2012 02:03 PM, Scott Ritchie wrote: > Is there an easy way for the steam hardware survey to tell whether it's > running under Mac or Linux Wine? > > I remember discussing this issue with an engineer from Valve after > asking they make the % of Wine users public again. > > Why do you car

Re: [PATCH] tools/widl/header.c: Add a way to declare interface data members.

2012-11-10 Thread Max TenEyck Woodbury
I mentioned this a few days ago. It would have helped if you had raised this point then. As it stands, it is simply a way to adding data members to an aggregate with an interface. In that sense it is not an addition to the interface since the Vtbl pointer remains exactly as before. The new info

Re: [PATCH] tools/widl/header.c: Add a way to declare interface data members.

2012-11-10 Thread Max TenEyck Woodbury
On 11/11/2012 01:01 AM, Nikolay Sivov wrote: > On 11/11/2012 05:00, Max TenEyck Woodbury wrote: >> I mentioned this a few days ago. It would have helped if you had >> raised this point then. >> >> As it stands, it is simply a way to adding data members to an agg

Re: [PATCH] tools/widl/header.c: Add a way to declare interface data members.

2012-11-11 Thread Max TenEyck Woodbury
On 11/11/2012 03:05 PM, Michael Stefaniuc wrote: > On 11/11/2012 07:12 AM, Max TenEyck Woodbury wrote: >> On 11/11/2012 01:01 AM, Nikolay Sivov wrote: >>> On 11/11/2012 05:00, Max TenEyck Woodbury wrote: >>>> I mentioned this a few days ago. It would have helped if

Implementation of PNG 'Get Count' and indexed reads...

2012-11-14 Thread Max TenEyck Woodbury
These are currently returning 'not implemented'. Would it make sense to have 'GetCount' always return '1' and have the indexed read simply read in the whole thing?

Re: Implementation of PNG 'Get Count' and indexed reads...

2012-11-14 Thread Max TenEyck Woodbury
On 11/14/2012 07:03 AM, Dmitry Timoshkov wrote: > Max TenEyck Woodbury wrote: > >> These are currently returning 'not implemented'. >> >> Would it make sense to have 'GetCount' always return '1' and have the >> indexed read simply r

Re: Implementation of PNG 'Get Count' and indexed reads...

2012-11-14 Thread Max TenEyck Woodbury
On 11/14/2012 09:38 AM, Dmitry Timoshkov wrote: > Max TenEyck Woodbury wrote: > >>>> These are currently returning 'not implemented'. >>>> >>>> Would it make sense to have 'GetCount' always return '1' and have the >&g

Re: Implementation of PNG 'Get Count' and indexed reads...

2012-11-14 Thread Max TenEyck Woodbury
On 11/14/2012 10:15 AM, Dmitry Timoshkov wrote: > Max TenEyck Woodbury wrote: > >> Would calculating the total number of 'row' calls and reading each row >> as a 'block in turn be an alternate implementation? > > No, your terminology (what is a "ro

Re: RFC: Remove auto-scan of ALSA devices from winealsa.drv

2012-12-11 Thread Max TenEyck Woodbury
On 12/11/2012 10:46 AM, Henri Verbeet wrote: On 11 December 2012 16:05, wrote: Cost to users: Users with a working ALSA device "default" should experience no drawback, only benefits. I believe this is the vast majority of users. Users that edit their ~/.asoundrc to define other devices with

Re: RFC: Remove auto-scan of ALSA devices from winealsa.drv

2012-12-12 Thread Max TenEyck Woodbury
On 12/11/2012 02:11 PM, Austin English wrote: On Tue, Dec 11, 2012 at 9:39 AM, Max TenEyck Woodbury wrote: On 12/11/2012 10:46 AM, Henri Verbeet wrote: It will also pretty much just remove device selection on setup with multiple audio devices, which is actually fairly common these days with

A new demangler test?

2013-02-21 Thread Max TenEyck Woodbury
Would it be appropriate to add a test to the name demangler that: 1) Scans all '.dll' and '.spac' files for mangled names, and 2) Tries to decode those names. 3) Prints the mangled and decoded names and where they occur. Success would be that all names decode without the decoder blowing up or

Re: A new demangler test?

2013-02-23 Thread Max TenEyck Woodbury
On 02/23/2013 02:54 AM, Eric Pouech wrote: Le 21/02/2013 14:33, Max TenEyck Woodbury a écrit : Would it be appropriate to add a test to the name demangler that: 1) Scans all '.dll' and '.spec' files for mangled names, and 2) Tries to decode those names. 3) Prints the

Re: A new demangler test?

2013-02-24 Thread Max TenEyck Woodbury
On 02/24/2013 04:18 AM, Nikolay Sivov wrote: By the way, do you see something broken or it's just something you want to work on? Partly broken. If fed a bad string, it sometimes blows up and sometimes returns an error code. The 'real' routine also blows up on some strings. Which strings depe

Re: msvcp60: Avoid signed-unsigned integer comparisons

2013-03-10 Thread Max TenEyck Woodbury
On 03/10/2013 07:00 AM, Henri Verbeet wrote: On 10 March 2013 08:20, larmbr zhan wrote: But It behaves different when it is signed or not. According to C Standard, >> - For the signed case, once it overflows, resulting in representing a negative value . Actually, sign

Re: [PATCH 2/2] gdi32: Clip font glyphs to fit within text metrics.

2013-04-19 Thread Max TenEyck Woodbury
On 04/19/2013 02:46 AM, Dmitry Timoshkov wrote: Sam Edwards wrote: This change only affects malformed fonts that have glyphs with splines that go above the maximum ascent as specified in the font's hhea/os2 table. For that reason, any tests for this change would have to include a malformed fon

Re: [PATCH] dlls/gdi32/fretype.c: Avoid division by zero.

2013-05-03 Thread Max TenEyck Woodbury
On 05/04/2013 12:38 AM, Dmitry Timoshkov wrote: m...@mtew.isa-geek.net wrote: +if ( font->aveWidth && font->potm->otmTextMetrics.tmHeight ) { +if (((font->aveWidth + font->potm->otmTextMetrics.tmHeight - 1) / + font->potm->otmTextMetrics.tmHeight) > 100) {

Re: [PATCH] dlls/gdi32/fretype.c: Avoid division by zero.

2013-05-04 Thread Max TenEyck Woodbury
On 05/04/2013 01:56 AM, Dmitry Timoshkov wrote: Max TenEyck Woodbury wrote: +if ( font->aveWidth && font->potm->otmTextMetrics.tmHeight ) { +if (((font->aveWidth + font->potm->otmTextMetrics.tmHeight - 1) / + font->potm-&g

Re: [PATCH] dlls/gdi32/fretype.c: Avoid division by zero.

2013-05-04 Thread Max TenEyck Woodbury
On 05/04/2013 10:50 AM, Dmitry Timoshkov wrote: Max TenEyck Woodbury wrote: If you REALLY think the font should not load, you should add code to reject the font with an appropriate diagnostic, not have this code throw a divide by zero exception and abort execution. Until you do that, this

Re: [PATCH] dlls/gdi32/fretype.c: Avoid division by zero.

2013-05-04 Thread Max TenEyck Woodbury
On 05/04/2013 11:30 AM, Dmitry Timoshkov wrote: Max TenEyck Woodbury wrote: If you REALLY think the font should not load, you should add code to reject the font with an appropriate diagnostic, not have this code throw a divide by zero exception and abort execution. Until you do that, this

Re: [PATCH] dlls/gdi32/fretype.c: Avoid division by zero.

2013-05-04 Thread Max TenEyck Woodbury
On 05/04/2013 05:37 PM, Sam Edwards wrote: On 05/04/2013 12:59 PM, Max TenEyck Woodbury wrote: You are trying to make this about me. It is not. Windows fairly obviously does not do this 'sanity' test. Wine is supposed to imitate windows. To do this absolutely correctly, the who

Re: [PATCH] dlls/gdi32/fretype.c: Avoid division by zero.

2013-05-04 Thread Max TenEyck Woodbury
On 05/04/2013 07:50 PM, Hin-Tak Leung wrote: I'd like to mention two things: - there were(are?) overflows/underflows within Freetype itself, up to and including 2.4.11 - the fixes went into trunk, but AFAIK 2.4.12 isn't release yet. That's specifically affect 32-bit platform, and emulated

Re: [PATCH] dlls/gdi32/fretype.c: Avoid division by zero.

2013-05-04 Thread Max TenEyck Woodbury
OK. Let's summarize: There are some fonts where tmHeight is in fact 0. If Hin-Tak Leang is correct, these may be Open-Source fonts possibly with proprietary equivalents. Since I have hundreds of fonts installed on my system, it is almost certain that I have one or more. Identifying which wit

Re: [PATCH] dlls/gdi32/fretype.c: Avoid division by zero.

2013-05-04 Thread Max TenEyck Woodbury
On 05/05/2013 12:09 AM, Sam Edwards wrote: On 05/04/2013 08:27 PM, Max TenEyck Woodbury wrote: OK. Let's summarize: There are some fonts where tmHeight is in fact 0. If Hin-Tak Leang is correct, these may be Open-Source fonts possibly with proprietary equivalents. Since I have hundre

Re: [PATCH] dlls/gdi32/fretype.c: Avoid division by zero.

2013-05-06 Thread Max TenEyck Woodbury
On 05/05/2013 06:27 PM, Sam Edwards wrote: So, Wine's font loader seems to be working appropriately and thus the sane thing to do is to make sure tmHeight=0 is handled gracefully. Just to make this clear, the most recent version of this patch is such a graceful handling, right?

Re: [PATCH] dlls/gdi32/freetype.c: A better divide by zero fix, report bad fonts.

2013-05-07 Thread Max TenEyck Woodbury
On 05/07/2013 08:15 AM, Sam Edwards wrote: On 05/06/2013 03:05 PM, Max TenEyck Woodbury wrote: Just to make this clear, the most recent version of this patch is such a graceful handling, right? I haven't worked on gdi32/freetype.c much, so I wouldn't be the one to say for sure (

Re: [PATCH 6/6] d3d9/tests: d3d9ex video memory accounting tests

2013-05-16 Thread Max TenEyck Woodbury
On 05/15/2013 06:32 AM, Henri Verbeet wrote: On 14 May 2013 23:46, Stefan Dösinger wrote: These tests have the potential to break on Windows when other applications create or release a large number of video memory resources while the test is running. Yeah, maybe we don't really need this to b

WineAPI wiki progress.

2010-09-14 Thread Max TenEyck Woodbury
of the file content is in place. I plan to start with analysis of the '.spec' files. That should make some of the information on the API available. - Max

WineAPI wiki progress (resent)

2010-09-15 Thread Max TenEyck Woodbury
content is useful and how it could be improved. None of the analysis of the file content is in place. I plan to start with analysis of the '.spec' files. That should make some of the information on the API available. - Max

Re: WineAPI wiki progress (resent)

2010-09-15 Thread Max TenEyck Woodbury
On 09/15/2010 10:25 AM, GOUJON Alexandre wrote: On 09/15/2010 03:32 PM, Max TenEyck Woodbury wrote: The wiki at https://sourceforge.net/apps/mediawiki/wineapi/index.php now has pages for the directories in the Wine Repository with classifications of the directory content. Well, to be frank, I

Re: WineAPI wiki progress (resent)

2010-09-15 Thread Max TenEyck Woodbury
On 09/15/2010 10:56 AM, Francois Gouget wrote: On Wed, 15 Sep 2010, Max TenEyck Woodbury wrote: The previous version ended up as a reply to something inappropriate. The wiki at https://sourceforge.net/apps/mediawiki/wineapi/index.php now has pages for the directories in the Wine Repository

Re: WineAPI wiki progress (resent)

2010-09-15 Thread Max TenEyck Woodbury
On 09/15/2010 10:47 PM, Max TenEyck Woodbury wrote: Actually, that was a mistake on my part. If you use: https://sourceforge.net/apps/mediawiki/wineapi/index.php you can skip the login. ARGH! Make that: http://sourceforge.net/apps/mediawiki/wineapi/index.php - Max

WineAPI wiki status update

2010-09-25 Thread Max TenEyck Woodbury
s. Header and code analysis are on queue after that, as is improving the page format. There are a bunch of old pages without the 'Wine/' prefix. They are being removed. Advice on wiki-bots would be helpful. - Max

WineAPI wiki progress

2010-10-28 Thread Max TenEyck Woodbury
implementation. There is ONE API description page at this point. If any of you would care to look at it and send me comments, I will read them. I will be setting up analytic scripts for the individual API pages after the name space indexes are in place. Max

Help with 'WineAPI' wiki

2010-11-12 Thread Max TenEyck Woodbury
once. Someone to review what I am doing might help. - Max

  1   2   >