Re: [1/5] ntdll: Add support to NtWriteFile for special offset -1. Take 3.

2013-09-10 Thread Alexandre Julliard
Dmitry Timoshkov writes: > @@ -961,16 +961,23 @@ NTSTATUS WINAPI NtWriteFile(HANDLE hFile, HANDLE hEvent, > > if (type == FD_TYPE_FILE) > { > +off_t off; > + > if (!(options & (FILE_SYNCHRONOUS_IO_ALERT | > FILE_SYNCHRONOUS_IO_NONALERT)) && !offset) > { >

Re: xcopy: Add an explicit check to avoid an out of array access. access. (RESEND)

2013-09-10 Thread Alexandre Julliard
Gerald Pfeifer writes: > On Sun, 24 Mar 2013, Gerald Pfeifer wrote: >> This _may_ not be necessary, strictly speaking, but new versions of >> GCC (GCC 4.8) complain about this. (And there might be a fringe case?) > > How about this patch? I see it was not applied, but also did not > see a respon

Re: [2/5] ntdll: Make NtWriteFile handle special offset -2 same way as -1. Resend.

2013-09-10 Thread Alexandre Julliard
Dmitry Timoshkov writes: > --- > dlls/ntdll/file.c | 31 +++ > 1 file changed, 15 insertions(+), 16 deletions(-) Why do you need that? It doesn't look to me like an improvement. -- Alexandre Julliard julli...@winehq.org

Re: [2/5] ntdll: Make NtWriteFile handle special offset -2 same way as -1. Resend.

2013-09-10 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > Why do you need that? It doesn't look to me like an improvement. IMO it simplifies the code and avoids using two different code paths for normal files. -- Dmitry.

Re: [2/2] oledb32: Implement IDataSourceLocator get/put hWnd (resend)

2013-09-10 Thread Nikolay Sivov
On 9/10/2013 13:30, Alistair Leslie-Hughes wrote: Hi, Changelog: oledb32: Implement IDataSourceLocator get/put hWnd Best Regards Alistair Leslie-Hughes Hi, Alistair. This is wrong, interface definition should be fixed as well, HWND parameter can't be LONG: --- [id(0x600200

Re: [2/5] ntdll: Make NtWriteFile handle special offset -2 same way as -1. Resend.

2013-09-10 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Alexandre Julliard wrote: > >> Why do you need that? It doesn't look to me like an improvement. > > IMO it simplifies the code and avoids using two different code paths > for normal files. At the cost of two extra seeks, plus introducing race conditions. I don't thin

Re: winemac: Don't return characters for Ctrl-(non-letter symbol) keypresses from ToUnicodeEx() as X11 driver already does (try 2)

2013-09-10 Thread Phil Krylov
Hi, On Tue, Sep 10, 2013 at 6:05 AM, Ken Thomases wrote: > Is there a specific problem that you're trying to fix? Yes. I didn't file a bug report yet, but an application I am using (IBM Translation Manager) has some functionality bound to Ctrl-[0-9/] keypresses. Now with the Mac driver when I pr

Re: ntdll: Try application manifest path when searching for dependent assemblies

2013-09-10 Thread Alexandre Julliard
Nikolay Sivov writes: > @@ -2776,8 +2776,7 @@ static NTSTATUS lookup_assembly(struct actctx_loader* > acl, > /* FIXME: add support for language specific lookup */ > > nameW.Buffer = NULL; > -if (!(buffer = RtlAllocateHeap( GetProcessHeap(), 0, > -

Re: winemac: Don't return characters for Ctrl-(non-letter symbol) keypresses from ToUnicodeEx() as X11 driver already does (try 2)

2013-09-10 Thread Ken Thomases
On Sep 10, 2013, at 5:45 AM, Phil Krylov wrote: > On Tue, Sep 10, 2013 at 6:05 AM, Ken Thomases wrote: >> Is there a specific problem that you're trying to fix? > > Yes. I didn't file a bug report yet, but an application I am using > (IBM Translation Manager) has some functionality bound to Ctrl

RFC: HKCR merge implementation

2013-09-10 Thread George Stephanos
I'm proposing my HKEY_CLASSES_ROOT implementation patches for review. Feel free to comment. So far, I've written code for all functions except for the RegEnum family. General description: HKCR handles are special. All wine handles have the two lowest bits zero'd. HKCR handles are masked. 10b spec

Re: RFC: HKCR merge implementation

2013-09-10 Thread Juan Lang
Hi George, On Tue, Sep 10, 2013 at 3:55 PM, George Stephanos wrote: > I'm proposing my HKEY_CLASSES_ROOT implementation patches for review. Feel > free to comment. > So far, I've written code for all functions except for the RegEnum family. > > General description: > > HKCR handles are special. A

Re: Embedding a HWND window into an X11 window

2013-09-10 Thread jordan
> Could we extend winelib to let user embed win32 window into X11 window? Wouldn't you do this at the toolkit level? (in your winelib app) like gtkplug+gtksocket or something like that?? ie: in Gtk+ https://developer.gnome.org/gtk3/3.7/GtkPlug.html I was thinking about testing this out in a gtk-b

Re: RFC: HKCR merge implementation

2013-09-10 Thread George Stephanos
> > >> a couple bitwise nits in your first patch: > > +#define HKCR_MASK 2 > +#define IS_HKCR(hk) ((UINT_PTR)hk > 0 && ((UINT_PTR)hk & 3) == HKCR_MASK) > > Typically a mask would define all the bits that could be set, and a flag > would be the particular bit you want to test. Something like: > #def

Re: (resend) [PATCH] serial: wait_for_event() must set Information in PIO_STATUS_BLOCK

2013-09-10 Thread Dmitry Timoshkov
Wolfgang Walter wrote: > -if (commio->iosb) commio->iosb->u.Status = *commio->events ? > STATUS_SUCCESS : STATUS_CANCELLED; > +if (commio->iosb) { > +commio->iosb->u.Status = *commio->events ? STATUS_SUCCESS : > STATUS_CANCELLED; > +if (*commio->events) > +co

RFC: HKCR merge implementation

2013-09-10 Thread George Stephanos
I'm proposing my HKEY_CLASSES_ROOT implementation patches for review. Feel free to comment. So far, I've written code for all functions except for the RegEnum family. General description: HKCR handles are special. All wine handles have the two lowest bits zero'd. HKCR handles are masked. 10b spec