Re: xmllite: Store DTD processing mode in reader

2012-08-28 Thread Alexandre Julliard
Dan Kegel writes: > Alexandre Julliard wrote: >> Explicit ok() calls are better than hiding them inside a macro. > > Uh-oh. Want me to get rid of this macro > > +#define CHECK_RET_ERRNO(ret, ex) \ > +do { \ > +ok(ret == ex, "ret is %d, expected %d\n", ret, ex); \ > +ok(errno

re: xmllite: Store DTD processing mode in reader

2012-08-27 Thread Dan Kegel
Alexandre Julliard wrote: > Explicit ok() calls are better than hiding them inside a macro. Uh-oh. Want me to get rid of this macro +#define CHECK_RET_ERRNO(ret, ex) \ +do { \ +ok(ret == ex, "ret is %d, expected %d\n", ret, ex); \ +ok(errno == ex, "errno is %d, expected %d\n"

Re: xmllite: Store DTD processing mode in reader

2012-08-27 Thread Alexandre Julliard
Nikolay Sivov writes: > @@ -350,34 +353,47 @@ static void test_reader_create(void) > HRESULT hr; > IXmlReader *reader; > IUnknown *input; > +DtdProcessing dtd; > > /* crashes native */ > if (0) > { > pCreateXmlReader(&IID_IXmlReader, NULL, NULL); > -