RE: xcopy try 2

2007-02-24 Thread Ann & Jason Edmeades
Hi Detlef, (again) >Configure.ac - I included that because another 'regular' developer who >added a dll recently added it (See:) > http://www.winehq.org/pipermail/wine-patches/2007-February/036243.html) >I'll leave it in for that reason unless there's a big problem with it (I >always thought you

RE: xcopy try 2

2007-02-24 Thread Ann & Jason Edmeades
Hi Detlef, Firstly thanks for taking the time to comment on this... Configure.ac - I included that because another 'regular' developer who added a dll recently added it (See:) http://www.winehq.org/pipermail/wine-patches/2007-February/036243.html) I'll leave it in for that reason unless there'

Re: xcopy try 2

2007-02-24 Thread David Laight
On Sat, Feb 24, 2007 at 01:00:06AM +0100, Detlef Riekenberg wrote: > > +C_SRCS = \ > +xcopy.c > > Spaces are wrong before the filename. You must use TAB in makefiles That is a contiuation line, IIRC the whitespace at the start of the continued line should be discarded (and can be space/t

Re: xcopy try 2

2007-02-23 Thread Detlef Riekenberg
On Fr, 2007-02-23 at 16:44 +, Ann & Jason Edmeades wrote: Looks nice, but a view over the code result in some more comments: --- a/configure.ac +++ b/configure.ac Not needed, when sending the Patch (and that line causes already an offset, when patching wine) "tools/make_makefiles" takes care