Re: Patch for wsock32 conformance test

2005-03-01 Thread Alexandre Julliard
Thomas Kho <[EMAIL PROTECTED]> writes: > We're working on a set of tests for wsock32.dll with guidance from Dan > Kegel. So far we've > completed a test of blocking network I/O with multiple threads. > Attached is a patch from our efforts. We look forward to suggestions. This stuff should be merg

Re: wsock32 conformance test

2005-02-25 Thread Juan Lang
Hey guys, nice work. Minor comments below: > +/* we often pass this size by reference */ > +int sizeofSOCKADDR_IN = sizeof(SOCKADDR_IN); When you pass it by reference, you don't reinitialize it after a call that might modify it, e.g. here: > + /* get port number */ > + getsockname(*sock,

wsock32 conformance test

2005-02-25 Thread Thomas Kho
Hi, We're working on a set of tests for wsock32.dll. So far we've completed a test of blocking network I/O with multiple threads. Before we post to wine-patches, we'd appreciate any critiques/input. Fredy, Doug, and I are UCLA undergraduates in a software engineering course. Thanks for your help