Re: winscard: Implement some functions of winscard.dll

2011-05-26 Thread Alexandre Julliard
Sergey Stepanov writes: > @@ -33,6 +35,24 @@ const SCARD_IO_REQUEST g_rgSCardT0Pci = { > SCARD_PROTOCOL_T0, 8 }; > const SCARD_IO_REQUEST g_rgSCardT1Pci = { SCARD_PROTOCOL_T1, 8 }; > const SCARD_IO_REQUEST g_rgSCardRawPci = { SCARD_PROTOCOL_RAW, 8 }; > > +#define MAKE_FUNCPTR(f) static typeo

winscard: Implement some functions of winscard.dll

2011-05-15 Thread Juan Lang
Hi Sergey, #include "config.h" +#include #include This change will cause compile failures on systems without this header. You need to add a configure check for the header, and include it conditionally. Thanks, --Juan

winscard/tests: Add test base functions of winscard.dll

2011-05-06 Thread Joerg-Cyril.Hoehle
dFreeMemory following SCardListReaders AUTOALLOCATE) and some style issues (casts inside ok("%ld") formats) as well as IMHO too many redundant trace("testing X\n"), see $WINETEST_REPORT_SUCCESS. In their patch, LoadLibrary was necessary instead of a statically linked .exe beca

Re: winscard/tests: Implement test for two functions of winscard.dll

2011-05-06 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10750 Your paranoid android

Re: winscard/tests: Implement test for two functions of winscard.dll

2011-05-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10749 Your paranoid android

Re: winscard/tests: Add test base functions of winscard.dll

2011-05-04 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10722 Your paranoid android

Re: winscard.dll

2010-09-29 Thread Ricardo Filipe
2010/9/29 viny : >> However, I don't see any credits to me or IDRIX in you submission. > > I don't understand Mounir : after patching, all wine Winscard sources files > contain/keep this words : > "Copyright 2007 Mounir IDRASSI  (mounir.idra...@idrix.fr, for IDRIX)" > >> In the coming days, I'll pr

Re: winscard.dll

2010-09-29 Thread viny
However, I don't see any credits to me or IDRIX in you submission. I don't understand Mounir : after patching, all wine Winscard sources files contain/keep this words : "Copyright 2007 Mounir IDRASSI (mounir.idra...@idrix.fr, for IDRIX)" In the coming days, I'll prepare an updated version o

Re: winscard.dll

2010-09-28 Thread Mounir IDRASSI
Vitaliy Margolen kievinfo.com> writes: > > +/* get list from pcsc-lite */ > > +*pmszReaders = (LPSTR*) mszReaders; > You corrupting memory here. You haven't assigned any memory to pmszReaders. > Did you mean to write "pmszReaders = (LPSTR) mszReaders;" ? In fact I don't > see yo

Re: winscard.dll

2010-09-28 Thread Mounir IDRASSI
viny gmail.com> writes: > > Yes I started with this referenced discussion. > > Here is a first patch. With it, Winscard can identify your smartcard reader. > > Is it good enough to be sent to wine-patch ? Hi Vincent, I'm the original author of the Winscard patch sent in 2007 and I see that th

Re: winscard.dll

2010-09-28 Thread James McKenzie
On 9/28/10 1:49 AM, viny wrote: Hi all, Is anyone working on winscard.dll ? If not, may I propose patches ? You might want to visit the Developer FAQ on the Wine Wiki at http://wiki.winehq.org/DeveloperFaq and then read through all of the Submitting Patches portion as well. Good luck on

Re: winscard.dll

2010-09-28 Thread Vitaliy Margolen
On 09/28/2010 06:46 AM, viny wrote: Yes I started with this referenced discussion. Here is a first patch. With it, Winscard can identify your smartcard reader. +g_pcscliteHandle = wine_dlopen("libpcsclite.so", RTLD_LAZY | RTLD_GLOBAL, error, sizeof(error)); You need to use configure

Re: winscard.dll

2010-09-28 Thread viny
ehq.org/pipermail/wine-devel/2008-August/068462.html J. Leclanche On Tue, Sep 28, 2010 at 12:43 PM, Tom Wickline wrote: Hello Vincent, I don't believe anyone is working on winscard.dll at this time. You are more then welcome to work on it or any other part of Wine. A couple years back t

Re: winscard.dll

2010-09-28 Thread Tom Wickline
Thanks, I was to lazy to search for it. :) Tom On Tue, Sep 28, 2010 at 7:56 PM, Jerome Leclanche wrote: > The referenced discussion, in case anyone's curious: > http://www.winehq.org/pipermail/wine-devel/2008-August/068462.html > > > J. Leclanche > > > >

Re: winscard.dll

2010-09-28 Thread Jerome Leclanche
The referenced discussion, in case anyone's curious: http://www.winehq.org/pipermail/wine-devel/2008-August/068462.html J. Leclanche On Tue, Sep 28, 2010 at 12:43 PM, Tom Wickline wrote: > Hello Vincent, > > I don't believe anyone is working on winscard.dll at this time.

Re: winscard.dll

2010-09-28 Thread Tom Wickline
Hello Vincent, I don't believe anyone is working on winscard.dll at this time. You are more then welcome to work on it or any other part of Wine. A couple years back their was a discussion about winscard.dll so you might want to search through the wine-dev mailing list. Maybe thos

winscard.dll

2010-09-28 Thread viny
Hi all, Is anyone working on winscard.dll ? If not, may I propose patches ? I would like to have a working winscard.dll in wine. -- Vincent