Re: winmm: Check param in joyConfigChanged

2008-12-31 Thread Alexandre Julliard
Christian Costa writes: >> There's no reason to rename the parameter, 'flags' is a perfectly good >> name. >> > It was just to reflect more the MSDN. Maybe it's not that usefull. No it's not, MSDN uses the stupid Hungarian notation everywhere, and we should stay as far away as possible from t

Re: winmm: Check param in joyConfigChanged

2008-12-31 Thread Christian Costa
Alexandre Julliard a écrit : > Christian Costa writes: > > >> -MMRESULT WINAPI joyConfigChanged(DWORD flags) >> +MMRESULT WINAPI joyConfigChanged(DWORD dwFlags) >> { >> -FIXME("(%x) - stub\n", flags); >> +FIXME("(%x) - stub\n", dwFlags); >> + >> +if (dwFlags) >> +return JOY

Re: winmm: Check param in joyConfigChanged

2008-12-31 Thread Alexandre Julliard
Christian Costa writes: > -MMRESULT WINAPI joyConfigChanged(DWORD flags) > +MMRESULT WINAPI joyConfigChanged(DWORD dwFlags) > { > -FIXME("(%x) - stub\n", flags); > +FIXME("(%x) - stub\n", dwFlags); > + > +if (dwFlags) > +return JOYERR_PARMS; There's no reason to rename the p