On Tue, 29 Apr 2008, Robert Reif wrote:
> First of all, requesting 4 bytes is not invalid but a perfectly
> reasonable thing to do. It is just reading the manufactures id and
> product id. However this behavior is not documented in MSDN so at best
> it's just unspecified behavior. The reason
Robert Reif wrote:
> Peter Åstrand wrote:
>
>> On Mon, 28 Apr 2008, Robert Reif wrote:
>>
>>
>>
However, the waveOutGetDevCapsW fails as well on WTS, also returning
MMSYSERR_INVALPARAM.
>>
>>
>>> Let me get this straight, your company's produc
Peter Åstrand wrote:
> On Mon, 28 Apr 2008, Robert Reif wrote:
>
>
>>> However, the waveOutGetDevCapsW fails as well on WTS, also returning
>>> MMSYSERR_INVALPARAM.
>>>
>
>
>> Let me get this straight, your company's product doesn't pass this wine
>> regression test so you want to rem
On Mon, 28 Apr 2008, Robert Reif wrote:
> > However, the waveOutGetDevCapsW fails as well on WTS, also returning
> > MMSYSERR_INVALPARAM.
> Let me get this straight, your company's product doesn't pass this wine
> regression test so you want to remove the test?
No. Quoting from my intial post:
Peter Åstrand wrote:
>>> And what is the error? If you know the error code returned, Ill add it
>>> to the code so we can end this discussion.
>>>
>> The error is MMSYSERR_INVALPARAM.
>>
>
> I can see that this patch has now been committed:
>
> --- wine/dlls/winmm/tests/wave.c:1.67
> > And what is the error? If you know the error code returned, Ill add it
> > to the code so we can end this discussion.
>
> The error is MMSYSERR_INVALPARAM.
I can see that this patch has now been committed:
--- wine/dlls/winmm/tests/wave.c:1.67 Fri Feb 29 06:18:36 2008
+++ wine/dlls/winm
> > > There are only two options: only pass the number of bytes requested
> > > or return an error for unreasonable sizes. What is Terminal Server
> > > doing?
> >
> > It's returning an error.
> >
> And what is the error? If you know the error code returned, Ill add it
> to the code so we
>> There are only two options:
>> only pass the number of bytes requested or return an error for unreasonable
>> sizes. What is Terminal Server doing?
>>
>
> It's returning an error.
>
>
And what is the error? If you know the error code returned, Ill add it
to the code so
we can end
> > However, I still think it's VERY strange to expect success from an invalid
> > call. You are describing it as an "invalid argument" yourself. Why should we
> > expect a call with an "invalid argument" to succeed? And again, the test
> > does NOT pass on all Microsoft versions; it fails on Term
Peter Åstrand wrote:
> However, I still think it's VERY strange to expect success from an
> invalid call. You are describing it as an "invalid argument" yourself.
> Why should we expect a call with an "invalid argument" to succeed? And
> again, the test does NOT pass on all Microsoft versions; i
On Mon, 21 Apr 2008, Robert Reif wrote:
> > That's the whole point of the test, to check what happens with an invalid
> > argument.
> >
>
> So what do you think *should* happen with an invalid argument? The result is
> different on different Windows platforms. The behaviour is not specifie
Peter Åstrand wrote:
On Fri, 18 Apr 2008, Robert Reif wrote:
-rc=waveOutGetDevCapsA(device,&capsA,4);
+/* Final call must succeed, capsA will be used below */
+rc=waveOutGetDevCapsA(device,&capsA,sizeof(capsA));
ok(rc==MMSYSERR_NOERROR,
"waveOutGetDevCapsA(%s): MMSYS
On Fri, 18 Apr 2008, Robert Reif wrote:
> > -rc=waveOutGetDevCapsA(device,&capsA,4);
> > +/* Final call must succeed, capsA will be used below */
> > +rc=waveOutGetDevCapsA(device,&capsA,sizeof(capsA));
> > ok(rc==MMSYSERR_NOERROR,
> > "waveOutGetDevCapsA(%s): MMSYSERR_NOE
Peter Åstrand wrote:
> Changelog:
>
> Calling waveOutGetDevCapsA/waveOutGetDevCapsW with size 4 is wrong, the
> size should be the sizeof the structure used. waveOutGetDevCapsA needs to
> succeed since the capsA structure is used later.
>
> Index: wave.c
> ===
14 matches
Mail list logo
