On 11/05/2009 02:35 PM, joerg-cyril.hoe...@t-systems.com wrote:
Hi,
this is the same as yesterday's patch except that I replaced the
ad-hoc skip auto-open test with one that specifically detects Wine's
missing auto-open functionality instead of another thing missing in Wine.
You will prefer that
writes:
> +START_TEST(mci)
> +{
> +HWND hwnd;
> +hwnd = CreateWindowExA(0, "static", "winmm test", WS_POPUP, 0,0,100,100,
> + 0, 0, 0, NULL);
> +test_openCloseWAVE(hwnd);
> +test_recordWAVE(hwnd);
> +test_playWAVE(hwnd);
> +test_asyncWAVE(hwnd);
>
Paul Virnes wrote:
>> What I'm missing is sort of the converse of skip:
>> Perform a test on all platforms *except* Wine
>Isn't there anything in your current test suite that succeeds on Windows
>but fails on Wine?
This is it!
So simple, right in front of my eyes.
Thanks,
Jörg Höhle.
writes:
> Hi,
>
> please excuse the cheap way of avoiding dead code, but I was afraid
> that git rebase would cause me too many failures with my 30 subsequent
> patches. The minor change of turning #if FULL_TEST into /* already cost
> me 4 hours with git rebase fixing and assessing make; make mc
On 10/27/2009 10:13 AM, joerg-cyril.hoe...@t-systems.com wrote:
Reece dunn wrote:
Once the fix has been added, the todo_wine bit can be removed.
I know about it and skip and win_skip thanks to Michael Karcher's excellent
text:
http://www.winehq.org/pipermail/wine-devel/2008-October/069721.ht
Reece dunn wrote:
>Once the fix has been added, the todo_wine bit can be removed.
I know about it and skip and win_skip thanks to Michael Karcher's excellent
text:
http://www.winehq.org/pipermail/wine-devel/2008-October/069721.html
The problem is that running the full tests crashes or hangs Win
2009/10/26 :
> Hi,
>
>> +/* Some tests hang or crash Wine. Enable once fixed. */
>> +#define FULL_TEST 0
>
>>Please don't introduce dead code. If the tests really can't work then
>>don't add them at all until you have the corresponding fixes.
>
> Will do. Although I'd very much prefer having test
Hi,
> +/* Some tests hang or crash Wine. Enable once fixed. */
> +#define FULL_TEST 0
>Please don't introduce dead code. If the tests really can't work then
>don't add them at all until you have the corresponding fixes.
Will do. Although I'd very much prefer having tests than no tests.
I've bee
writes:
> -START_TEST(mci)
> +#ifndef FULL_TEST
> +/* Some tests hang or crash Wine. Enable once fixed. */
> +#define FULL_TEST 0
> +#endif
Please don't introduce dead code. If the tests really can't work then
don't add them at all until you have the corresponding fixes.
--
Alexandre Julliard
