Re: wininet: Make sure URL is terminated in InternetCrackUrlA.

2008-06-10 Thread Alexandre Julliard
Francois Gouget <[EMAIL PROTECTED]> writes: > Why not? It's a bug fix and four places to fix sounds quite reasonable > (>100 may not be). Maybe it's just me but I didn't feel like 1.0 would > entail a deep deep freeze period where only critical/security bugs would > be fixed. At this point the

Re: wininet: Make sure URL is terminated in InternetCrackUrlA.

2008-06-10 Thread Francois Gouget
On Tue, 10 Jun 2008, Hans Leidekker wrote: > On Monday 09 June 2008 17:09:52 Alexandre Julliard wrote: > > > The bug is in InternetCrackUrlW, it shouldn't require the string to be > > null-terminated. > > Right, but I guess fixing that is no 1.0 material since there's at least > 4 places where i

Re: wininet: Make sure URL is terminated in InternetCrackUrlA.

2008-06-10 Thread Hans Leidekker
On Monday 09 June 2008 17:09:52 Alexandre Julliard wrote: > The bug is in InternetCrackUrlW, it shouldn't require the string to be > null-terminated. Right, but I guess fixing that is no 1.0 material since there's at least 4 places where it assumes a null-terminated string, including a call to In

Re: wininet: Make sure URL is terminated in InternetCrackUrlA.

2008-06-09 Thread Alexandre Julliard
Hans Leidekker <[EMAIL PROTECTED]> writes: > Fixes http://bugs.winehq.org/show_bug.cgi?id=1968 > as well as a bunch of Valgrind warnings in the url test module. > > -Hans > > Changelog > Make sure URL is terminated in InternetCrackUrlA. The bug is in InternetCrackUrlW, it shouldn't require the