Re: #1 wininet: Make resolving hostnames thread-safe. try2

2008-05-31 Thread Rob Shearman
2008/5/31 Hans Leidekker <[EMAIL PROTECTED]>: > Make resolving hostnames thread-safe. > > +/* critical section to protect non-reentrant gethostbyname() */ > +CRITICAL_SECTION cs_gethostbyname; > +static CRITICAL_SECTION_DEBUG critsect_debug = > +{ > +0, 0, &cs_gethostbyname, > +{ &critsect

Re: wininet: Make resolving hostnames thread safe.

2008-05-24 Thread Hans Leidekker
On Saturday 24 May 2008 20:04:14 Rob Shearman wrote: > In the long term it would be better to use getaddrinfo instead of > gethostbyname/gethostbyname_r, but that's too big a change for 1.0. My thoughts exactly. I looked at getaddrinfo first but realized that using it means writing new code, so I

Re: wininet: Make resolving hostnames thread safe.

2008-05-24 Thread Rob Shearman
2008/5/19 Hans Leidekker <[EMAIL PROTECTED]>: > @@ -151,7 +158,21 @@ BOOL GetAddress(LPCWSTR lpszServerName, INTERNET_PORT > nServerPort, > name = HeapAlloc(GetProcessHeap(), 0, sz+1); > WideCharToMultiByte( CP_UNIXCP, 0, lpszServerName, len, name, sz, NULL, > NULL ); > name[sz] =