> I don't see a good reason for writing small http server in tests. It's a lot
> of work. Certificate verification errors can be checked in crypt32 tests, it
> can be done locally (there are already some tests).
The crypt32 tests don't demonstrate the change you're making. wininet
(and winhttp) r
On Wed, May 19, 2010 at 5:27 AM, Piotr Caban wrote:
>> Or look at how Chromium does its ssl unit tests, by launching a little
>> server written in python:
>>
>> http://src.chromium.org/cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=net/socket/ssl_test_util.cc
>>
>> http://src.chromium.org/cgi-bin/gitw
On 05/19/10 07:40, Dan Kegel wrote:
Test can't be easily added to wine because we don't have pages to test
certificate errors on.
That should be addressed, no? E.g. with a page hosted at winehq.org
with a self-signed certificate?
It's writing a test case for one of possible errors. It won't pr
>> Test can't be easily added to wine because we don't have pages to test
>> certificate errors on.
>
>That should be addressed, no? E.g. with a page hosted at winehq.org
>with a self-signed certificate?
Or look at how Chromium does its ssl unit tests, by launching a little
server written in pyth
> Test can't be easily added to wine because we don't have pages to test
> certificate errors on.
That should be addressed, no? E.g. with a page hosted at winehq.org
with a self-signed certificate? That'd at least allow us to check the
expected error when the root of a certificate chain is untru
Hi,
On 05/19/10 02:01, Juan Lang wrote:
+if((lpwhr->hdr.ErrorMask&INTERNET_ERROR_MASK_COMBINED_SEC_CERT)
&& (
+res == ERROR_INTERNET_SEC_CERT_DATE_INVALID
+|| res == ERROR_INTERNET_INVALID_CA
+|| res == ERROR_INTERNET_SEC_C
Hi Piotr,
+if((lpwhr->hdr.ErrorMask&INTERNET_ERROR_MASK_COMBINED_SEC_CERT)
&& (
+res == ERROR_INTERNET_SEC_CERT_DATE_INVALID
+|| res == ERROR_INTERNET_INVALID_CA
+|| res == ERROR_INTERNET_SEC_CERT_NO_REV
+|
