Re: winex11.drv: Implement FIXME in AlphaBlend

2009-11-07 Thread Peter Urbanec
I've taken the following feedback on board and resubmitted the patch. Andrew Eikum wrote: This is less important, but you're not following the code conventions of the surrounding code. The surrounding code does not have spaces around function parameters, so yours shouldn't either. The exist

Re: winex11.drv: Implement FIXME in AlphaBlend

2009-11-04 Thread Roderick Colenbrander
Hi Peter, I didn't see this patch before because I was away at that time. The SourceConstantAlpha part looks correct to me. It might make sense to calculate blendfn.SourceConstantAlpha / 255 before the loop, so that it isn't recalculated each time. The other half of your patch is a separate chang