Re: winex11.drv: Fix buffer overflow bug in X11DRV_KeyEvent() andX11DRV_ToUnicodeEx()

2008-08-25 Thread Rob Shearman
2008/8/24 Dmitry Timoshkov <[EMAIL PROTECTED]>: > "Muneyuki Noguchi" <[EMAIL PROTECTED]> wrote: > >> winex11.drv: Fix buffer overflow bug in X11DRV_KeyEvent() and >> X11DRV_ToUnicodeEx() > >> +Str = (char *)malloc(64); >> +if (Str == NULL) >> +ERR("Failed to allocate memory!\n"); >

Re: winex11.drv: Fix buffer overflow bug in X11DRV_KeyEvent() andX11DRV_ToUnicodeEx()

2008-08-23 Thread Dmitry Timoshkov
"Muneyuki Noguchi" <[EMAIL PROTECTED]> wrote: > winex11.drv: Fix buffer overflow bug in X11DRV_KeyEvent() and > X11DRV_ToUnicodeEx() > +Str = (char *)malloc(64); > +if (Str == NULL) > +ERR("Failed to allocate memory!\n"); Please don't use malloc() in Wine, use win32 Heap*** APIs