Re: winex11.drv: Do not trash existing clip rectangle if XInput2 is not available.

2012-03-27 Thread Alexandre Julliard
Vitaliy Margolen writes: > On 03/27/2012 08:04 AM, Alexandre Julliard wrote: >> Vitaliy Margolen writes: >> >>> Dinput needs to talk to x11drv directly to get xi2 events. Same for >>> requests to clip cursor in exclusive mode. The current method of using >>> hooks can stay for backwards compatib

Re: winex11.drv: Do not trash existing clip rectangle if XInput2 is not available.

2012-03-27 Thread Vitaliy Margolen
On 03/27/2012 08:04 AM, Alexandre Julliard wrote: Vitaliy Margolen writes: Dinput needs to talk to x11drv directly to get xi2 events. Same for requests to clip cursor in exclusive mode. The current method of using hooks can stay for backwards compatibility. I'm not at all convinced that this

Re: winex11.drv: Do not trash existing clip rectangle if XInput2 is not available.

2012-03-27 Thread Alexandre Julliard
Vitaliy Margolen writes: > Dinput needs to talk to x11drv directly to get xi2 events. Same for > requests to clip cursor in exclusive mode. The current method of using > hooks can stay for backwards compatibility. I'm not at all convinced that this would be an improvement, particularly since you

Re: winex11.drv: Do not trash existing clip rectangle if XInput2 is not available.

2012-03-27 Thread Vitaliy Margolen
On 03/27/2012 02:29 AM, Alexandre Julliard wrote: Vitaliy Margolen writes: If you have suggestions on how to do this differently please explain them. Dinput needs to talk to x11drv directly to get xi2 events. Same for requests to clip cursor in exclusive mode. The current method of using hoo

Re: winex11.drv: Do not trash existing clip rectangle if XInput2 is not available.

2012-03-27 Thread Alexandre Julliard
Vitaliy Margolen writes: > If Dmitry fixes a real bug that means dinput shouldn't depend on > broken behavior. And I'm questioning that exact behavior which > shouldn't have been there in the first place. Dinput's exclusive mode > works regardless of what ClipCursor is set to. Of course the beha

Re: winex11.drv: Do not trash existing clip rectangle if XInput2 is not available.

2012-03-26 Thread Vitaliy Margolen
On 03/26/2012 08:15 AM, Alexandre Julliard wrote: Vitaliy Margolen writes: On 03/26/2012 06:14 AM, Alexandre Julliard wrote: Dmitry Timoshkov writes: This patch makes dlls/user32/input.c and dlls/user32/monitor.c tests pass on a system without XInput2. It will break dinput, we rely on t

Re: winex11.drv: Do not trash existing clip rectangle if XInput2 is not available.

2012-03-26 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Alexandre Julliard wrote: > >> > Is that a way how dinput detects xinput2 support? Or is that a general >> > approach to detect if a driver supports mouse clipping? How did it work >> > before? >> >> It's used to detect that xinput2 is not supported. > > Apparently di

Re: winex11.drv: Do not trash existing clip rectangle if XInput2 is not available.

2012-03-26 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > Is that a way how dinput detects xinput2 support? Or is that a general > > approach to detect if a driver supports mouse clipping? How did it work > > before? > > It's used to detect that xinput2 is not supported. Apparently dinput shouldn't rely on this, but I don

Re: winex11.drv: Do not trash existing clip rectangle if XInput2 is not available.

2012-03-26 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Is that a way how dinput detects xinput2 support? Or is that a general > approach to detect if a driver supports mouse clipping? How did it work > before? It's used to detect that xinput2 is not supported. -- Alexandre Julliard julli...@winehq.org

Re: winex11.drv: Do not trash existing clip rectangle if XInput2 is not available.

2012-03-26 Thread Alexandre Julliard
Vitaliy Margolen writes: > On 03/26/2012 06:14 AM, Alexandre Julliard wrote: >> Dmitry Timoshkov writes: >> >>> This patch makes dlls/user32/input.c and dlls/user32/monitor.c tests pass >>> on a system without XInput2. >> >> It will break dinput, we rely on the clip rectangle being reset. >> > I

Re: winex11.drv: Do not trash existing clip rectangle if XInput2 is not available.

2012-03-26 Thread Vitaliy Margolen
On 03/26/2012 06:14 AM, Alexandre Julliard wrote: Dmitry Timoshkov writes: This patch makes dlls/user32/input.c and dlls/user32/monitor.c tests pass on a system without XInput2. It will break dinput, we rely on the clip rectangle being reset. I'd say it again, dinput should not warp mouse u

Re: winex11.drv: Do not trash existing clip rectangle if XInput2 is not available.

2012-03-26 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > This patch makes dlls/user32/input.c and dlls/user32/monitor.c tests pass > > on a system without XInput2. > > It will break dinput, we rely on the clip rectangle being reset. Is that a way how dinput detects xinput2 support? Or is that a general approach to detect

Re: winex11.drv: Do not trash existing clip rectangle if XInput2 is not available.

2012-03-26 Thread Alexandre Julliard
Dmitry Timoshkov writes: > This patch makes dlls/user32/input.c and dlls/user32/monitor.c tests pass > on a system without XInput2. It will break dinput, we rely on the clip rectangle being reset. -- Alexandre Julliard julli...@winehq.org