Daniel writes:
> @@ -54,11 +56,13 @@ HPEN CDECL X11DRV_SelectPen( X11DRV_PDEVICE *physDev,
> HPEN hpen )
> elp = HeapAlloc( GetProcessHeap(), 0, size );
>
> GetObjectW( hpen, size, elp );
> -/* FIXME: add support for user style pens */
> +
> logpen.lopnStyle
OK, actually it looks like the problem is already in X11DRV_SelectPen
and is unlikely to occur, so my patches are good.
Still, I'm thinking that if GetObjectW fails
(http://source.winehq.org/source/dlls/winex11.drv/pen.c#L45) then we
should immediately exit the function returning zero rather than
grr, please disregard previous patches. I've discovered a problem that
can lead to use of un-initialized values.
Daniel
On 02/15/2011 01:09 AM, Daniel wrote:
> Clean up per Vitaliy's direction. Also found a FIXME comment that needed
> to be removed.
>
> Daniel
>
>
>
On 02/14/2011 03:55 AM, Daniel wrote:
Hello all. This only covers the screen. Support still needs to be added
to printers.
+ case PS_USERSTYLE: {
+for(i = 0; i < physDev->pen.dash_len ; i++) {
Please follow file style - curly braces on separate line. No braces for
single lin
