On Wed, Feb 18, 2009 at 5:20 AM, Francois Gouget wrote:
> My remark was not so much about including windows.h rather than
> winfoo.h, but about including it in winetest.h when the parent C file
> has already included the winxxx.h files it needs. That is, in Wine it
> seems we have a policy to put
On Tue, 17 Feb 2009, Steven Edwards wrote:
> On Tue, Feb 17, 2009 at 12:51 PM, Francois Gouget wrote:
> > ---
> >
> > I moved them after the windows.h include though in practice the needed
> > winnt.h has already been included by the time we include winetest.h. So
> > maybe windows.h should be nu
On Wed, Feb 18, 2009 at 3:16 AM, Dmitry Timoshkov
wrote:
> Is there a specific problem you are trying to point out indirectly,
> or that's just a speculation?
I was just thinking perhaps we need a better way of making sure the
headers match up with the PSDK. I know we can do a MSVC configuration
"Steven Edwards" wrote:
> I've agreed with the logic and the reasons behind it for the Wine
> libraries. My point was that we already avoid it more than enough in
> libraries, and maybe its a good thing after far as winelib goes to
> insure the apps in the programs directory always do include win
On Tue, Feb 17, 2009 at 10:40 PM, Dmitry Timoshkov
wrote:
> The reason why we avoid windows.h inclusion in Wine is compilation
> time by avoiding inclusion of all-in-one headers windows.h does. It's
> always a good programming practice to include only those .h files that
> are really needed, inclu
"Steven Edwards" wrote:
> Conversely maybe using windows.h usage should be fixed and used more
> often. Wine is an oddball when it comes to win32 program with the
> excessive lengths it goes to, to avoid using windows.h. I am starting
> to think even avoiding it internally like we do causes more
On Tue, Feb 17, 2009 at 12:51 PM, Francois Gouget wrote:
> ---
>
> I moved them after the windows.h include though in practice the needed
> winnt.h has already been included by the time we include winetest.h. So
> maybe windows.h should be nuked altogether...
Conversely maybe using windows.h usag
