Re: wineoss.drv: Eliminate all 64-bits warnings

2008-12-02 Thread Alexandre Julliard
Maarten Lankhorst <[EMAIL PROTECTED]> writes: > sizeof is defined as int on 32-bits, and long on 64-bits. To keep this > working I'm casting all sizeofs to longs Please don't add casts, simply get rid of sizeof in traces like we did in the rest of the code. And please do it as a separate patch.

Re: wineoss.drv: Eliminate all 64-bits warnings

2008-12-02 Thread Kai Blin
On Tuesday 02 December 2008 10:28:04 Austin English wrote: > Minor, but you've got a few extraneous whitespace changes: Those are on otherwise empty lines, I don't see how that'd matter. The reason people don't like formatting-only patches is that it breaks "git blame" history. As git blame supp

Re: wineoss.drv: Eliminate all 64-bits warnings

2008-12-02 Thread Austin English
On Tue, Dec 2, 2008 at 3:19 AM, Maarten Lankhorst <[EMAIL PROTECTED]> wrote: > sizeof is defined as int on 32-bits, and long on 64-bits. To keep this > working I'm casting all sizeofs to longs > --- > Minor, but you've got a few extraneous whitespace changes: diff --git a/dlls/wineoss.drv/audio.c