Re: winemp3.acm: Fixes the Mac-specific code (try 2)

2010-05-19 Thread Aric Stewart
Hi, I was excited to try out this patch but now it is giving me a crash. (OS/X 10.5.8) Backtrace: =>0 0x12a9 (0x0033d81c) 1 0x086e (0x0033d838) 2 0x936f5a47 _ZN14CodecConverter14AppendNewInputEmPcmRmP28AudioStreamPacketDescription+0xb6() in audiotoolbox (0x0033d888) 3 0x936f56

Re: [Fwd: Re: winemp3.acm: Fixes the Mac-specific code]

2010-05-13 Thread Kristofer Henriksson
I think the reason why your change works is that it seems the AudioConverter doesn't care if it has invalid data at the beginning of its stream. There will be however a little creeping error in computation of frame lengths over time, which is that there may or may not be one extra byte of padding o

Re: [Fwd: Re: winemp3.acm: Fixes the Mac-specific code]

2010-05-13 Thread Aric Stewart
There is a bug in the code i just posted, It should clearly be adsi->pwfxSrc->nSamplesPerSec not Dst. Still works great, probibly because my tests had the same nSamplesPerSec for both Src and Dst. -aric Aric Stewart wrote: Hi, I will admit that my understanding of both ACM drivers as we

Re: [Fwd: Re: winemp3.acm: Fixes the Mac-specific code]

2010-05-13 Thread Aric Stewart
Hi, I will admit that my understanding of both ACM drivers as well as the os x audio libraries are not perfect and mostly come from work on this code itself. So i will fully admit it is most likely full of areas needing improvement. Kristofer Henriksson wrote: Aric, I may have been opera

Re: winemp3.acm: Fixes the Mac-specific code

2010-05-13 Thread Aric Stewart
Hi, It is good to see someone working on this code. But your patch makes it so that all the mp3 sound clips in the game that I was coding for stop working. trace:mpeg3:mp3_leopard_horse ndst 147456 0x2eab348 <- 19901 0x2ea657c trace:mpeg3:mp3_leopard_horse First 16 bytes to input: "\x00\