Re: wined3d: Fix regression from dynamic constants patch

2006-07-21 Thread Jason Green
I was getting ready to argue with you this point, but you made a comment on IRC that changed my mind: "I thought the idea was to support the full range of the hardware". And, you're right. :-) So, please ignore this patch for now - I'll re-work it over the weekend and resubmit. On 7/21/06, Iv

Re: wined3d: Fix regression from dynamic constants patch

2006-07-21 Thread Ivan Gyurdiev
There were plenty of ways to fix this. One would have been to unroll all of the memset/memcpy calls into functions that explicitly set every value on the stateblock. While this might have been more "correct", it would be harder to maintain. I argue that an explicit initializer is always bette