Re: wined3d: Avoid crashing when ProcessVertices is called with NULL vertex declaration

2006-09-04 Thread Stefan Dösinger
Hi, > I don't understand what the code does but every part of it depends on > having a non-NULL SrcImpl. I think screaming bloody murder but continuing > is better than crashing. > > I agree that the code doesn't look good but at least testing can proceed > past this point. For some reason I didn't

Re: wined3d: Avoid crashing when ProcessVertices is called with NULL vertex declaration

2006-09-04 Thread H. Verbeet
On 04/09/06, Paul Chitescu <[EMAIL PROTECTED]> wrote: Well, what do you thing it did before at the line if(SrcImpl->vbo) { ... if SrcImpl is NULL? I don't understand what the code does but every part of it depends on having a non-NULL SrcImpl. I think screaming bloody murder but cont

Re: wined3d: Avoid crashing when ProcessVertices is called with NULL vertex declaration

2006-09-04 Thread Paul Chitescu
On Mon, 4 Sep 2006, H. Verbeet wrote: > On 04/09/06, Paul Chitescu <[EMAIL PROTECTED]> wrote: > > Changelog: Avoid a segfault in IWineD3DDeviceImpl_ProcessVertices by > > checking > > if SrcImpl (parameter pVertexDecl) is NULL. > > > > The function is called from dlls/d3d8/device.c > > IDirect3DDe

Re: wined3d: Avoid crashing when ProcessVertices is called with NULL vertex declaration

2006-09-04 Thread H. Verbeet
On 04/09/06, Paul Chitescu <[EMAIL PROTECTED]> wrote: Changelog: Avoid a segfault in IWineD3DDeviceImpl_ProcessVertices by checking if SrcImpl (parameter pVertexDecl) is NULL. The function is called from dlls/d3d8/device.c IDirect3DDevice8Impl_ProcessVertices with an explicit NULL as vertex decl