Re: winecoreaudio.drv: Improve underrun handling

2012-01-30 Thread Andrew Eikum
On Mon, Jan 30, 2012 at 06:52:36PM +0100, joerg-cyril.hoe...@t-systems.com wrote: > Andre Eikum wrote: > >>> +sc = AudioQueueEnqueueBufferWithParameters(This->aqueue, > >>> +This->public_buffer, 0, NULL, 0, 0, 0, NULL, > >>> + &req_time, &start_time); > >> NULL=ASAP is exa

Re: winecoreaudio.drv: Improve underrun handling

2012-01-30 Thread Joerg-Cyril . Hoehle
Hi, Andre Eikum wrote: >>> +sc = AudioQueueEnqueueBufferWithParameters(This->aqueue, >>> +This->public_buffer, 0, NULL, 0, 0, 0, NULL, >>> + &req_time, &start_time); >> NULL=ASAP is exactly what we want. We don't want ALSA/dmix behavior, >> where it'll silently skip over

Re: winecoreaudio.drv: Improve underrun handling

2012-01-30 Thread Andrew Eikum
On Mon, Jan 30, 2012 at 11:03:52AM +0100, joerg-cyril.hoe...@t-systems.com wrote: > +sc = AudioQueueEnqueueBufferWithParameters(This->aqueue, > +This->public_buffer, 0, NULL, 0, 0, 0, NULL, &req_time, > &start_time); > I advise against setting req_time. This can only frag

winecoreaudio.drv: Improve underrun handling

2012-01-30 Thread Joerg-Cyril . Hoehle
Andrew, The good news is that your underrun patch prevents mmdevapi from writing less and less frames in mmdevapi/tests/render:test_worst_case http://test.winehq.org/data/f0cfa7cf46d7c832fb8429d1a1b7c49c46c0/mac_jch-osx58-gecko/mmdevapi:render.html >render.c:1631: Released 86436=98x882 -0 fram

Re: [PATCH] winecoreaudio.drv: Improve underrun handling

2012-01-28 Thread Ken Thomases
On Jan 27, 2012, at 3:46 PM, Andrew Eikum wrote: > +if(list_count(&This->queued_bufinfos) == 0){ > +sc = AudioQueueGetCurrentTime(This->aqueue, NULL, &req_time, NULL); This isn't quite the same as the next start time. Even if there are no remaining queued buffers, the queue may stil