re: wineconsole: Wait on events in curses backend using select instead of poll

2008-12-04 Thread Dan Kegel
James McKenzie wrote: > This will have to be setup so that it only works for Macs. > ... it does not belong in the Wine code stack. Why? Select is a perfectly reasonable choice -- and arguably preferable to poll -- when you are absolutely sure that no file descriptor higher than 1023 can be passe

Re: wineconsole: Wait on events in curses backend using select instead of poll

2008-12-04 Thread Martin Storsjö
On Thu, 4 Dec 2008, Damjan Jovanovic wrote: On Mon, Dec 1, 2008 at 11:57 AM, Martin Storsjö <[EMAIL PROTECTED]> wrote: But there may of course be other reasons for using poll, which I don't know about. select() not only has a hard limit on the number of file descriptors (1024 or whatever) th

Re: wineconsole: Wait on events in curses backend using select instead of poll

2008-12-03 Thread Damjan Jovanovic
On Mon, Dec 1, 2008 at 11:57 AM, Martin Storsjö <[EMAIL PROTECTED]> wrote: > On Mon, 1 Dec 2008, Kai Blin wrote: > >> On Sunday 30 November 2008 00:52:57 Martin Storsjö wrote: >>> >>> poll can't handle terminal devices on Darwin, since Tiger. See the >>> following discussion: >>> http://lists.apple

Re: wineconsole: Wait on events in curses backend using select instead of poll

2008-12-03 Thread James McKenzie
Martin Storsjö wrote: > > poll can't handle terminal devices on Darwin, since Tiger. See the > following discussion: > http://lists.apple.com/archives/Darwin-dev/2006/Apr/msg00066.html > This will have to be setup so that it only works for Macs. Maybe this can be a static patch in the Darwine code

Re: wineconsole: Wait on events in curses backend using select instead of poll

2008-12-01 Thread Martin Storsjö
On Mon, 1 Dec 2008, Kai Blin wrote: On Sunday 30 November 2008 00:52:57 Martin Storsjö wrote: poll can't handle terminal devices on Darwin, since Tiger. See the following discussion: http://lists.apple.com/archives/Darwin-dev/2006/Apr/msg00066.html There's reasons we switched from select to p

Re: wineconsole: Wait on events in curses backend using select instead of poll

2008-11-30 Thread Kai Blin
On Sunday 30 November 2008 00:52:57 Martin Storsjö wrote: > poll can't handle terminal devices on Darwin, since Tiger. See the > following discussion: > http://lists.apple.com/archives/Darwin-dev/2006/Apr/msg00066.html There's reasons we switched from select to poll. You can't just switch back to

Re: wineconsole: Wait on events in curses backend using select instead of poll

2008-11-29 Thread Martin Storsjö
On Sun, 30 Nov 2008, Kirill K. Smirnov wrote: >> Should I add a >> check for sys/select.h in the configure script and conditionally included >> it, surrounded by HAVE_SYS_SELECT_H? Or would sys/time.h, sys/types.h and >> unistd.h be enough to consider it reasonably compatible? > Ideally - should.

wineconsole: Wait on events in curses backend using select instead of poll

2008-11-29 Thread Kirill K. Smirnov
>Should I add a >check for sys/select.h in the configure script and conditionally included >it, surrounded by HAVE_SYS_SELECT_H? Or would sys/time.h, sys/types.h and >unistd.h be enough to consider it reasonably compatible? Ideally - should. But... 1) There isn't any 'select.h' substring in whol

Re: wineconsole: Wait on events in curses backend using select instead of poll

2008-11-29 Thread Martin Storsjö
Hi Kirill, On Sat, 29 Nov 2008, Kirill K. Smirnov wrote: >> +ret = select(pipefd + 1, &readfds, &writefds, &errorfds, NULL); > Passing NULL instead of &writefds in this case is better, IMO. It is not used > anyway. Ok > I strongly believe that errorfds parameter os select() is useful fo

wineconsole: Wait on events in curses backend using select instead of poll

2008-11-29 Thread Kirill K. Smirnov
Hi, Martin, >+ret = select(pipefd + 1, &readfds, &writefds, &errorfds, NULL); Passing NULL instead of &writefds in this case is better, IMO. It is not used anyway. ...and... I strongly believe that errorfds parameter os select() is useful for sockets only, not for stdio (I am not sure