Re: winealsa.drv: Add mmdevapi driver.

2011-04-27 Thread Reece Dunn
On 27 April 2011 15:48, wrote: > Andrew Eikum wrote: > >>>Does CoTaskMemFree match HeapAlloc? >>would anyone more familiar with CoTaskMem* want to comment? CoTaskMemFree should be used on memory allocated with CoTaskMalloc (just like malloc/free, HeapAlloc/HeapFree, etc.). It is typically used f

winealsa.drv: Add mmdevapi driver.

2011-04-27 Thread Joerg-Cyril.Hoehle
Andrew Eikum wrote: >>Does CoTaskMemFree match HeapAlloc? >would anyone more familiar with CoTaskMem* want to comment? [cbSize slot present?] >Hm, to my surprise it seems MS no longer does this check as of Win7. Well, it's consistent with the documentation. So it's only the winmm API that has t

Re: winealsa.drv: Add mmdevapi driver.

2011-04-26 Thread Andrew Eikum
On 04/26/2011 11:26 AM, Andrew Eikum wrote: dump_fmt +TRACE("cbSize: %u\n", fmt->cbSize); Old Wine code contains several comments about never ever reading cbSize in the WAVE_FORMAT_PCM case because it's a potential read past the structure and may cause a segmentation fault. Is it not a

Re: winealsa.drv: Add mmdevapi driver.

2011-04-26 Thread Andrew Eikum
Thanks for your comments, Jörg. On 04/26/2011 06:00 AM, joerg-cyril.hoe...@t-systems.com wrote: +fmt->Format.nSamplesPerSec = 41100; +fmt->nSamplesPerSec != 41100&& 44100. IIRC, there was an error exactly like this somewhere in the old drivers. Silly typo. Thanks. But wh

winealsa.drv: Add mmdevapi driver.

2011-04-26 Thread Joerg-Cyril.Hoehle
Andrew, +fmt->Format.nSamplesPerSec = 41100; +fmt->nSamplesPerSec != 41100 && 44100. IIRC, there was an error exactly like this somewhere in the old drivers. But why does your IsFormatSupported only accept 48kHz, 44.1, 22.050, etc.? Do the native drivers behave like this? Is