Dmitry Timoshkov wrote:
> > Also, I just noticed that you're calling create_metadata_reader
> > unconditionally from QueryInterface, and not checking in the process
> > whether the reader has already been created. That will leak if QI is
> > called multiple times.
> >
> > I'm not sure doing real
Vincent Povirk wrote:
> >> We can't use that stream because we provide separate seek and
> >> read/write methods to libtiff, and libtiff may rely on the stream's
> >> position to not change between operations.
> >
> > libtiff doesn't rely on stream positions, and my use of stream matches
> > MSDN
>> > + hr = IWICPersistStream_LoadEx(persist, This->parent->stream,
>> > NULL, persist_options);
>> > + if (FAILED(hr))
>> > + ERR("IWICPersistStream_LoadEx error %#x\n", hr);
>>
>> We can't use that stream because we provide separate seek and
>> read/write methods to libt
Vincent Povirk wrote:
> > + hr = IWICPersistStream_LoadEx(persist, This->parent->stream, NULL,
> > persist_options);
> > + if (FAILED(hr))
> > + ERR("IWICPersistStream_LoadEx error %#x\n", hr);
>
> We can't use that stream because we provide separate seek and
> read/wri
> + hr = IWICPersistStream_LoadEx(persist, This->parent->stream, NULL,
> persist_options);
> + if (FAILED(hr))
> + ERR("IWICPersistStream_LoadEx error %#x\n", hr);
We can't use that stream because we provide separate seek and
read/write methods to libtiff, and libtiff may
