subject:"windowscodecs\: Create a IWICMetadataReader for a TIFF frame. Take 2."

Re: windowscodecs: Create a IWICMetadataReader for a TIFF frame. Take 2.

2012-06-18 Thread Dmitry Timoshkov

Vincent Povirk wrote: > This looks better, but I still think you should use > WICPersistOptionNoCacheStream. > > Some of your failure cases in create_metadata_reader will return a > reference to an IWICMetadataReader, which seems wrong. Apparently that was a hasty attempt to make the patch appe

Re: windowscodecs: Create a IWICMetadataReader for a TIFF frame. Take 2.

2012-06-18 Thread Vincent Povirk

This looks better, but I still think you should use WICPersistOptionNoCacheStream. Some of your failure cases in create_metadata_reader will return a reference to an IWICMetadataReader, which seems wrong.